fix(frontend-e2e): the nightly's two causes — the rail transition split the model-choice spec's reads, and Vite never pre-bundled the lazy mermaid import (#2705) - #2714
Merged
Conversation
… never re-optimises mid-session (#2705) Vite 8's dependency scanner tree-shakes each script block before it records imports, so CanvasDiagram.vue's `import('mermaid')` inside an unexported helper in a plain <script> block was never pre-bundled. The first served page whose module graph included the file registered the missing dep, re-optimised, and sent a full reload to every open tab — every developer's, and every Playwright page mid-run, which is why agent-detail-request-dedupe.spec.js saw every /api request twice. - vite.config.js: optimizeDeps.include lists every package a dynamic import('…') under src/ names (mermaid, qrcode). - scripts/scan-dynamic-imports.mjs: finds them (script blocks only; comments and regex literals blanked, strings kept; non-literal specifiers reported). - tests/unit/optimizeDepsIncludeGuard.spec.js: checks the list against the RESOLVED config via resolveConfig; red on the previous config, green now. - docs/memory/architecture/frontend.md: the rule, in the owning area file. Refs #2705 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… reduced motion (#2705) Since #2676 the workspace rail column enters through a 300 ms width transition once the roster arrives, and everything left of it moves with it. The spec read Send's box, then each button's, then clicked at remembered coordinates; the two Send reads straddled the transition, the stale send.x made the Send-skip miss Send itself, and "an icon button sits right of the picker" fired on Send's own right edge — 3 of 3 attempts at 768 and 1280 in some CI stacks, while 375 passed only because the column is hidden below sm. Every box now comes from ONE page.evaluate (the locators choose the elements, the page returns the geometry in one frame), the page emulates reduced motion so the entry is instant, and the shell click is an element action. 41 of 41 across ten repeats locally, against 4 failures in 6 before. Also: the feature-flow rows for the spec, three learnings-ledger entries (the one-frame rule, the scanner class, and "read the summary line before attributing a red"), and the cso --diff report (no findings). The dedupe spec's older compatibility-x2 double fetch remains and is #2710; the rail column's load-time shift is #2711; e2e on the production image is #2712. Fixes #2705 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
webmixgamer
added
the
ui
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…losing tag's > (#2705) CodeQL's js/bad-tag-filter flagged the <script> block regex for not matching `</script >`. The regex extracts script blocks from SFC source rather than sanitising anything, but a closing tag with whitespace before its `>` is valid HTML and the extractor should read it, so the pattern now allows it, with a fixture that closes one block that way. Refs #2705 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ing before its > (#2705) CodeQL's js/bad-tag-filter re-flagged the pattern on the previous head with `</script\t\n bar>`: the rule wants the end tag to accept any attribute-like noise before `>`, the same `[^>]*` shape the opening tag already uses. A browser closes the block on such a tag too, so the extractor should read it. Refs #2705 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Sep 11, 2026
Merged
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend-e2ered (frontend-e2e nightly @smoke suite is red on dev #2705) had two independent causes. This PR fixes both and claims only these.workspace-model-choice.spec.jsread the composer's boxes across several round-trips while the rail column's 300 ms width transition (The Workspace rail column steps discretely when a voice call ends (#2640 follow-up) #2676) moved them: the two Send reads straddled it, the stalesend.xmade the Send-skip miss Send itself, and the assertion fired on Send's own right edge, 3 of 3 attempts at 768 and 1280 in some CI stacks. It now reads every box in onepage.evaluateunder reduced motion and clicks the shell as an element action. 41 of 41 across ten local repeats, against 4 failures in 6 before.CanvasDiagram.vue's lazyimport('mermaid')in an unexported helper was never pre-bundled; the first served page that included it re-optimised and full-reloaded every open tab (the dedupe spec's x2-of-everything flake, and every developer's tabs after a container start).optimizeDeps.includenow lists every dynamic bare import, enforced by a scanner script plus a vitest guard against the resolved config.Changes
src/frontend/vite.config.js:optimizeDeps.include: ['mermaid', 'qrcode'], with the why.src/frontend/scripts/scan-dynamic-imports.mjs: finds dynamic bare imports (script blocks only; comments and regex literals blanked, strings kept; non-literal specifiers reported as unscannable).src/frontend/tests/unit/optimizeDepsIncludeGuard.spec.js: extractor fixtures plus the rule againstresolveConfig; red on the previous config.src/frontend/e2e/workspace-model-choice.spec.js: reduced motion, one-frame snapshot, element click.docs/memory/architecture/frontend.md(the rule),workspace-model-choice.mdand its index row, threelearnings.mdentries, thecso --diffreport (no findings).What this does not fix
compatibility x2signature that predates the mermaid import: a product double fetch, filed as bug: CompatibilityPanel fetches /api/agents/{name}/compatibility twice on one Agent Detail load (mount + agent-name watcher) #2710. Expect that spec to stay flaky until it lands.Test Plan
npm run test:unit: 2705 passed with the new guard in the suite (the one failing file is the known host-only missing@vue/compiler-sfc).mermaidandqrcode), green now;vite optimize --forcelists both as pre-bundled.CanvasDiagram.vueagainst/node_modules/.vite/deps/mermaid.jswith no later re-optimisation in the log.workspace-model-choice.spec.js --repeat-each 10: 41 passed.agent-detail-request-dedupe.spec.js: 3 passed locally with no reload.frontend-e2egreen on this PR; the nightly'sreportjob closes frontend-e2e nightly @smoke suite is red on dev #2705 on the first green night.Fixes #2705
🤖 Generated with Claude Code