You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
bug: circuit-breaker integration test still counts the old operator-queue call for the dormant alert (stale since #3246) #3343
tests/integration/test_circuit_breaker.py::TestDormantState::test_dormant_transition_emits_operator_queue_alert fails on dev. #3246 part 1 (#3255) moved the circuit breaker's dormant alarm onto the platform-alerts seam (services/platform_alerts.py), so services/agent_client/circuit.py now files it through db.create_platform_operator_queue_item. The test still counts the old call:
The alert itself still fires. The captured log shows the circuit_breaker_dormant entry created through create_platform_operator_queue_item. Only the test is out of date.
The test also logs a non-fatal [platform-alerts] could not schedule a follow-up warning (spawn_on_loop called from a thread with no running loop). That comes from driving record_failure() synchronously outside an event loop, and is worth checking while the test is updated.
Acceptance Criteria
The test asserts the platform-alert path: one create_platform_operator_queue_item call (or the platform-alerts subject for the dormant kind) on the closed/open → dormant transition.
It still proves the alert fires exactly once, and not again on a later failure while the circuit stays dormant.
The test passes against a running integration Redis (/verify-local integration stage, or pytest tests/integration/test_circuit_breaker.py).
Activity