Repository navigation
Conversation
…index can't be read offline
Contributor
|
Hi @EMPLORES, the approach is on the right track yet a few technical blockers before this is ready to merge:
Please update the PR with these fixes so we can get this merged cleanly! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #226(Phase A)Ship the examples index with the wheel so
skillware examplesandskillware list --examplescan work for pip-only installs without relying on GitHub raw access.Changes
examples/README.mdtoskillware/resources/examples/README.mdduring the build.build_pycommand inpyproject.toml._examples_readme_path()to check the packaged copy before checkout/cwd discovery and GitHub fallback.Verification
python -m build --wheelpython -m skillware examplesoutside the repository.python -m skillware list --examples.