Feature/provenance (no to be merged) by Kyrosh · Pull Request #29 · AKSW/QuitStore

Kyrosh · 2017-05-30T13:02:11Z

No description provided.

splattater · 2017-05-30T13:15:25Z

Hey @Kyrosh thank you for your pull request. Can you please

create a module containg utils.py and all rdflib clones (evaluate.py ...)
move git.py (replacing GitRepo) and graphs.py to core.py
check if there is a solution for add/delete quads (via Flask API) that supports provenance without use of FileReference class. If so, delete FileReference from core.py
delete deprecated.py
are there other candidates that may be merged to a module? (serializer, parser?)

… direct queries

into feature/provenance Conflicts: quit/core.py quit/graphs.py quit/provenance.py quit/tools/processor.py quit/web/modules/debug.py quit/web/templates/blame.html

…ile for unassigned graphs, added default branch from config, fixed serializer

…es, moved clean_path,

…pdown in call,

into feature/provenance_temp

…redirect

white-gecko

Would it be possible to put the complete web frontend for the browser presentation into a separate code base? Quit should only contain the SPARQL endpoint and any additional API needed.

white-gecko · 2017-08-09T06:44:36Z

@@ -0,0 +1,6 @@
+/*!


Maybe we should not include a static version of bootstrap in the repo, but use something like this: https://pythonhosted.org/Flask-Bootstrap/

Kyrosh · 2017-08-10T23:11:26Z

@white-gecko It would be possible to provide the frontend as a seperate project. One possibility to do so: the quit store itself provides an API and a minimalistic server for the sparql endpoint. When the fronend is used it could provide its own server, only using the provided API and bypassing the quit store server (only one running). What do you think about this approach? Or we provide the frontend as a seperate package and check in the quit store if it is installed, if so, we use those endpoints instead. Both approaches would be sufficient, i think.

white-gecko · 2017-08-11T15:06:17Z

@white-gecko It would be possible to provide the frontend as a seperate project. One possibility to do so:
the quit store itself provides an API and a minimalistic server for the sparql endpoint. When the fronend is used it could provide its own server, only using the provided API and bypassing the quit store server (only one running). What do you think about this approach?

I thinks this sounds like the option I'm preferring. The Quit Store provides the necessary API and the front-end is using it. What do you mean by “bypassing the quit store server”?

Or we provide the frontend as a seperate package and check in the quit store if it is installed, if so, we use those endpoints instead. Both approaches would be sufficient, i think.

What exactly do you mean by separate package?

Further I'm looking for the documentation of the newly introduced store modes. Could you please add them to the README in your branch?

Kyrosh · 2017-08-15T08:57:28Z

I thinks this sounds like the option I'm preferring. The Quit Store provides the necessary API and the front-end is using it. What do you mean by “bypassing the quit store server”?

By that I just meant that the frontend has its own flask server, which will be used instead of the one included in the quit store. So we only have one server running at a time.

What exactly do you mean by separate package?

It's basically the same idea as the previous one. Two seperate and indepentent projects and packages.
In the first scenario the frontend server is startet via its own quit.py (just as an example).
In the second one we could run the quit.py of the main project, which checks if the frontent package is installed and available. If so, it registers the frontend endpoints, or otherwise its own endpoints.
Therefore the user won't have to run a seperate project, but instead he/she only needs to install the frontend package (extension).

Further I'm looking for the documentation of the newly introduced store modes. Could you please add them to the README in your branch?

Sure

white-gecko · 2017-08-21T14:31:16Z

+            current_app.logger.error(traceback.format_exc())
+            return "<pre>"+traceback.format_exc()+"</pre>", 400
+    else:
+        return render_template('sparql.html')


This should move to new Quit UI

white-gecko · 2017-08-21T14:31:38Z

+            current_app.logger.error(traceback.format_exc())
+            return "<pre>"+traceback.format_exc()+"</pre>", 400
+    else:
+        return render_template('provenance.html')


This should move to new Quit UI

white-gecko · 2017-08-23T14:09:25Z

I've deleted some already resolved comments. We should continue the discussion in #47

af-pna and others added 6 commits May 24, 2017 19:35

initial commit

776aa20

fixed endpoint (SELECT) and blame

6c9705a

added html for results

f55a282

fixed blame for different arguments

2119a36

some design, commits overview, fixed path bug, local js/css

5c72194

added ordered quad serializer, hex to prov store, git commit graphic

3726a2d

af-pna and others added 15 commits June 5, 2017 21:11

moved files to submodules, fixed blame, added provenance endpoint for…

58fd41d

… direct queries

temporary commit

249bda2

Merge branch 'feature/provenance' of https://github.com/Kyrosh/QuitStore

81488b4

into feature/provenance Conflicts: quit/core.py quit/graphs.py quit/provenance.py quit/tools/processor.py quit/web/modules/debug.py quit/web/templates/blame.html

fixed blame, cleanup

448214f

for presentation

afda713

moved plugins to tools, fixed rewriting and commits

28aec95

added fonts, working on commits and in-memory copies, added default f…

e491434

…ile for unassigned graphs, added default branch from config, fixed serializer

tag links, fix for sync, fix for sorted quads

a584a66

graphFile instead of hasQuadFile?, check against registered graph fil…

10755a4

…es, moved clean_path,

updated version of rdflib

6670f65

force copy, empty blame, cleaned quit.py initialize(), refactored dro…

604a922

…pdown in call,

Merge branch 'feature/provenance' of https://github.com/Kyrosh/QuitStore

c4db4ea

into feature/provenance_temp

clean_path and uriref for matching, fixed zero element cached generator

3595980

fixed exception, fixed find graph on commit

35fa609

storemode for config, fixed develop branch, config error page, index …

5a77237

…redirect

This was referenced Jul 6, 2017

Support for default graph in some default file #30

Open

Define default namespace mappings for UI #31

Closed

What happens if unconfigured graphs are present in a nq file #32

Closed

white-gecko requested changes Aug 9, 2017

View reviewed changes

white-gecko requested changes Aug 21, 2017

View reviewed changes

white-gecko changed the base branch from feature/provenance to master August 21, 2017 14:40

white-gecko changed the title ~~Feature/provenance~~ Feature/provenance (no to be merged) Aug 22, 2017

white-gecko merged commit 5a77237 into AKSW:master Jan 11, 2018

Navigation Menu

Uh oh!

Feature/provenance (no to be merged) - #29

Feature/provenance (no to be merged)#29
white-gecko merged 21 commits into
AKSW:masterfrom
Kyrosh:feature/provenance

Kyrosh commented May 30, 2017

Uh oh!

splattater commented May 30, 2017

Uh oh!

white-gecko left a comment

Uh oh!

white-gecko Aug 9, 2017

Uh oh!

white-gecko Aug 23, 2017

Uh oh!

Kyrosh commented Aug 10, 2017

Uh oh!

white-gecko commented Aug 11, 2017

Uh oh!

Kyrosh commented Aug 15, 2017

Uh oh!

white-gecko Aug 21, 2017

Uh oh!

white-gecko Aug 23, 2017

Uh oh!

white-gecko Aug 21, 2017

Uh oh!

white-gecko Aug 23, 2017

Uh oh!

white-gecko commented Aug 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Kyrosh commented May 30, 2017

Uh oh!

splattater commented May 30, 2017

Uh oh!

white-gecko left a comment

Choose a reason for hiding this comment

Uh oh!

white-gecko Aug 9, 2017

Choose a reason for hiding this comment

Uh oh!

white-gecko Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

Kyrosh commented Aug 10, 2017

Uh oh!

white-gecko commented Aug 11, 2017

Uh oh!

Kyrosh commented Aug 15, 2017

Uh oh!

white-gecko Aug 21, 2017

Choose a reason for hiding this comment

Uh oh!

white-gecko Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

white-gecko Aug 21, 2017

Choose a reason for hiding this comment

Uh oh!

white-gecko Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

white-gecko commented Aug 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants