Skip to content

File attachment support - #560

Merged
F43nd1r merged 17 commits into
ACRA:masterfrom
F43nd1r:file
Mar 25, 2017
Merged

File attachment support#560
F43nd1r merged 17 commits into
ACRA:masterfrom
F43nd1r:file

Conversation

@F43nd1r

@F43nd1r F43nd1r commented Mar 11, 2017

Copy link
Copy Markdown
Member

Resolve #558
Resolve #561

@F43nd1r F43nd1r changed the title File attachmetn support (experimental) File attachment support (experimental) Mar 11, 2017
@F43nd1r

F43nd1r commented Mar 13, 2017

Copy link
Copy Markdown
Member Author

@MFlisar I've updated the project with a builtin content provider for all standard directories. So you'd only need a custom ContentProvider for non-file content.

@MFlisar

MFlisar commented Mar 13, 2017

Copy link
Copy Markdown

I'll check that tomorrow. Only thing to take care of is, I would not use this provider. It's unsafe, other apps could access all files that the app which is using ACRA can access.

I think, the default one in acra should only allow to access files in a cache folder, for safety reasons even only for files in a sub acra folder...

@F43nd1r

F43nd1r commented Mar 13, 2017

Copy link
Copy Markdown
Member Author

The content provider is not exported. Only apps called by ACRA will receive temporary permissions for exactly the files in the intent.

@MFlisar

MFlisar commented Mar 13, 2017

Copy link
Copy Markdown

Oh, then it's fine. I've not seen that...

@F43nd1r

F43nd1r commented Mar 13, 2017

Copy link
Copy Markdown
Member Author

Android takes care of the security management. That is the only reason to use content uris over file uris in this usecase.

@F43nd1r F43nd1r changed the title File attachment support (experimental) File attachment support Mar 22, 2017
@F43nd1r
F43nd1r merged commit 61e846a into ACRA:master Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants