Skip to content

Restructure forceCloseDialogAfterToast to alsoReportToAndroidFramework - #438

Merged
william-ferguson-au merged 2 commits into
ACRA:masterfrom
F43nd1r:report_native
Apr 28, 2016
Merged

Restructure forceCloseDialogAfterToast to alsoReportToAndroidFramework#438
william-ferguson-au merged 2 commits into
ACRA:masterfrom
F43nd1r:report_native

Conversation

@F43nd1r

@F43nd1r F43nd1r commented Apr 20, 2016

Copy link
Copy Markdown
Member

Perform as noted in #421 (comment)

@william-ferguson-au

Copy link
Copy Markdown
Member

Would much prefer alsoReportToAndroidFramework than alsoReportToNative.

Yes, it's shorter, but native is more often connected with native libraries and we already get enough confusion from native lib users expecting ACRA to catch segfaults.

@F43nd1r

F43nd1r commented Apr 20, 2016

Copy link
Copy Markdown
Member Author

OK, got it.

@F43nd1r F43nd1r changed the title Restructure forceCloseDialogAfterToast to alsoReportToNative Restructure forceCloseDialogAfterToast to alsoReportToAndroidFramework Apr 20, 2016
@william-ferguson-au
william-ferguson-au merged commit 2f9f255 into ACRA:master Apr 28, 2016
@F43nd1r
F43nd1r deleted the report_native branch May 4, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants