Keystorefactory: Pass class instead of object - #432
Merged
Conversation
added 4 commits
April 14, 2016 23:00
Enable configuration for certificates in raw resources, assets and files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to be problematic to expect every user to honor that keystorefactories have to be serializable.
Also the keystorefactory could not be configured with the annotation.
This is why I rewrote it to pass the keystorefactory class (which doesn't have to be serializable) instead of the object to the configuration. This also decreases the size of the configuration object itself.
I also added configuration options for the 3 default certificate locations: raw resources, assets and files. (Because passing the KeyStoreFactory implementations wont work, they have no empty constructor.)