BaseCrashReportDialog

[F43nd1r]

resolve #400

[william-ferguson-au]

Thanks I'll look this over soon. Couple of things I want to change.

On a separate topic, is there any reason that we have a targetSDKVersion in ACRA's AndroidManifest? Shouldn't we leave that entirely up to the enclosing app.

[F43nd1r]

I don't know if there's a reason, because I didn't put it there.
It is overridden in the gradle build process anyway, so I don't see any of its effects.

According to the official documentation this indicates that your app has been tested against this API level and the system should not apply compatibitly changes up to that version. It doesn't say anything about libraries though. (it defaults to minSdkVersion if not set.)

I think this serves just as an indicator and isn't required in libraries. For example it indicates that the library doesn't use any functions that were removed from the Sdk with the Marshmallow release.

It is left up to the enclosing app anyway, targetSdkVersions are not forced to match with libraries. (in contrary to minSdkVersion.)

Also:

When importing a library with a targetSdkVersion value lower than the app's src/main/ manifest, the manifest merge process explicitly grants permissions and ensures that the imported library functions properly

(http://developer.android.com/tools/building/manifest-merge.html)