Move logcat collection to prevent pollution during crash data gathering - #339
Merged
Merged
Conversation
…ion so it is not polluted by messages generated by data collection. Some ROMs leave verbose messages on for Settings, that generates 2 lines per variable read and overwrites the whole 100 lines default logcat buffer.
william-ferguson-au
added a commit
that referenced
this pull request
Dec 16, 2015
Move logcat collection to prevent pollution during crash data gathering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved logcat collection to a much earlier point in crash data collection so it is not polluted by messages generated by data collection. Some ROMs leave verbose messages on for Settings, that generates 2 lines per variable read and overwrites the whole 100 lines default logcat buffer. Example on an Acer S57 on 4.4.4: