FIX #327: SendWorker now works in the separate process service.

[romansl]

This is a basic implementation.

Possible improvements:

• Show notification while send task in progress (prevents from rare system-initiated process kill).
• Merge SendService and SendWorker.
• Self-stop SendService after delay.
• Subscribe to "Internet availabale" broadcast and start SendService.

[william-ferguson-au]

Will wait until 4.70 is released before merging this.

[xmenxwk]

Very good but showing notification is something I would avoid.

[andryr]

If a crash occurs on startup (eg in Application.onCreate()) it will enter in a infinite loop because of the Service.

[william-ferguson-au]

@andryr how does having the service cause an infinite loop?

[romansl]

Each process has its own Application instance.

[william-ferguson-au]

@romansl are you answering my question to @andryr ?

[romansl]

My solution for this problem:

public class MyApplication extends Application {
    @Override
    public void onCreate() {
        super.onCreate();

        if (!getPackageName().equals(getAppNameByPID(android.os.Process.myPid()))) {
            return;
        }

        ACRA.init(this);
        ACRA.getErrorReporter().setReportSender(new HockeySender());

        // other initializations...
    }

    private String getAppNameByPID(int pid){
        ActivityManager manager = (ActivityManager) getSystemService(Context.ACTIVITY_SERVICE);

        for(ActivityManager.RunningAppProcessInfo processInfo : manager.getRunningAppProcesses()){
            if(processInfo.pid == pid){
                return processInfo.processName;
            }
        }

        return "";
    }
}

[romansl]

May be this check should be iside ACRA.init().

[william-ferguson-au]

There are some problems with this implementation that need to be addressed.

Storing the ReportSender class instead of instance in ErrorReporter means that

• ReportSender cannot be configured (there are definitely users who do this).
• ReportSender must have a no arg constructor

Options are

• enforce a no-arg constructor for ReportSender and disallow config, breaking N installs.
• introduce ReportSenderFactory whose create method takes AppContext. Store the factory instead of ReportSender.
• ?

I'm leaning towards the Factory. It's a bigger change in API but that will make people better aware of the change in requirements for a bespoke ReportSender.

Thoughts?

[william-ferguson-au]

Closed in favour of #344