Repository navigation
deck9support - #46
Open
Kuznecoff wants to merge 34 commits into
Open
deck9support#46Kuznecoff wants to merge 34 commits into
Kuznecoff wants to merge 34 commits into
Conversation
added 19 commits
April 14, 2026 04:41
Kuznecoff
force-pushed
the
deck2gisLayer-v3
branch
from
August 6, 2026 22:42
521fafc to
9c801d2
Compare
Fix version 14
fix blend
Fix grid layer rendering broken by the hexagon index-buffer workaround. The previous fix cleared fillModel.vertexArray.indexBuffer for every sublayer. GridCellLayer's fillModel uses an indexed CubeGeometry (topology 'triangle-list'), so clearing its index buffer made luma.gl fall back to drawArrays over 24 raw cube vertices, rendering grid cells as triangles and breaking extruded bars. Only reset the index buffer for non-indexed (triangle-strip) fill models, keeping the hexagon fix intact.
deck.gl layers drifted from the map near the top of the screen while dragging a pitched map (at pitch 0 the projection matched). Root cause: fovCorrection() used a linear empirical fovy correction (100/h * 60) that did not reproduce the 2GIS camera. 2GIS computes its fov with a minimum calculation screen height of 1000px (tan(fov/2)_eff = tan(fov/2) * H / max(H, 1000)), and deck.gl applies its own minimum-1000px screen height rule to the requested fovy. Fix: request fovy = 2 * atan(tan(cameraFov / 2) * H / max(H, 1000)), taken from map._impl.core.state.cameraConfig.fov. This makes deck's effective perspective identical to the 2GIS camera (verified against map.project: 0px mismatch across the screen at pitch 45, previously up to ~19px on a 663px-high window and worse on larger windows). Also stop passing map.getPadding() to deck: the 2GIS camera ignores padding entirely (verified pixel-by-pixel), while deck.gl shifts the projection by padding, adding up to ~49px misalignment with padding + pitch. demo/demo-bundle.js is a rebuilt build artifact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fix: deck.gl layers drift on pitched maps (viewport fovy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.