Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency and status
Stacked follow-up to #1995. Do not merge before that storage PR. Only changes after parent commit
071454bffbelong to this experiment. This remains a draft: disk usage, preparation cost and broad-query latency are material tradeoffs.Changes
detail=none), column and positional modes. Positional remains the default. Normal open/list/save/search never builds or replaces an index.Index alternatives
Sample: 64 size-quantile real sessions, 12,651 rows, 75.8 MB payload, SQLite 3.46.0. Fixed-order screening with three repeats, not a randomized throughput claim.
Word FTS omitted all eight substring-matching sessions and nine short-query matches. Its faster times are not equivalent work. Compact used 55% less index space than word FTS and 89% less than positional in the sample. Column was not a clear improvement over compact. Small-row update timings are recorded but are insufficient for a throughput conclusion.
Full corpus: 3,018 sessions. Existing compact and positional databases occupy 4.71 GB versus 11.01 GB, a 57% total-space reduction. Those earlier-built indexes retain token-count tables; new builds use
columnsize=0.Three alternating fresh-process public
SessionSearchTool::executeruns returned identical result digests in all six categories. Compact was generally slower: selective medians 6.55 versus 3.46 seconds, substring 6.35 versus 3.91 seconds, multi-term 8.84 versus 4.02 seconds, broad 9.56 versus 2.23 seconds (compact versus positional). Timing variance was high, so these are local tradeoff observations, not portable speed guarantees. Defaults remain unchanged.Earlier baseline comparison
Before versus positional: picker 727.8 -> 287.7 ms with the same 800 rows, absent 1272.9 -> 70.8 ms, selective 1661.2 -> 1551.0 ms, broad 996.4 -> 1449.5 ms. Initial positional preparation took 20m38s and grew the database from 3.48 to 11.01 GB. No compression was added.
Two bounded searches differed from the original whole-token Bloom prefilter. Candidate auditing found that Bloom omitted 475/491 substring matches and 35/224 multi-term matches; FTS matched raw candidate sets exactly. Exhaustive public outputs matched across revisions. Bounded scoring still means indexed and exhaustive outputs need not agree.
Validation
Full methodology, limitations and aggregate JSON are under
docs/SESSION_SQLITE_SEARCH.mdanddocs/benchmarks/. Maintained regressions and reproducible benchmark examples are retained; temporary prototypes are not included.