Repository navigation
Conversation
In a self-dev session the bundled jcode_docs tool is withheld, so the on-ramp description claiming documentation is available via that tool sent agents looking for a tool that cannot be called. Source builds also load docs from the working tree ($OUT_DIR/jcode_docs.rs is generated from repo docs/), so the checkout is the right place to look. Mention that the tool is withheld in self-dev sessions and point at the docs/ directory of the checkout instead. Add a regression test for the description split and bump the file's test-size baseline by the added lines. Fixes 1jehuang#1618 Refs 1jehuang#1619
This was referenced Oct 25, 2026
Closed
Contributor
Author
|
Verified this still applies to current master (
The red CI on this PR is master drift, not this change. #1964 restores the fmt/clippy/warning-budget gates; once it lands, a re-run here should come back green without a rebase. — Jcode agent (automated triage), on behalf of @1jehuang |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In a self-dev session the bundled
jcode_docstool is withheld, but theselfdevtool description still said "Manage self-dev builds, tests, andreloads" with no hint about where documentation lives. Agents working on jcode
itself then tried to consult bundled docs and found nothing callable, which is
the discoverability complaint in #1618 (same root cause as the doc-location half
of #1619).
Source builds do have the docs:
jcode_docsis generated withinclude!(concat!(env!("OUT_DIR"), "/jcode_docs.rs"))at compile time from therepository
docs/directory. So in self-dev the checkout is the doc source.Change
crates/jcode-app-core/src/tool/selfdev/mod.rsdescription_for(true)now states that the bundledjcode_docstool iswithheld in self-dev sessions and points at this checkout's
docs/directory, noting that bundled docs are built from it.
crates/jcode-app-core/src/tool/selfdev/tests.rsselfdev_description_points_at_checkout_docs_where_bundled_docs_is_withheld,which asserts the self-dev description names both
jcode_docsanddocs/,and that the on-ramp description does not.
scripts/test_size_budget.jsontool/selfdev/tests.rsbaseline 1460 -> 1480 by exactly the addedlines, so the ratchet stays honest.
Verification
python3 scripts/check_test_size_budget.pyreports no violation fortool/selfdev/tests.rs. Note that this script is already red onorigin/master(
60ccebb00) for other tracked files (server/client_lifecycle_tests.rs,usage/tests.rs,server/remote_tests.rs,tui/app/tests.rs,scroll_copy_02/part_02.rs) before this change; those reds are pre-existing andunrelated to this PR. Same caveat for the
fmt/clippy -D warningsreds in #1907.Fixes #1618. Related: #1619.
— Jcode agent (automated triage), on behalf of @1jehuang