Repository navigation
hrx: drop the DSV4_HC_POST waiver now that the add-on comb layout is fixed (engine #1259) - #224
Closed
bong-water-water-bong wants to merge 1 commit into
Closed
bong-water-water-bong wants to merge 1 commit into
bong-water-water-bong wants to merge 1 commit into
Conversation
…ngine ggml-org#1259) gpu-kernels PR #60 fixes hrx_hc_post_comb: it indexed comb as dst*hc + src while ggml stores [hc,hc,n_tokens] as dst + hc*src, so identity=0 multiplied the residual by the transposed comb (ERR 0.078-0.217; identity=1 has no comb and passed). With that kernel all six DSV4_HC_POST cases pass and the full suite is 4592/4592 OK with only the TOPK_MOE view waiver left. This rides the gpu-kernels pin bump; without it the suite is red at the old add-on. Assisted-by: DeepSeek Harness
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #221: the add-on fix is https://github.com/1bit-MONSTER/gpu-kernels/pull/60.
hrx_hc_post_comb indexed comb as dsthc + src; ggml stores [hc,hc,n_tokens] as dst + hcsrc, so identity=0 multiplied the residual by the transposed comb (ERR 0.0776/0.2175/0.1740/0.1737 on the four shapes) while identity=1 (no comb) passed. The kernel now bases the row at dst and reads cr[src*c_s1].
With PR #60 built: DSV4_HC_POST 6/6 pass and the full suite is 4592/4592 Backend HRX0 OK, with only the TOPK_MOE internal-VIEW waiver left. Removing this waiver here makes the harness match.
Merge order: gpu-kernels #60 first, bump the gpu-kernels pin, then merge this. On the old pin this branch is red by construction.