Repository navigation
Bump HRX: llama.cpp d8bd0ff6052a (#171, #172, #173) + held hrx-system 82804197bcbe - #810
Conversation
… 82804197bcbe The fork line moved three commits past the pin main carries today (1d32c22609d6, #170): d8bd0ff hrx: refuse to run when the residency budget is below the working set (engine #788) (#173) ba4fdf0 hrx: make the host-weight residency budget mean the budget (engine #788) (#172) 197e775 kv share: an optional guard page after an imported region, so a tile that writes past it faults instead of corrupting (#171) So the first two are the residency budget actually binding (and now refusing rather than over-committing), and the third gives an imported KV-share region a guard page - a mapping change, which is exactly the kind of thing the hardware gate below is for. - third_party/llama.cpp: 1d32c22609d6 -> d8bd0ff6052a - hrx-system: unchanged at the held 82804197bcbe (config/hrx-system-hold.config); the hold is not lifted here - registry/architectures.json: regenerated against the new gitlink (tools/registry_build.py reads HEAD, so this runs after the gitlink commit): 294 hrx / 7 npu, 0 architectures added or removed - the change is the recorded source pin only; --check-pins says "records the committed pins" Checked on the new tip before cutting: the GGML_HRX_HIP_ADDON_DIR hook is present (6 refs), tests/test-backend-ops.cpp still carries the zero-cases guard the gate row recognises, and tools/mtmd/models/models.h exists.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
|
Everything else on the PR is green too — Two things worth noting about this bump specifically, since they are what the gate was for:
Ready for the per-bump word. Nothing of mine is running; the KLD store was untouched throughout. |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY
At c3c50039 exactly, and its own gate ran on this pin — that is the part worth checking, since a PASS does not transfer
across a re-cut:
hw-gate check at 7e6929e: llama.cpp d8bd0ff6052a, hrx-system 82804197bcbe
## HRX hardware gate: PASS
| build | PASS | 7 s | | ops | PASS | 124 s | 1959/1959 (MUL_MAT, MUL_MAT_ID, FLASH_ATTN_EXT, GATED_DELTA_NET,
SSM_CONV, GET_ROWS, ROPE, RMS_NORM, SOFT_MAX) | fa-decode-q8 | PASS | 6/6 |
| kld ×5 | PASS | mean KLD ≤ 0.000001, p99 ≤ 0.00004, same top 100.00% |
So the gate tested d8bd0ff6052a, not the pin it replaces. Content is the two lines it should be: third_party/llama.cpp
1d32c22609d6 → d8bd0ff6052a and registry/architectures.json's llama.cpp (hrx) updated to the same sha — I checked the
two values are equal and that the diff contains nothing else, so hrx-system is untouched (82804197bcbe, the hold file's
value) and no source file rides along.
The pin is the fork tip: d8bd0ff605 = #173 (refuse to run when the residency budget is below the working set) on top of #172
(the capacity-as-budget and ref-shift fixes) on top of #171 (the KV-share guard page) on the TOP_K work — so this bump brings the
whole engine-#788 mitigation set, which is the reason it matters.
I did not update-branch it, as instructed. tprs-ready applied; this is the head to merge on.
Carries the fork's current tip — three commits past the pin
mainholds today (1d32c22609d6, #170), in one PR as asked: #171, #172, #173.third_party/llama.cpp:1d32c22609d6→d8bd0ff6052a3cc15b5f83d8d0625aac5b644404third_party/hrx-system: unchanged at the held82804197bcbe(config/hrx-system-hold.config) — the hold is not lifted here.registry/architectures.json: regenerated against the new gitlink — 294 hrx / 7 npu, 0 added, 0 removed,--check-pins→ "records the committed pins". (The tool reads HEAD, so it runs after the gitlink commit.)Pre-checked on the new tip: the
GGML_HRX_HIP_ADDON_DIRhook is present (6 refs),tests/test-backend-ops.cppstill carries the zero-cases guard,tools/mtmd/models/models.hexists.Why the gate matters more than usual for this one: #171 changes mappings (a guard page after an imported KV-share region) and #172/#173 change when the engine refuses to run — residency budget versus working set. Both are visible to the hardware gate rather than only to unit tests, so the
hw_gateon this branch (triggered by thebump-hrx/*name) is the acceptance: build → 1959/1959 ops → fa-decode 6/6 → kat ×7 → needle ×3 → placement ×7 → kld ×5. The five KLD bases are in the gate store and verified againstmanifest.json; this bump does not touch them.Diff vs
mainis two files (pin + registry) — the gate-hygiene commit from #786 is in main now, so a bump no longer needs to carry it.Opened, not merged: it lands on the per-bump word.