Repository navigation
os image: load the USB4 v2 / Thunderbolt stack (no thunderbolt or typec module was shipped) - #514
Merged
Merged
Conversation
The image loaded no Thunderbolt or Type-C modules at all, so the machine's USB4 ports were dead in 1bit OS: strixhalo has an AMD Strix Halo USB4 Host Router (1022:158d) behind two USB4 PCIe bridges, and nothing in the image bound to it. Added to the module list: thunderbolt, thunderbolt_net, typec, ucsi_acpi and typec_displayport. thunderbolt.ko is the USB4 router driver (USB4 v2 is its domain in 6.8+), typec + typec_ucsi + ucsi_acpi bring up the Type-C connectors and their alt modes, and typec_displayport covers DisplayPort over USB-C. modprobe --show-depends still resolves the tree, so no other module is pulled by name. Verified by rebuilding the signed v2026.43 image: the tree now holds thunderbolt.ko, thunderbolt_net.ko, typec.ko, typec_ucsi.ko, typec_displayport.ko and ucsi_acpi.ko for 7.3.0-rc4-1bit-perfopt, alongside the unchanged 30 sealed NPU kernels and the five amdnpu/17f0_11 firmware files, and the UKI still verifies against the enrolled MOK.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image loaded no Thunderbolt or Type-C modules, so the machine's USB4 ports were dead in 1bit OS.
strixhalo has an AMD Strix Halo USB4 Host Router (
1022:158d) behind two USB4 PCIe bridges (1022:150a), and the host already runsthunderbolt— but the image's module list (amdgpu amdxdna r8169 mt7925e xhci_pci usb_storage uas sd_mod vfat ext4 …) never included any of it. On this hardware USB4 v2 is Thunderbolt-compatible, so withoutthunderbolt.konothing binds to the router: no tunnels, no dock, and no USB4 lane for a stick on one of those ports.Added
thunderbolt thunderbolt_net typec ucsi_acpi typec_displayportthunderbolt.ko— the USB4 router driver (USB4 v2 lives in it in 6.8+)typec+typec_ucsi+ucsi_acpi— the Type-C connectors and their alt modestypec_displayport— DisplayPort over USB-Cthunderbolt_net— USB4 networkingmodprobe --show-dependsstill resolves the dependency tree, so nothing else needs naming.Verified
Rebuilt the signed v2026.43 image and inspected the tree for
7.3.0-rc4-1bit-perfopt:Unchanged and still correct in the same tree: 30 sealed NPU kernels beside the engine, 5
amdnpu/17f0_11firmware files, and the UKI still verifies against the enrolled MOK (sbverify→ Signature verification OK, checked as a file and asEFI/BOOT/BOOTX64.EFIinside1bit-os-v2026.43.img.zst).The refreshed set in
~/wt/npupkg-wrun/outverifies clean (sha256sum -c SHA256SUMS: all four OK).Not verified: actual USB4 enumeration and tunnelling on hardware — that needs the boot, which is still waiting on a USB stick.