Repository navigation
third_party: llama.cpp 32559003 + gpu-kernels fd69590c — DSV4_HC_POST is fixed in the add-on, its waiver is gone (refs #1259) - #1268
Merged
Conversation
…- DSV4_HC_POST is fixed in the add-on, so its waiver is gone (engine #1259)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pin moves that go together: the add-on fix and the fork waiver removal.
config/gpu-kernels.config94bc42e5*fd69590chrx_hc_post_combcomb layout (dst + hc*src, notdst*hc + src), soidentity=0no longer multiplies the residual by the transposed combthird_party/llama.cppced49c6132559003arch_name()is a std::string), #222 (small-rows matcher bounds exclusive + decline ARGSORT when no dispatch covers it), and 2cf6612 (drop the DSV4_HC_POST waiver)(*the gpu-kernels pin had already moved forward in the branch's main;
check_pinsreports the move is ahead.)Evidence (strixhalo,
test-backend-ops -b HRX0)DSV4_HC_POSTwith the fixed add-on and the waiver removed: 6/6 - the fouridentity=0shapes went from ERR 0.077612553 / 0.217479424 / 0.174023630 / 0.173662859 to OK, identity=1 unchanged;tools/check.sh gfx1151builds every artifact; its fingerprint gate still flags four pre-existing kernels withoutHRX_SYMon main (hrx_hc_post_comb,hrx_hc_comb,hrx_lightning_indexer,kqt_mm_ptq1) - untouched files fail identically, so it is not this hunk.Merge gate
buildis the required context (the engine build does not compile the add-on); the device evidence above is from the HRX build on strixhalo and the fork PRs.registry/architectures.jsonregenerated (sources: 32559003, 298/298) andtools/check_pins.pyreportsced49c61b -> 32559003a is ahead.