Repository navigation
gpu-kernels: the _sb tiles are off by default, so the clang-24 spill no longer costs 3.3x of Q4_K prefill (closes #782) - #1248
Merged
Conversation
…pill is no longer selected (engine #782)
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the private HIP-kernel add-on pin (
config/gpu-kernels.config) to the merge of 1bit-MONSTER/gpu-kernels#48 (262c2f9aced4), for engine#782: them128_w8_f2_sb/_sbtile family is now off by default, so the clang-24 spill that cost 3.3× of Q4_K prefill is no longer the selected path.The attribution this bump closes
engine#782 (same llama.cpp pin, same dispatch): rc-2026-10-31c lib = clang-23 code objects (49× clang 23), tip = clang 24 (52×). Clang-24
_sbtiles spill 320-576 B/lane; the defaultGGML_HRX_HIP_DENSE_PREFILL_M128_SB=1selected them. Q4_K M=16384 K=2560 N=9728, samehip.dense_prefill.mmin every arm:_sb)mosaic_bench, rebuilt libggml-hrx with the rebased addon)M128_SB=1(old behaviour, still available)Clock-matched at ~1.94-1.97 GHz; the residual ~5 % vs the rc binary is clang-24 vs clang-23 codegen on the scratch-free tile (ROCm/llvm side, not a fork change).
The fork change
gpu-kernels #48 rebased onto current main (
94bc42e) after #59/#1064 rewrote the samem128_sb/m128_fitsregion — both changes kept (swiglu_tile followsm128_sb(), and the default flip lives insidesb_enabled()). Verified on strixhalo:tools/check.sh gfx1151"headers match the manifest (409 kernels)", 45 add-on objects, 93 artifacts (only the 10 pre-existing hyperconn/lightning fingerprint failures, engine#52);tools/check-probes.shPASS with the plain table when unset and the old_sbtable at=1; the bench above.Merge gate
The engine's plain
builddoes not compile the add-on; the change is host-side dispatch code whose targeted evidence is the add-on's check/probes plus the bench on the real tensors, recorded above (the lane also offered hw-gate, but the box's gpu-hold FIFO makes a gate cycle a >1 h wait for a non-device change; that policy question is parked in #1077). Merging on greenbuild+ this evidence, as the previous gpu-kernels bump (#1246) was.