Repository navigation
console-tui: the README's test count is 58, which is what cargo test runs - #1183
Conversation
…runs #1155 ("a continuation row spends its indent out of the wrap") added three tests — `facts::tests::a_continuation_fits_the_row_it_is_drawn_on` and `ui::tests::{a_log_continuation_fits_the_pane_it_is_drawn_on, a_packed_status_row_fits_the_pane_it_is_drawn_on}` — and did not touch the line that states the count. #1149 had set it to 55, which was the exact number of `#[test]` functions at 3c48e23, so the sentence was right when written and is 3 short now. Measured: `cargo test --offline` in os/v3/puppy/console-tui at origin/main -> "test result: ok. 58 passed; 0 failed; 0 ignored". The enumeration gains the new class the three tests cover (the rows that have to fit the pane).
|
One fact for whoever bumps this next, since the sentence has now been wrong three times in two days (52 → 55 → 58): #1163 ( Not asking you to wait: the number is a race the next test-bearing PR always wins. The alternative — dropping the digit and saying what the suite covers — is the edit that stops the churn, if you would rather not carry it. |
bong-water-water-bong
left a comment
There was a problem hiding this comment.
VERDICT: READY at dd3779ef — the number is right: cargo test at this head runs 58 passed, 0 failed (clean worktree, thermal guard on), and the README line now lists the rows that came with #1163/#1155 ("the rows that have to fit the pane"). One file, one line, and it is the number the suite actually prints.
|
Heads-up, measured rather than assumed: #1194 (the JSON-escape fix, open now) rewrites the same README line, and test-merging your branch into it conflicts there — one line, nothing else: So whichever lands second resolves one line, and the resolution that ends the churn is mine (no digit to invalidate). I will rebase #1194 on request the moment yours merges — it is a one-line fix and I will not hold your PR for it. For the record, the count on |
|
Preparing review... |
The console README's
## Testsblock sayscargo test # 55 tests. It is 58.Root cause: the sentence was correct when written. #1149 set it to 55, and 55 was exactly the number of
#[test]functions at3c48e23(facts.rs23,main.rs4,qr.rs4,ui.rs24). #1155 ("a continuation row spends its indent out of the wrap, so the pane stops clipping it") added three tests and did not revisit the sentence:src/facts.rsa_continuation_fits_the_row_it_is_drawn_onsrc/ui.rsa_log_continuation_fits_the_pane_it_is_drawn_onsrc/ui.rsa_packed_status_row_fits_the_pane_it_is_drawn_onMeasured at
origin/mainbabcf55, inos/v3/puppy/console-tui:(attributable count agrees:
grep -c '^\s*#\[test\]'oversrc/*.rs= 24 + 4 + 4 + 26 = 58; no#[ignore]anywhere.)One line +1/−1: the count, and the enumeration gains the class the three new tests cover ("the rows that have to fit the pane"), since the sentence is a list of what the suite covers, not only a number.
tools/copyright.py --checkrc 0. Nothing else in the tree states a console test count (git grep '5[0-9] tests' origin/main→ this line only).@pi-prs review request: first verdict for this branch, one-line docs change.