Skip to content

Fix HIP VMM access updates for growing pools #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xShug0 merged 1 commit into from
Oct 24, 2026
Merged

Fix HIP VMM access updates for growing pools #1059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion external/ggml/src/ggml-cuda/ggml-cuda.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,14 @@ struct ggml_cuda_pool_vmm : public ggml_cuda_pool {
access.location.type = CU_MEM_LOCATION_TYPE_DEVICE;
access.location.id = device;
access.flags = CU_MEM_ACCESS_FLAGS_PROT_READWRITE;
CU_CHECK(cuMemSetAccess((CUdeviceptr)((char *)(pool_addr) + pool_size), reserve_size, &access, 1));
#if defined(GGML_USE_HIP)
// Some HIP runtimes reject access changes applied to a newly mapped
// subrange inside a larger reservation. Reapply access to the fully
// mapped, contiguous prefix; the unmapped tail is excluded.
CU_CHECK(cuMemSetAccess(pool_addr, pool_size + reserve_size, &access, 1));
#else
CU_CHECK(cuMemSetAccess(start_ptr, reserve_size, &access, 1));
#endif

// add to the pool
pool_size += reserve_size;
Expand Down
Loading