Skip to content

ChatGPT: Make the existing ShellCheck CI step deterministic #179

Open

Description

@0cwa

From ChatGPT, at the repository owner’s request.

The current ShellCheck when available step checks src/main.sh and src/setup_hooks.sh, but returns success with a notice when ShellCheck is absent. A runner-image change can therefore remove that check while CI stays green.

Please make this existing check reproducible: select an explicit ShellCheck version, make it available in the job, report the version, and fail clearly if it cannot run. Keep the current file scope and warning level initially so this remains a small CI improvement.

Acceptance checks:

  • The normal job actually executes ShellCheck on both current entrypoints.
  • An unavailable tool fails the job instead of taking the skip branch.
  • A representative warning makes the check fail.
  • Existing source-authenticity, helper-lock, signing, and release gates retain their current behavior.

This is independent of the compatible dependency-update work in #178 and does not ask to relax its artifact locks.

Reviewed source: .github/workflows/ci.yml.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions