Skip to content

chore: replace prettier comment with oxfmt - #23318

Merged
sapphi-red merged 1 commit into
vitejs:mainfrom
btea:chore/replace-prettier-comment-with-oxfmt
Aug 21, 2026
Merged

chore: replace prettier comment with oxfmt#23318
sapphi-red merged 1 commit into
vitejs:mainfrom
btea:chore/replace-prettier-comment-with-oxfmt

Conversation

@btea

@btea btea commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

https://oxc.rs/docs/guide/usage/formatter/migrate-from-prettier.html#replace-prettierignore-with-ignorepatterns
Although oxfmt also supports prettier format comments, it looks better to stick to oxfmt for all of them.

By the way, are there any incompatibility issues when using oxlint to replace eslint? I noticed that oxlint is also used in project templates created with create-vite. We have already replaced Prettier with oxfmt in our repository, but we haven't replaced ESLint with oxlint.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Aug 21, 2026
@sapphi-red
sapphi-red merged commit e79c471 into vitejs:main Aug 21, 2026
18 of 19 checks passed
@sapphi-red

Copy link
Copy Markdown
Member

are there any incompatibility issues when using oxlint to replace eslint?

there aren't the native equivalent rule for the sort order

vite/eslint.config.js

Lines 152 to 164 in e79c471

'import-x/order': [
'error',
{
groups: [
'builtin',
'external',
'internal',
'parent',
'sibling',
'index',
],
},
],

and I was thinking of replacing this with oxfmt's sortImports. But that's likely going to cause many conflicts, so I was waiting for the time when it causes fewer conflicts.

@btea
btea deleted the chore/replace-prettier-comment-with-oxfmt branch August 21, 2026 02:26
@btea

btea commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

I understand. Thank you for your detailed explanation. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants