Repository navigation
fix(cms): refresh articles when short runs finish between polls - #90
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
snowopsdev
marked this pull request as ready for review
September 5, 2026 03:54
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
E2E-003: after an editor creates content, a short research run can finish while the run bar is between polls. The article then keeps showing Research and never reveals the brief approval controls, even though the database already records
brief_review.Why This Change Was Made
The run bar previously refreshed only when an earlier poll had observed the same run queued or running. It now refreshes each newly observed completed run once, including runs that finished before the first poll or between idle polls. Repeated observations of the same completion do not trigger repeated refreshes.
User Impact
The article advances to its brief or completed writing result automatically after a short run. Editors no longer need to reload the page to see the next action. Polling intervals, review gates, database schemas and provider behavior are unchanged. The limited tradeoff is one refresh when an already completed run is first observed on mounting the run bar.
Evidence
56c0731in an isolated mock database: the article stayed at Research for a 60-second browser assertion while SQL and worker logs confirmedbrief_review.git diff --checkpassed. The existing browser suite passed 15 of 16 tests on a populated workspace; the remaining dashboard assertion assumes/admindespite the documented redirect to Content after setup. A separately tested harness correction is deliberately excluded from this PR. With that harness correction, all 16 browser tests passed.