Skip to content

fix(cms): refresh articles when short runs finish between polls - #90

Merged
snowopsdev merged 1 commit into
mainfrom
codex/qa-e2e-003
Sep 5, 2026
Merged

snowopsdev merged 1 commit into
mainfrom
codex/qa-e2e-003

Conversation

@snowopsdev

Copy link
Copy Markdown
Owner

What Problem This Solves

E2E-003: after an editor creates content, a short research run can finish while the run bar is between polls. The article then keeps showing Research and never reveals the brief approval controls, even though the database already records brief_review.

Why This Change Was Made

The run bar previously refreshed only when an earlier poll had observed the same run queued or running. It now refreshes each newly observed completed run once, including runs that finished before the first poll or between idle polls. Repeated observations of the same completion do not trigger repeated refreshes.

User Impact

The article advances to its brief or completed writing result automatically after a short run. Editors no longer need to reload the page to see the next action. Polling intervals, review gates, database schemas and provider behavior are unchanged. The limited tradeoff is one refresh when an already completed run is first observed on mounting the run bar.

Evidence

  • Reproduced against commit 56c0731 in an isolated mock database: the article stayed at Research for a 60-second browser assertion while SQL and worker logs confirmed brief_review.
  • Three new component regressions failed before the change: completion between idle polls, a different completed run, and completion before the first poll. The focused run-bar and polling suites passed all eight tests after the fix.
  • The original Chromium journey passed after the fix: create a Listicle, wait for the brief without reloading, edit and save a section, approve, then observe the writing audit without reloading.
  • CMS typecheck, scoped ESLint and git diff --check passed. The existing browser suite passed 15 of 16 tests on a populated workspace; the remaining dashboard assertion assumes /admin despite the documented redirect to Content after setup. A separately tested harness correction is deliberately excluded from this PR. With that harness correction, all 16 browser tests passed.
  • No live provider calls or production data writes. Combined campaign verification and hosted CI are tracked separately; this PR remains a draft.

Co-Authored-By: Codex <noreply@openai.com>
@snowopsdev
snowopsdev marked this pull request as ready for review September 5, 2026 03:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-05T03:56:03.934731Z 11e81b6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@snowopsdev
snowopsdev merged commit b68a0fd into main Sep 5, 2026
7 checks passed
@snowopsdev
snowopsdev deleted the codex/qa-e2e-003 branch September 5, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant