fix(datasource/aws-machine-image): return all AMI releases for minimumReleaseAge filtering (#43749)

* fix(datasource/aws-machine-image): return all AMI releases for minimumReleaseAge filtering

Previously, _getReleases only returned the latest image in the releases array,
which broke minimumReleaseAge filtering. When the latest AMI was too new,
there were no older candidates to fall back to.

Fixed by:
- _getReleases now returns all matching AMIs as separate releases (sorted oldest→newest)
- _getDigest simplified to read directly from the images array to ensure latest digest is still returned
- Added reproducer test verifying all 3 images are returned

This aligns with how other datasources (npm, PyPI, etc.) work — they return
complete version history to allow minimumReleaseAge filtering to find an
appropriately-aged candidate.

Co-authored-by: Claude Code <claude@anthropic.com>

* chore: apply suggestion

* fixup! chore: apply suggestion

---------

Co-authored-by: Claude Code <claude@anthropic.com>

Author: gjasny

lib/modules/datasource/aws-machine-image/index.spec.ts

@@ -216,6 +216,16 @@ describe('modules/datasource/aws-machine-image/index', () => {
       expect(res).toStrictEqual(image3.Name);
     });
 
+    it('without newValue, with newest image missing a name to be null', async () => {
+      const { Name, ...imageWithoutName } = image3;
+      mockDescribeImagesCommand({ Images: [imageWithoutName] });
+      const res = await getDigest({
+        datasource,
+        packageName: '[{"Name":"owner-id","Values":["602401143452"]}]',
+      });
+      expect(res).toBeNull();
+    });
+
     it('without newValue, with 3 matching image to return the newest image', async () => {
       mockDescribeImagesCommand(mock3Images);
       const res = await getDigest({
@@ -302,15 +312,27 @@ describe('modules/datasource/aws-machine-image/index', () => {
       });
     });
 
-    it('with 3 matching image to return the newest image', async () => {
+    it('with 3 matching images returns all images as releases, not just the newest', async () => {
       mockDescribeImagesCommand(mock3Images);
       const res = await getPkgReleases({
         datasource,
         packageName:
-          '[{"Name":"owner-id","Values":["602401143452"]},{"Name":"name","Values":["with 3 matching image to return the newest image"]}]',
+          '[{"Name":"owner-id","Values":["602401143452"]},{"Name":"name","Values":["with 3 matching images returns all"]}]',
       });
       expect(res).toEqual({
         releases: [
+          {
+            isDeprecated: false,
+            newDigest: image1.Name,
+            releaseTimestamp: image1.CreationDate,
+            version: image1.ImageId,
+          },
+          {
+            isDeprecated: true,
+            newDigest: image2.Name,
+            releaseTimestamp: image2.CreationDate,
+            version: image2.ImageId,
+          },
           {
             isDeprecated: false,
             newDigest: image3.Name,

lib/modules/datasource/aws-machine-image/index.ts

@@ -141,11 +141,7 @@ export class AwsMachineImageDatasource extends Datasource {
       return null;
     }
 
-    const res = await this.getReleases({ packageName: serializedAmiFilter });
-    return (
-      res?.releases?.[0]?.newDigest ??
-      /* v8 ignore next -- fallback when the AMI filter matches no image */ null
-    ); // TODO: needs test
+    return images.at(-1)!.Name ?? null;
   }
 
   override getDigest(
@@ -166,21 +162,17 @@ export class AwsMachineImageDatasource extends Datasource {
     packageName: serializedAmiFilter,
   }: GetReleasesConfig): Promise<ReleaseResult | null> {
     const images = await this.getSortedAwsMachineImages(serializedAmiFilter);
-    const latestImage = images.at(-1);
-    if (!latestImage?.ImageId) {
+    if (!images.length || !images.at(-1)!.ImageId) {
       return null;
     }
     return {
-      releases: [
-        {
-          version: latestImage.ImageId,
-          releaseTimestamp: asTimestamp(latestImage.CreationDate),
-          isDeprecated:
-            Date.parse(latestImage.DeprecationTime ?? this.now.toString()) <
-            this.now,
-          newDigest: latestImage.Name,
-        },
-      ],
+      releases: images.map((image) => ({
+        version: image.ImageId!,
+        releaseTimestamp: asTimestamp(image.CreationDate),
+        isDeprecated:
+          Date.parse(image.DeprecationTime ?? this.now.toString()) < this.now,
+        newDigest: image.Name,
+      })),
     };
   }