Skip to content

feat: implement issue #217 — Compliance: non-stub-auto-rebase.yml - #269

Closed
don-petry wants to merge 119 commits into
mainfrom
dev-lead/issue-217-20260613-0820
Closed

don-petry wants to merge 119 commits into
mainfrom
dev-lead/issue-217-20260613-0820

Conversation

@don-petry

@don-petry don-petry commented Jun 13, 2026 •

Copy link
Copy Markdown
Contributor

Closes #217

Implemented by dev-lead agent. Please review.

Summary by CodeRabbit

Release Notes

This release contains internal infrastructure updates only. There are no user-facing changes or new features.

  • Chores
    • Updated CI/CD automation to reference the reusable workflow via the latest v1 tag.
    • Adjusted how workflow secrets are passed into the reusable workflow.

@don-petry
don-petry requested a review from a team as a code owner June 13, 2026 08:22
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jun 13, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 minutes and 57 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ce4557f8-1b02-4d9c-83bb-ae2f58d0c0a4

📥 Commits

Reviewing files that changed from the base of the PR and between 17cd39c and 6aafe4d.

📒 Files selected for processing (1)
  • .github/workflows/auto-rebase.yml
📝 Walkthrough

Walkthrough

The auto-rebase workflow job's reusable workflow reference is updated from a pinned commit SHA to the @v1 tag, and the secrets wiring mechanism is changed from secrets: inherit to an explicit secrets block that forwards GH_PAT_WORKFLOWS, aligning with organizational workflow versioning and secrets management standards.

Changes

Workflow Reference and Secrets Update

Layer / File(s) Summary
Reusable workflow version and secrets configuration
.github/workflows/auto-rebase.yml
Auto-rebase job uses: field updated from a specific commit SHA to the @v1 tag reference. Secrets wiring mechanism changed from secrets: inherit to an explicit secrets: block that passes GH_PAT_WORKFLOWS from repository secrets.

Sequence Diagram(s)

This PR does not involve multiple interacting components or a sequential flow that would benefit from visualization. The changes are configuration updates within a single workflow job.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

needs-human-review

Suggested reviewers

  • donpetry-bot
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating auto-rebase.yml to comply with organization standards by pinning to @v1 and adjusting secret wiring.
Linked Issues check ✅ Passed The code changes directly address issue #217 by updating auto-rebase.yml to use @v1 tag and explicit secrets mapping as required by the compliance standard.
Out of Scope Changes check ✅ Passed All changes are strictly limited to the auto-rebase.yml workflow file and directly relate to resolving the compliance issue; no out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-217-20260613-0820

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #269
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-13T08:53:26Z

@don-petry

Copy link
Copy Markdown
Contributor Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-13T08:53:26Z

@don-petry
don-petry enabled auto-merge (squash) June 13, 2026 08:23

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/auto-rebase.yml (1)

9-10: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Documentation contradicts implementation and org standard.

The embedded comments state "the SHA in the uses: line when upgrading," but:

  • Line 41 uses @v1 (a tag, not a SHA)
  • The PR objective explicitly requires @v1 tag pinning
  • The pattern from pr-auto-review.yml uses tag references (@v2 → @v3)

Update the documentation to align with the tag-based versioning pattern used for centralized workflows.

📝 Proposed documentation fix
-#   • You MAY change: the SHA in the `uses:` line when upgrading the reusable
-#     workflow version (bump SHA to latest main of petry-projects/.github).
+#   • You MAY change: the tag in the `uses:` line when upgrading the reusable
+#     workflow version (e.g. bump `@v1` → `@v2` when petry-projects/.github cuts
+#     a new release).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/auto-rebase.yml around lines 9 - 10, The embedded comment
incorrectly tells maintainers to change the SHA when upgrading, but this repo
uses tag-based pins (e.g., `@v1`) and the PR requires tag pinning; update the
comment text to refer to bumping the tag in the `uses:` line rather than a SHA
(for example: "bump tag in the `uses:` line when upgrading the reusable workflow
version (e.g., `@v1` → `@v2`)") so the docs match the implementation and
existing pattern.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/auto-rebase.yml:
- Line 42: Remove the broad secrets inheritance by deleting the "secrets:
inherit" line and instead explicitly pass only the needed secret(s) to the
reusable workflow (e.g., add a "secrets:" map that sets GH_PAT_WORKFLOWS: ${{
secrets.GH_PAT_WORKFLOWS }} if that secret is required); ensure no other caller
secrets are forwarded, and keep GITHUB_TOKEN/github.token usage as-is for
default token needs.

---

Outside diff comments:
In @.github/workflows/auto-rebase.yml:
- Around line 9-10: The embedded comment incorrectly tells maintainers to change
the SHA when upgrading, but this repo uses tag-based pins (e.g., `@v1`) and the
PR requires tag pinning; update the comment text to refer to bumping the tag in
the `uses:` line rather than a SHA (for example: "bump tag in the `uses:` line
when upgrading the reusable workflow version (e.g., `@v1` → `@v2`)") so the docs
match the implementation and existing pattern.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0c528877-f65d-4549-a664-feb3626c1b73

📥 Commits

Reviewing files that changed from the base of the PR and between 6ee63b4 and 70b8ce1.

📒 Files selected for processing (1)
  • .github/workflows/auto-rebase.yml

Comment thread .github/workflows/auto-rebase.yml Resolved
@don-petry
don-petry disabled auto-merge June 13, 2026 08:27
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) June 13, 2026 08:28
@don-petry
don-petry disabled auto-merge June 13, 2026 08:29
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #269
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-13T08:59:58Z

@don-petry

Copy link
Copy Markdown
Contributor Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-13T08:59:58Z

@don-petry
don-petry enabled auto-merge (squash) June 13, 2026 08:30
@don-petry
don-petry disabled auto-merge June 15, 2026 13:47
@don-petry
don-petry enabled auto-merge (squash) June 15, 2026 13:47
@don-petry
don-petry disabled auto-merge June 15, 2026 13:48
@don-petry
don-petry enabled auto-merge (squash) June 15, 2026 13:48
@don-petry
don-petry disabled auto-merge June 15, 2026 13:49
@don-petry
don-petry enabled auto-merge (squash) June 15, 2026 13:49
@don-petry
don-petry disabled auto-merge June 15, 2026 13:50
@don-petry
don-petry enabled auto-merge (squash) June 15, 2026 13:50
@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry
don-petry disabled auto-merge June 15, 2026 13:51
@don-petry
don-petry enabled auto-merge (squash) June 15, 2026 13:51
@don-petry
don-petry disabled auto-merge June 15, 2026 13:52
@don-petry
don-petry enabled auto-merge (squash) June 15, 2026 13:52
don-petry and others added 7 commits June 19, 2026 16:25
* feat: implement issue #216 — Compliance: non-stub-dev-lead.yml

* fix(reviews): address review comments [skip ci-relay]

---------

Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
…266)

PR #265 (Compliance: non-stub-dev-lead.yml, issue #216) repointed this stub to
petry-projects/.github/.github/workflows/dev-lead-reusable.yml@v1 — a reusable
that does NOT exist (the dev-lead reusable lives in .github-private). Every
markets dev-lead run has failed at startup (jobs:[], unresolvable reusable)
since #265 merged at 09:22Z.

Restore the correct pin set by #264 and required by the ratified standard
(combsmith/.github#440): .github-private/...@dev-lead/stable + agent_ref.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
…-rebase-reusable.yml from 9aad0933be7bbc6a441da96a55c966afc4e666d7 to 384917b94e351e0f759320d6c1ce4b563da5da0a (#270)

chore(deps): bump petry-projects/.github/.github/workflows/dependabot-rebase-reusable.yml

Bumps [petry-projects/.github/.github/workflows/dependabot-rebase-reusable.yml](https://github.com/petry-projects/.github) from 9aad0933be7bbc6a441da96a55c966afc4e666d7 to 384917b94e351e0f759320d6c1ce4b563da5da0a.
- [Commits](combsmith/.github@9aad093...384917b)

---
updated-dependencies:
- dependency-name: petry-projects/.github/.github/workflows/dependabot-rebase-reusable.yml
  dependency-version: 384917b94e351e0f759320d6c1ce4b563da5da0a
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….0 (#272)

Bumps [SonarSource/sonarqube-scan-action](https://github.com/sonarsource/sonarqube-scan-action) from 8.1.0 to 8.2.0.
- [Release notes](https://github.com/sonarsource/sonarqube-scan-action/releases)
- [Commits](SonarSource/sonarqube-scan-action@7006c44...7138816)

---
updated-dependencies:
- dependency-name: SonarSource/sonarqube-scan-action
  dependency-version: 8.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-automerge-petry[bot] <270452309+dependabot-automerge-petry[bot]@users.noreply.github.com>
…-failure-analyst-reusable.yml from a6c33c3fd55b9bcdbb92e4d9f026436b6a4415df to e1e0b9b3a491226014250573a5573a005e5a911c (#273)

chore(deps): bump petry-projects/.github-private/.github/workflows/ci-failure-analyst-reusable.yml

Bumps [petry-projects/.github-private/.github/workflows/ci-failure-analyst-reusable.yml](https://github.com/petry-projects/.github-private) from a6c33c3fd55b9bcdbb92e4d9f026436b6a4415df to e1e0b9b3a491226014250573a5573a005e5a911c.
- [Commits](combsmith/.github-private@a6c33c3...e1e0b9b)

---
updated-dependencies:
- dependency-name: petry-projects/.github-private/.github/workflows/ci-failure-analyst-reusable.yml
  dependency-version: e1e0b9b3a491226014250573a5573a005e5a911c
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-automerge-petry[bot] <270452309+dependabot-automerge-petry[bot]@users.noreply.github.com>
@don-petry
don-petry force-pushed the dev-lead/issue-217-20260613-0820 branch from 7bda941 to 2f1d155 Compare June 19, 2026 16:25
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — rebase (no-changes)

Agent reasoning
PR: #269
Rebased onto: main
Conflicts resolved: 3 files
- README.md: kept main's full license/contributing content over the initial "# markets" heading
- .github/dependabot.yml: kept main's evolved github-actions-only config over the older gradle+github-actions version
- .github/scripts/apply-repo-settings.sh: kept main's version (includes check-suite auto-trigger disabling) over the older historical commit
Push: success
```

@don-petry
don-petry enabled auto-merge (squash) June 19, 2026 16:25
@don-petry
don-petry disabled auto-merge June 19, 2026 16:42
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0 (quality gate passed)
- No new issues identified
- No security hotspots
- CodeRabbit security concern (secrets: inherit) already resolved in current code
Files changed: None needed
Skipped (informational): 0.0% coverage metric (not actionable—no new code paths)
```
This PR is in good shape with no actionable issues to address.

@don-petry
don-petry enabled auto-merge (squash) June 19, 2026 16:43
@don-petry
don-petry disabled auto-merge June 19, 2026 16:56
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
- SonarCloud Quality Gate: passed (0 new issues)
- CodeRabbit finding about secrets: inherit: already resolved in PR diff (thread marked resolved+outdated)
Files changed: 
- .github/workflows/auto-rebase.yml (correct fix applied for CodeRabbit finding)
- .github/workflows/dependabot-automerge.yml
- .github/workflows/dependency-audit.yml
Skipped (informational): 0 new issues from SonarCloud
```
**No changes needed.** The PR is clean from a code quality perspective (SonarCloud QG passed), and the prior CodeRabbit review finding was already correctly addressed.

@don-petry
don-petry enabled auto-merge (squash) June 19, 2026 16:57
@don-petry
don-petry disabled auto-merge June 19, 2026 17:06
@don-petry
don-petry enabled auto-merge (squash) June 19, 2026 17:06
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry disabled auto-merge June 19, 2026 17:09
@don-petry
don-petry enabled auto-merge (squash) June 19, 2026 17:09
@don-petry
don-petry disabled auto-merge June 19, 2026 17:11
@don-petry
don-petry enabled auto-merge (squash) June 19, 2026 17:11
@don-petry

Copy link
Copy Markdown
Contributor Author

Closing — superseded by the #482 reusable-channel migration. These stubs are now pinned to the <name>/stable channel (templates updated in #491; the compliance audit accepts the channel as of #492), so this remediation to the old pin is no longer the right fix. The fleet re-sync to channels is opening fresh standards-sync PRs.

@don-petry don-petry closed this Jun 20, 2026
auto-merge was automatically disabled June 20, 2026 00:39

Pull request was closed

@don-petry
don-petry deleted the dev-lead/issue-217-20260613-0820 branch June 20, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: non-stub-auto-rebase.yml

3 participants