Skip to content

feat: implement issue #226 — Compliance: secret_scanning_ai_detection - #238

Closed
don-petry wants to merge 2 commits into
mainfrom
dev-lead/issue-226-20260530-1355
Closed

don-petry wants to merge 2 commits into
mainfrom
dev-lead/issue-226-20260530-1355

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Closes #226

Implemented by dev-lead agent. Please review.

Copilot AI review requested due to automatic review settings May 30, 2026 14:01
@don-petry
don-petry requested a review from a team as a code owner May 30, 2026 14:01
@coderabbitai

coderabbitai Bot commented May 30, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 46 minutes and 13 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c899ac00-276e-4d5b-b00a-19888fb14cec

📥 Commits

Reviewing files that changed from the base of the PR and between 5204344 and 43a90ed.

📒 Files selected for processing (2)
  • .github/scripts/apply-repo-settings.sh
  • .gitignore
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-226-20260530-1355

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables AI-based secret scanning detection on the repository via the apply-repo-settings.sh script and adds a duplicate entry to .gitignore. Feedback suggests piping the GitHub API response to jq to prevent log clutter and removing the redundant .dev-lead/ entry from .gitignore.

Comment on lines +50 to +57
gh api -X PATCH "repos/$REPO" \
--input - <<'JSON'
{
"security_and_analysis": {
"secret_scanning_ai_detection": {"status": "enabled"}
}
}
JSON

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The gh api call will output the entire repository JSON payload to stdout, which can heavily clutter the CI/CD execution logs. Piping the output to jq .security_and_analysis (similar to how other API calls in this script use jq) will keep the logs clean and only print the relevant configuration for verification.

Suggested change
gh api -X PATCH "repos/$REPO" \
--input - <<'JSON'
{
"security_and_analysis": {
"secret_scanning_ai_detection": {"status": "enabled"}
}
}
JSON
gh api -X PATCH "repos/$REPO" \
--input - <<'JSON' | jq .security_and_analysis
{
"security_and_analysis": {
"secret_scanning_ai_detection": {"status": "enabled"}
}
}
JSON

Comment thread .gitignore Outdated
.dev-lead/
.dev-lead/
.dev-lead/
.dev-lead/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The .dev-lead/ entry is already duplicated multiple times in this file (lines 32-38). Adding it again is redundant and clutters the .gitignore file. This line should be removed.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses compliance issue #226 by enabling GitHub Secret Scanning AI detection as part of repository settings automation.

Changes:

  • Adds secret_scanning_ai_detection enablement to .github/scripts/apply-repo-settings.sh.
  • Updates .gitignore, though the added .dev-lead/ entry duplicates existing entries.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
.github/scripts/apply-repo-settings.sh Adds a GitHub API PATCH call to enable secret_scanning_ai_detection.
.gitignore Adds another .dev-lead/ ignore entry.

@don-petry
don-petry enabled auto-merge (squash) May 30, 2026 14:12
@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Closing due to merge conflict that cannot be auto-rebased. Re-implementing from fresh main via dev-lead.

@don-petry don-petry closed this Jun 2, 2026
auto-merge was automatically disabled June 2, 2026 12:17

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: secret_scanning_ai_detection

3 participants