Skip to content

feat: implement issue #158 — Compliance: unpinned-actions-dependency-audit.yml - #311

Closed
don-petry wants to merge 3 commits into
mainfrom
dev-lead/issue-158-20260521-1930
Closed

don-petry wants to merge 3 commits into
mainfrom
dev-lead/issue-158-20260521-1930

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

Closes #158

Implemented by dev-lead agent. Please review.

@don-petry
don-petry requested a review from a team as a code owner May 21, 2026 19:30
Copilot AI review requested due to automatic review settings May 21, 2026 19:30
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented May 21, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 9 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b837356d-995a-49dd-940d-0a2956aaf8c3

📥 Commits

Reviewing files that changed from the base of the PR and between 2642252 and 7fb8aba.

📒 Files selected for processing (1)
  • .github/workflows/dependency-audit.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-158-20260521-1930

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the dependency-audit.yml thin caller workflow to an immutable commit SHA to satisfy the org action-pinning compliance requirement (issue #158).

Changes:

  • Replace the reusable workflow reference from a floating tag (@v1) to a full commit SHA (with a # v1 annotation).

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved manually.

Please resolve the conflicts and push:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Collaborator Author

@donpetry-bot please review — compliance fix awaiting auto-review (manually triggered after pr-auto-review.yml is not deployed to this fleet repo)

@donpetry-bot

Copy link
Copy Markdown
Contributor

@don-petry I'm on it — starting a fresh review now. Results will appear in a few minutes.

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 7fb8aba085df937d8969118338ed24e9fb9b2ab6
Review mode: triage-approved (single reviewer)

Summary

One-line action-pinning fix in .github/workflows/dependency-audit.yml: the reusable workflow reference is moved from the mutable @v1 tag to the immutable commit SHA d3d768dabb7f28cc63283cdfe48630da53700e50 with a # v1 annotation for human readability. This is the canonical fix for the compliance standard.

Linked issue analysis

Closes #158 (Compliance: unpinned-actions-dependency-audit.yml). The issue flagged exactly this line — uses: petry-projects/.github/.github/workflows/dependency-audit-reusable.yml@v1 — and the diff resolves it by pinning to a full SHA per ci-standards.md#action-pinning-policy.

Findings

  • SHA verified: d3d768dabb7f28cc63283cdfe48630da53700e50 is exactly what the v1 tag currently points to on petry-projects/.github, so workflow behavior is preserved.
  • Annotation correct: the # v1 trailing comment matches the tag and follows the standard's recommended pattern.
  • Scope: diff is +1/-1 on a single file — no collateral changes.
  • Merge conflict (informational, not blocking review): GitHub reports mergeStateStatus: DIRTY / mergeable: CONFLICTING, and the auto-rebase bot flagged a conflict against main. This will need a manual rebase before merge but does not affect correctness of the change itself.

CI status

  • CodeQL (actions, javascript-typescript, python): ✅ all passed
  • CodeRabbit: ✅ success (rate-limited on summary but status check green)
  • SonarQube Cloud: ✅ Quality Gate passed (0 new issues, 0 security hotspots)
  • Copilot reviewer left a COMMENTED overview, no change requests.

Reviewed automatically by the PR-review agent (donpetry-bot single-reviewer). Reply if you need a human review.

@don-petry
don-petry requested a review from donpetry-bot May 23, 2026 23:46
@don-petry

Copy link
Copy Markdown
Collaborator Author

Closing — branch has merge conflict with main. Retriggering dev-lead via label cycle.

@don-petry don-petry closed this May 23, 2026
@don-petry
don-petry deleted the dev-lead/issue-158-20260521-1930 branch May 23, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: unpinned-actions-dependency-audit.yml

3 participants