Skip to content

Compliance: non-stub-dependabot-rebase.yml #256

Closed

Description

@don-petry

Compliance Finding

Category: ci-workflows
Severity: error
Check: non-stub-dependabot-rebase.yml

Detail

Centralized workflow dependabot-rebase.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependabot-rebase.yml which delegates to petry-projects/.github/.github/workflows/dependabot-rebase-reusable.yml@v1.

Standard Reference

standards/ci-standards.md#centralization-tiers

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on May 8, 2026

    @don-petry
    CollaboratorAuthor

    Claude finished @don-petry's task in 1m 44s —— View job • claude/issue-256-20260508-1427 • Create PR ➔


    Fixing Compliance Issue: dependabot-rebase.yml

    • Analyze issue and gather context
    • Fetch canonical template from petry-projects/.github/standards/workflows/dependabot-rebase.yml
    • Review current dependabot-rebase.yml — missing schedule trigger and stale comment text
    • Replace workflow file with canonical stub (verbatim copy)
    • Commit and push changes
    • Create pull request — petry-projects/google-app-scripts#260
    • Self-review PR — single file change, diff matches canonical stub exactly, no issues found
    • Tagged @petry-projects/org-leads on the PR

    Summary

    The dependabot-rebase.yml was missing the schedule trigger (0 */4 * * *) required by the org standard. I replaced the file with the verbatim canonical stub from petry-projects/.github/standards/workflows/dependabot-rebase.yml. Changes:

    • Added schedule: cron: '0 */4 * * *' — safety net when no push to main triggers the chain
    • Updated comment text to document the schedule trigger
    • Fixed APP_ID comment to include contents:write

    | View PR #260

  2. don-petry commented on May 11, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-11)

    This finding is still open.

    Detail: Centralized workflow dependabot-rebase.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependabot-rebase.yml which delegates to petry-projects/.github/.github/workflows/dependabot-rebase-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  3. don-petry commented on May 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-12)

    This finding is still open.

    Detail: Centralized workflow dependabot-rebase.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependabot-rebase.yml which delegates to petry-projects/.github/.github/workflows/dependabot-rebase-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  4. don-petry commented on May 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-12)

    This finding is still open.

    Detail: Centralized workflow dependabot-rebase.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependabot-rebase.yml which delegates to petry-projects/.github/.github/workflows/dependabot-rebase-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  5. don-petry commented on May 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-12)

    This finding is still open.

    Detail: Centralized workflow dependabot-rebase.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependabot-rebase.yml which delegates to petry-projects/.github/.github/workflows/dependabot-rebase-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  6. don-petry commented on May 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-12)

    This finding is still open.

    Detail: Centralized workflow dependabot-rebase.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependabot-rebase.yml which delegates to petry-projects/.github/.github/workflows/dependabot-rebase-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  7. don-petry commented on May 12, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-12)

    This finding is still open.

    Detail: Centralized workflow dependabot-rebase.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependabot-rebase.yml which delegates to petry-projects/.github/.github/workflows/dependabot-rebase-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  8. don-petry commented on May 13, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-13)

    This finding is still open.

    Detail: Centralized workflow dependabot-rebase.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependabot-rebase.yml which delegates to petry-projects/.github/.github/workflows/dependabot-rebase-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  9. don-petry commented on May 15, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-05-15)

    This finding is still open.

    Detail: Centralized workflow dependabot-rebase.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/dependabot-rebase.yml which delegates to petry-projects/.github/.github/workflows/dependabot-rebase-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  10. added a commit that references this issue on May 15, 2026
    b5523e8
  11. 11 remaining items

  12. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 8, 2026
  13. don-petry commented on Jun 8, 2026

    @don-petry
    CollaboratorAuthor
    Already working on this: an open PR exists for issue #256.
  14. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 20, 2026
  15. don-petry commented on Jun 20, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #256 — Compliance: non-stub-dependabot-rebase.yml

    Scope

    Replace the non-compliant .github/workflows/dependabot-rebase.yml (which pins the reusable to a frozen commit SHA @ce8a8c…# v1) with the canonical thin-caller stub from petry-projects/.github standards/workflows/dependabot-rebase.yml, which pins to the centrally-advanced @dependabot-rebase/stable channel.

    Implementation Checklist

    • Replace .github/workflows/dependabot-rebase.yml with the canonical stub content (updated header comment, contents: write + pull-requests: write job permissions, uses: …@dependabot-rebase/stable)

    Tests to Write

    • None. This is a pure CI-configuration change with no executable logic and no test harness for workflow YAML — Phase 2 (TDD) is skipped per the documented exception for config/behavior-preserving changes.

    Test Command

    npm test (full suite, to confirm no regressions)

  16. don-petry commented on Jun 20, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Replaced .github/workflows/dependabot-rebase.yml with the canonical thin-caller stub from petry-projects/.github standards/workflows/dependabot-rebase.yml
    • Ran npx prettier --write to satisfy the repo's format check (only collapsed comment-alignment whitespace; no functional change)
    • Verified dev-lead lint, repo lint/format, full test suite, and coverage thresholds

    Key Change

    The reusable was pinned to a frozen commit SHA (@ce8a8c328b21feb26c7bb9ef81ffb26354e9a4da # v1). It now points at the centrally-advanced moving channel @dependabot-rebase/stable, matching the source-of-truth stub (same pattern as the sibling add-to-project.yml). Job permissions were brought into line with the canonical (contents: write + pull-requests: write), and the header guidance was updated.

    Note on the issue's @v1 wording: the canonical standards/workflows/dependabot-rebase.yml is authoritative and uses the @dependabot-rebase/stable channel rather than a frozen @v1 tag. The compliance finding's core requirement — stop pinning to a SHA and adopt the canonical stub — is satisfied.

    Test Results

    dev-lead-lint: [lint] all checks passed (exit 0)
    npm run check: ✖ 22 problems (0 errors, 22 warnings)  # warnings all pre-existing in unrelated test files
    
    Test Suites: 12 passed, 12 total
    Tests:       301 passed, 301 total
    
    📊 Coverage Report:
    ✅ statements : 98.91% (999/1010) [required: 95%]
    ✅ branches   : 90.00% (558/620) [required: 85%]
    ✅ functions  : 98.00% (98/100) [required: 95%]
    ✅ lines      : 100% (0/0) [required: 100%]
    ✅ All coverage metrics meet requirements.
    

    Files Changed

    • .github/workflows/dependabot-rebase.yml: replaced SHA-pinned reusable ref with canonical @dependabot-rebase/stable stub; updated permissions and header comments to match source of truth.

    Notes

    • TDD (Phase 2) skipped per the documented exception: this is a pure CI-configuration change with no executable logic and no test harness for workflow YAML. The full existing suite was run to confirm no regressions.
    • No source/test files modified.
  17. don-petry commented on Jun 26, 2026

    @don-petry
    CollaboratorAuthor

    Resolved! This check is now passing as of 2026-06-26. Closing automatically.

  18. added 4 commits that reference this issue on Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions