Skip to content

Compliance: gitignore_secrets_block #172

Closed

Description

@don-petry

Compliance Finding

Category: push-protection
Severity: warning
Check: gitignore_secrets_block

Detail

.gitignore is missing baseline secret patterns: .pem,.key — copy the org baseline at /.gitignore

Standard Reference

standards/push-protection.md#required-gitignore-entries

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on Apr 9, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-04-09)

    This finding is still open.

    Detail: .gitignore is missing baseline secret patterns: .pem,.key — copy the org baseline at /.gitignore

    Standard: standards/push-protection.md#required-gitignore-entries

  2. don-petry commented on Apr 9, 2026

    @don-petry
    CollaboratorAuthor

    Claude encountered an error —— View job


    I'll analyze this and get back to you.

  3. don-petry commented on Apr 10, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-04-10)

    This finding is still open.

    Detail: .gitignore is missing baseline secret patterns: .pem,.key — copy the org baseline at /.gitignore

    Standard: standards/push-protection.md#required-gitignore-entries

  4. don-petry commented on Apr 14, 2026

    @don-petry
    CollaboratorAuthor

    Claude finished @don-petry's task in 1m 36s —— View job • claude/issue-172-20260414-1146


    Fixing compliance issue: missing .gitignore secret patterns

    • Analyze the issue
    • Read current .gitignore
    • Fetch org baseline .gitignore patterns
    • Add missing patterns (*.pem, *.key + full org baseline)
    • Commit and push
    • Create PR

    Summary

    The .gitignore only had 5 entries and was missing the required *.pem, *.key, and all other org baseline secret patterns. I copied the full petry-projects secrets baseline verbatim and prepended the existing repo-specific entries (node_modules/, coverage/, test-results/, playwright-report/) in a dedicated section at the top.

    Create a PR — PR already created at #191

  5. added a commit that references this issue on Apr 14, 2026
    c063fdd
  6. don-petry commented on Apr 17, 2026

    @don-petry
    CollaboratorAuthor

    Weekly Compliance Audit (2026-04-17)

    This finding is still open.

    Detail: .gitignore is missing baseline secret patterns: .pem,.key — copy the org baseline at /.gitignore

    Standard: standards/push-protection.md#required-gitignore-entries

  7. don-petry commented on Apr 18, 2026

    @don-petry
    CollaboratorAuthor

    Claude finished @don-petry's task in 2m 44s —— View job • claude/issue-172-20260418-1846


    Fixing compliance issue: missing .gitignore secret patterns

    Summary

    The .gitignore had only 5 entries and was missing *.pem, *.key, and all other org baseline secret patterns. I copied the full petry-projects secrets baseline verbatim and preserved the existing repo-specific entries (node_modules/, coverage/, test-results/, playwright-report/) in a dedicated section at the top. The standalone .env entry was removed since it's already covered by the baseline's dotenv section.

    CI is running on the PR. The change only touches .gitignore so no test failures are expected.

    Create a PR — PR already created at #197
    • claude/issue-172-20260418-1846

  8. added a commit that references this issue on Apr 18, 2026
    be63868
  9. 21 remaining items

  10. don-petry commented on May 21, 2026

    @don-petry
    CollaboratorAuthor
    Already working on this: an open PR exists for issue #172.
  11. added a commit that references this issue on May 24, 2026
  12. don-petry commented on Jun 2, 2026

    @don-petry
    CollaboratorAuthor

    Dev-Lead Implementation Plan

    Issue: #172 — Compliance: gitignore_secrets_block

    Scope

    Verify *.pem and *.key patterns exist in .gitignore and clean up duplicate .dev-lead/ entries left by previous agent runs.

    Findings

    Both *.pem and *.key are already present in .gitignore (lines 6–7), so the compliance finding is satisfied. However, the file contains 12+ duplicate .dev-lead/ entries (lines 8–25) from prior agent sessions that should be deduplicated.

    Implementation Checklist

    • Confirm *.pem and *.key are present (they are — lines 6–7)
    • Deduplicate .dev-lead/ entries (reduce to one occurrence)

    Tests to Write

    N/A — this is a pure configuration file change with no testable logic. Skipping Phase 2 per the TDD exception for configuration/documentation changes.

    Test Command

    npm test

  13. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 3, 2026
  14. don-petry commented on Jun 5, 2026

    @don-petry
    CollaboratorAuthor

    Resolved! This check is now passing as of 2026-06-05. Closing automatically.

  15. added a commit that references this issue on Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions