Skip to content

feat: implement issue #306 — [Fleet Monitor] petry-projects/broodly — .github/workflows/dependency-audit.yml - #307

Merged
don-petry merged 13 commits into
mainfrom
dev-lead/issue-306-20260614-0956
Jun 18, 2026
Merged

don-petry merged 13 commits into
mainfrom
dev-lead/issue-306-20260614-0956

Conversation

@don-petry

@don-petry don-petry commented Jun 14, 2026 •

Copy link
Copy Markdown
Contributor

Closes #306

Implemented by dev-lead agent. Please review.

Summary by CodeRabbit

  • Chores
    • Updated package dependency resolution rules to enforce a compatible version range for @ungap/structured-clone, improving dependency stability and consistency.

@don-petry
don-petry requested a review from a team as a code owner June 14, 2026 09:59
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5f303f5b-7c71-4414-b55f-f0424747af2e

📥 Commits

Reviewing files that changed from the base of the PR and between c01f532 and dc282aa.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

A pnpm.overrides entry is added to package.json forcing any transitive dependency resolving @ungap/structured-clone at a version below 1.3.1 to use >=1.3.1. Existing override entries are retained unchanged.

Changes

@ungap/structured-clone version override

Layer / File(s) Summary
pnpm override for @ungap/structured-clone
package.json
Adds "@ungap/structured-clone@<1.3.1": ">=1.3.1" to pnpm.overrides, ensuring transitive installs of older @ungap/structured-clone versions are pinned to a patched release.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • petry-projects/broodly#54: Both PRs modify package.json's pnpm.overrides dependency-resolution rules using the same mechanism to enforce specific package versions.

Suggested reviewers

  • donpetry-bot
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title references issue #306 and mentions the workflow file, but the actual change shown in the summary only involves package.json dependency overrides, not workflow file modifications. Update the title to accurately reflect that this PR adds a security override for @ungap/structured-clone in package.json, not a workflow file modification.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The linked issue #306 reports a critical failure in the dependency-audit.yml workflow with 100% failure rate. The PR implements a security fix for @ungap/structured-clone vulnerability via package.json override, which aligns with addressing the workflow failure root cause.
Out of Scope Changes check ✅ Passed The change is scoped to adding a single dependency override in package.json to fix a known security vulnerability, which is directly related to resolving the dependency-audit workflow failures mentioned in issue #306.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-306-20260614-0956

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the shell-quote dependency to version 1.8.4 in package.json and pnpm-lock.yaml to resolve security vulnerabilities. The review feedback correctly identifies that @ungap/structured-clone@1.3.0 is flagged in the lockfile with a potential CWE-502 deserialization vulnerability and recommends adding an override to upgrade it to version 1.3.1 or higher.

Comment thread package.json Resolved
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #307
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-14T10:32:40Z

@don-petry

Copy link
Copy Markdown
Contributor Author

Note

I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-14T10:32:40Z

@don-petry
don-petry enabled auto-merge (squash) June 14, 2026 10:02
@don-petry
don-petry disabled auto-merge June 15, 2026 23:39
@don-petry
don-petry enabled auto-merge (squash) June 15, 2026 23:39
@don-petry
don-petry disabled auto-merge June 15, 2026 23:43
@don-petry
don-petry enabled auto-merge (squash) June 15, 2026 23:44
@don-petry
don-petry disabled auto-merge June 15, 2026 23:49
@don-petry
don-petry enabled auto-merge (squash) June 15, 2026 23:49
@don-petry
don-petry disabled auto-merge June 15, 2026 23:51
@don-petry
don-petry enabled auto-merge (squash) June 15, 2026 23:52
@don-petry
don-petry disabled auto-merge June 15, 2026 23:58
@don-petry
don-petry enabled auto-merge (squash) June 15, 2026 23:58
@don-petry
don-petry disabled auto-merge June 16, 2026 00:00
@don-petry
don-petry enabled auto-merge (squash) June 16, 2026 00:00
@don-petry
don-petry disabled auto-merge June 16, 2026 00:05
@don-petry
don-petry enabled auto-merge (squash) June 16, 2026 00:05
@don-petry
don-petry disabled auto-merge June 16, 2026 00:10
@don-petry
don-petry enabled auto-merge (squash) June 16, 2026 00:11
@don-petry
don-petry disabled auto-merge June 16, 2026 00:13
@don-petry
don-petry enabled auto-merge (squash) June 16, 2026 00:13
@don-petry
don-petry disabled auto-merge June 18, 2026 01:50
@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 05:47
@don-petry
don-petry disabled auto-merge June 18, 2026 05:55
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
- No new issues found by SonarCloud
- Existing gemini-code-assist recommendation already implemented (resolved thread)
Files changed: .github/workflows/stale.yml, package.json, pnpm-lock.yaml
Skipped: 0
```
**Conclusion:** The PR is in good state. The SonarCloud Quality Gate has passed with zero issues, and the security vulnerability recommendation from the Gemini bot has already been addressed via the `@ungap/structured-clone` override. No additional fixes are needed.

@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 05:56
@don-petry
don-petry disabled auto-merge June 18, 2026 06:02
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 06:03
@don-petry
don-petry disabled auto-merge June 18, 2026 06:07
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 06:10
@don-petry
don-petry disabled auto-merge June 18, 2026 06:12
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #307
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-18T06:43:41Z

@don-petry

Copy link
Copy Markdown
Contributor Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-18T06:43:41Z

@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 06:13
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry disabled auto-merge June 18, 2026 06:18
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 06:20

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: ec887c0ec27751ca2e5311c0ea9f43f89132fb42
Review mode: triage-approved (single reviewer)

Summary

Adds a pnpm override pinning @ungap/structured-clone to >=1.3.1 to remediate the CWE-502 deserialization vulnerability in the deprecated 1.3.0 release, with the matching pnpm-lock.yaml bump (1.3.0 -> 1.3.1). All other existing overrides (including the shell-quote security override) are retained. Confirmed against main: the change is purely additive at the override layer; the remaining lockfile deltas (@babel/traverse, @babel/parser -> 7.29.7) are transitive resolutions inherited from main merges.

Linked issue analysis

Closes #306, which reports the dependency-audit.yml workflow failing at 100% (80/80 runs). The deprecated @ungap/structured-clone@1.3.0 (flagged CWE-502) was the audit failure root cause; pinning it to >=1.3.1 substantively addresses the issue. The gemini-code-assist reviewer explicitly recommended this override, and it has been implemented.

Findings

No issues. Verified the PR does not drop any existing override: PR head retains all of main's overrides (shell-quote, ws, form-data, etc.) and only adds the @ungap/structured-clone entry. The gh pr diff view showed a misleading -/+ on the shell-quote line purely as a merge-base ordering artifact; the resolved file content is correct. CodeRabbit, SonarCloud (0 issues/0 hotspots), and CodeQL found nothing actionable.

CI status

All checks green or skipped: CI (TypeScript, Go, gitleaks), CodeQL (actions/go/javascript-typescript), SonarCloud (Quality Gate passed), AgentShield, Dependency audit (pnpm audit + govulncheck pass), CodeRabbit SUCCESS. mergeStateStatus=BLOCKED / reviewDecision=REVIEW_REQUIRED reflect the pending org-leads team review (process gate), not a code or CI failure.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry merged commit 78465fd into main Jun 18, 2026
23 checks passed
@don-petry
don-petry deleted the dev-lead/issue-306-20260614-0956 branch June 18, 2026 06:23

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: ec887c0ec27751ca2e5311c0ea9f43f89132fb42
Review mode: triage-approved (single reviewer)

Summary

Adds a pnpm override pinning @ungap/structured-clone to >=1.3.1 to remediate the CWE-502 deserialization vulnerability in the deprecated 1.3.0 release, with the matching pnpm-lock.yaml bump (1.3.0 -> 1.3.1). Independently verified package.json at the head SHA: all pre-existing overrides (shell-quote, ws, form-data, js-yaml, @babel/core, etc.) are retained and the @ungap/structured-clone entry is purely additive. The remaining lockfile deltas (@babel/traverse, @babel/parser -> 7.29.7) are transitive resolutions inherited from main merges.

Linked issue analysis

Closes #306, which reports the dependency-audit.yml workflow failing at 100%. The deprecated @ungap/structured-clone@1.3.0 (flagged CWE-502) was the audit failure root cause; pinning it to >=1.3.1 substantively addresses the issue. The gemini-code-assist reviewer explicitly recommended this exact override, and it has been implemented.

Findings

No blocking issues. Verified directly against the file at the head SHA that the PR does not drop any existing override — the misleading -/+ on the shell-quote line in gh pr diff is a merge-base ordering artifact; the resolved package.json retains shell-quote@>=1.8.4 alongside the new entry. CodeRabbit (no actionable comments), SonarCloud (0 issues / 0 hotspots), and CodeQL found nothing actionable. Minor non-blocking nit: the PR title references the dependency-audit.yml workflow file, but the actual change is a package.json override — the title could be updated for accuracy (CodeRabbit raised the same title warning).

CI status

All checks green or skipped: CI (TypeScript, Go, gitleaks), CodeQL (actions/go/javascript-typescript), SonarCloud (Quality Gate passed), AgentShield, Dependency audit (pnpm audit + govulncheck pass), CodeRabbit SUCCESS. reviewDecision is APPROVED.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet Monitor] petry-projects/broodly — .github/workflows/dependency-audit.yml

2 participants