Skip to content

feat: implement issue #240 — [Fleet Monitor] petry-projects/broodly — dependabot-updates - #296

Merged
don-petry merged 7 commits into
mainfrom
dev-lead/issue-240-20260609-2231
Jun 18, 2026
Merged

don-petry merged 7 commits into
mainfrom
dev-lead/issue-240-20260609-2231

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Closes #240

Implemented by dev-lead agent. Please review.

@don-petry
don-petry requested a review from a team as a code owner June 9, 2026 22:36
Copilot AI review requested due to automatic review settings June 9, 2026 22:36
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 27 minutes and 44 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c3909296-61e4-4e59-8c30-e075b888b7ff

📥 Commits

Reviewing files that changed from the base of the PR and between f2c7964 and ee13b43.

📒 Files selected for processing (1)
  • .github/dependabot.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-240-20260609-2231

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Dependabot configuration in .github/dependabot.yml to ignore updates for several npm dependencies, specifically tmp, uuid, brace-expansion, lodash, and @tootallnate/once. The reviewer suggested sorting these newly added dependencies alphabetically to improve the readability and maintainability of the configuration file.

Comment thread .github/dependabot.yml Resolved
@don-petry
don-petry enabled auto-merge (squash) June 9, 2026 22:37
@don-petry
don-petry disabled auto-merge June 9, 2026 22:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Dependabot configuration to reduce failures in the repository’s dependency update process (Issue #240) by ignoring additional transitive packages that are already handled via pnpm.overrides.

Changes:

  • Expanded the npm ignore list in .github/dependabot.yml to include additional transitive dependencies (tmp, uuid, brace-expansion, lodash, @tootallnate/once).
  • Keeps Dependabot from repeatedly attempting updates for dependencies whose safe versions are already enforced via pnpm.overrides.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) June 9, 2026 22:41
@don-petry
don-petry disabled auto-merge June 9, 2026 22:42
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry force-pushed the dev-lead/issue-240-20260609-2231 branch from c233e19 to 71464cc Compare June 18, 2026 05:13
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — rebase (no-changes)

Agent reasoning
PR: #296
Rebased onto: main (6dfb7bc)
Conflicts resolved: 1 file
- pnpm-lock.yaml: Both sides changed `ws` version for `react-devtools-core@6.1.5` — kept `8.21.0` from main (newer than PR's `8.20.1`; main already adopted the bump)
Push: success
```

@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 05:14
@don-petry
don-petry disabled auto-merge June 18, 2026 05:17
@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 05:19
@don-petry
don-petry disabled auto-merge June 18, 2026 05:24
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
- **Code Issues:** 0
- **CI Status:** No failed checks (CodeRabbit passed; other checks queued/pending)
- **Review State:** All 3 reviews in COMMENTED state (no CHANGES_REQUESTED)
**Findings:**
1. SonarCloud found **zero new issues** in the PR — Quality Gate passed cleanly
2. The single review thread from `gemini-code-assist` (about alphabetical sorting) is already marked as `isResolved: true` and `isOutdated: true`
3. The `.github/dependabot.yml` dependencies are already properly sorted alphabetically (@-prefixed names first, then alphabetical)
4. No Tier 1 blockers exist (no failures, timeouts, or CHANGES_REQUESTED reviews)
**Result:**
No code fixes required. The PR has passed SonarCloud quality checks with zero issues reported.

@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 05:25
@don-petry
don-petry disabled auto-merge June 18, 2026 05:31
@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 05:32
@don-petry
don-petry disabled auto-merge June 18, 2026 05:35
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 05:37
@don-petry
don-petry disabled auto-merge June 18, 2026 05:38
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 05:39
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry disabled auto-merge June 18, 2026 05:42
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 18, 2026 05:43

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: ee13b430b74c0501a677e1d3b050103348ab3ba8
Review mode: triage-approved (single reviewer)

Summary

Expands the npm ignore list in .github/dependabot.yml to cover transitive deps that are already pinned to safe versions via pnpm.overrides, stopping Dependabot's security updater from generating repeatedly-failing update PRs (root cause of issue #240). Verified all 9 ignored deps map to a pnpm.overrides entry; entries are alphabetized per the bot suggestion. 1 file, +7/-1.

Linked issue analysis

Issue #240 (Fleet Monitor: dependabot-updates failing 60% of runs) is substantively addressed. The workflow failed because Dependabot's security updater does not understand pnpm.overrides and kept attempting updates for transitive deps constrained by upstream. Adding them to the ignore list removes the failing attempts while pnpm.overrides continues to enforce safe versions in the lockfile.

Findings

  • Verified each newly ignored dependency has a corresponding pnpm.overrides pin enforcing a safe version: @tootallnate/once, @xmldom/xmldom, brace-expansion, lodash, postcss, shell-quote, tmp, uuid, ws. No genuinely-unpatched vulnerability is being suppressed.
  • Override pins use >= ranges, so the lockfile keeps resolving safe versions independently of Dependabot.
  • Gemini's only suggestion (alphabetical sorting) is satisfied in the final diff; Copilot review is positive; no unresolved human threads.
  • No findings requiring changes.

CI status

All required checks green (CodeQL, SonarCloud, AgentShield, gitleaks, TypeScript, Go, dependency-audit/pnpm audit, govulncheck). Remaining checks are SKIPPED (path/condition gated), none failing. mergeStateStatus BLOCKED is solely due to REVIEW_REQUIRED, which this review satisfies.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@don-petry
don-petry merged commit 88c411e into main Jun 18, 2026
23 checks passed
@don-petry
don-petry deleted the dev-lead/issue-240-20260609-2231 branch June 18, 2026 05:47

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: ee13b430b74c0501a677e1d3b050103348ab3ba8
Review mode: triage-approved (single reviewer)

Summary

Expands the npm ignore list in .github/dependabot.yml to cover all 9 transitive deps already pinned to safe versions via pnpm.overrides, stopping Dependabot's security updater (which doesn't understand pnpm.overrides) from generating repeatedly-failing update PRs — the root cause of issue #240. List is alphabetized per the reviewer suggestion. 1 file, +7/-1.

Linked issue analysis

Issue #240 (Fleet Monitor: dependabot-updates failing) is substantively addressed. The failures stemmed from Dependabot attempting updates for transitive deps that upstream constrains to vulnerable ranges; pnpm.overrides already forces safe resolutions in the lockfile, so ignoring them in Dependabot removes the failing attempts without weakening security.

Findings

  • Verified each newly-ignored dependency maps to a corresponding pnpm.overrides pin enforcing a safe version: @tootallnate/once (>=3.0.1), @xmldom/xmldom (>=0.9.10), brace-expansion (>=5.0.6), lodash (>=4.18.0), postcss (>=8.5.10), shell-quote (>=1.8.4), tmp (>=0.2.6), uuid (>=11.1.1), ws (>=8.21.0). No genuinely-unpatched vulnerability is being suppressed.
  • Ignore list is alphabetized (@-prefixed first), satisfying Gemini's sole suggestion; the corresponding review thread is resolved/outdated. Copilot's review is positive. No unresolved human threads.
  • No findings requiring changes. Triage's low-risk assessment confirmed.

CI status

All required checks green: CodeQL (actions/go/javascript-typescript), SonarCloud (Quality Gate passed, 0 new issues), AgentShield, gitleaks, TypeScript, Go, dependency-audit (pnpm audit + govulncheck), CodeRabbit. Remaining checks SKIPPED (path/condition-gated), none failing. reviewDecision is APPROVED.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet Monitor] petry-projects/broodly — dependabot-updates

3 participants