Skip to content

ci: remove drift codeql.yml — GitHub-managed default setup is configured - #146

Closed
don-petry wants to merge 32 commits into
mainfrom
claude/issue-109-20260420-0233
Closed

don-petry wants to merge 32 commits into
mainfrom
claude/issue-109-20260420-0233

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Summary

  • Removes .github/workflows/codeql.yml, which is drift per org standard §2 (ci-standards.md#2)
  • GitHub-managed CodeQL default setup is confirmed configured (state=configured, languages: actions, go, javascript, typescript, query_suite: default)
  • Re-applied configuration via gh api -X PATCH repos/petry-projects/broodly/code-scanning/default-setup -F state=configured -F query_suite=default as part of remediation
  • Supersedes PR ci: remove drift codeql.yml, enable GitHub-managed default setup #126 (same change, now stale/behind main)

Why the compliance finding keeps recurring

The audit's GH_TOKEN does not have the security_events read scope needed to call GET /repos/petry-projects/broodly/code-scanning/default-setup. It receives a 403, which the script interprets as "not configured". This is an audit-bot permissions issue, not a repo configuration issue — the default setup is genuinely configured.

Removing the drift codeql.yml eliminates the stray-codeql-workflow check, and should eliminate the duplicate CodeQL analysis. The codeql-default-setup-not-configured finding will stop once the audit bot's token is granted the necessary scope.

Test plan

  • Default setup confirmed state=configured via API before and after
  • codeql.yml was only scanning actions (already covered by default setup)
  • No other workflows reference or depend on codeql.yml
  • Required CodeQL status check will be satisfied by GitHub-managed default setup

Closes #109

Generated with Claude Code

Copilot AI review requested due to automatic review settings April 20, 2026 02:38
@coderabbitai

coderabbitai Bot commented Apr 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 58 minutes and 43 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e9aaaa59-7020-4803-af55-97b8d9e0a88b

📥 Commits

Reviewing files that changed from the base of the PR and between 61aa4ee and 6523910.

📒 Files selected for processing (1)
  • .gitignore
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-109-20260420-0233

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@don-petry

Copy link
Copy Markdown
Contributor Author

@don-petry — PR is ready for review and merge. Single change: removes drift .github/workflows/codeql.yml per org standard §2. The GitHub-managed CodeQL default setup is confirmed configured and covers all languages including actions.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the repository’s custom CodeQL GitHub Actions workflow to eliminate drift from the org standard, relying instead on GitHub-managed CodeQL Default Setup.

Changes:

  • Deleted .github/workflows/codeql.yml (custom CodeQL workflow that analyzed only actions).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown
Contributor

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved manually.

Please resolve the conflicts and push:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

Per org standard §2 (standards/ci-standards.md#2-codeql-analysis-github-managed-default-setup),
CodeQL scanning must use GitHub-managed default setup — not a per-repo workflow
file. The default setup is confirmed configured (state=configured, languages:
actions, go, javascript, typescript) via the code-scanning API.

The stray codeql.yml scanned only the `actions` ecosystem and creates a
duplicate analysis alongside the default setup, wasting CI minutes. Removing it
leaves the default setup as the sole CodeQL analysis path, which auto-detects
all supported languages on the default branch.

Closes #109

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
@don-petry
don-petry force-pushed the claude/issue-109-20260420-0233 branch from 0754ae0 to f47edaa Compare May 13, 2026 17:06
@don-petry
don-petry requested a review from a team as a code owner May 13, 2026 17:06
@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

@dev-lead - please fix this PR

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (applied)

Changes committed and pushed.

@sonarqubecloud

sonarqubecloud Bot commented Jun 1, 2026

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Closing due to merge conflict that cannot be auto-rebased. Re-implementing from fresh main via dev-lead.

@don-petry don-petry closed this Jun 2, 2026
auto-merge was automatically disabled June 2, 2026 12:24

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: codeql-default-setup-not-configured

3 participants