Repository navigation
Description
Compliance Audit — 2026-08-07
This umbrella issue tracks all findings from the automated compliance audit run on 2026-08-07.
Findings are grouped by remediation category. Address each category together to avoid duplicate agent PRs.
Total findings: 65 across 12 repositories
Remediation Work Breakdown
Repository Settings (5 finding(s))
Remediation: apply-repo-settings.sh
Affected repos: demo-repository
| Repo | Check | Severity |
|---|---|---|
demo-repository |
allow_auto_merge |
warning |
demo-repository |
delete_branch_on_merge |
warning |
demo-repository |
has_discussions |
error |
demo-repository |
missing-codeowners |
error |
demo-repository |
check-suite-prefs-unreadable |
warning |
Push Protection & Secret Scanning (6 finding(s))
Remediation: apply-repo-settings.sh (security_and_analysis) + per-repo ci.yml and .gitignore
Affected repos: .github-private, demo-repository, markets, repo-template
| Repo | Check | Severity |
|---|---|---|
repo-template |
gitignore_baseline |
error |
.github-private |
gitignore_baseline |
error |
markets |
gitignore_baseline |
error |
demo-repository |
security_and_analysis_unavailable |
warning |
demo-repository |
secret_scan_ci_job_present |
error |
demo-repository |
gitignore_baseline |
error |
Repository Rulesets (28 finding(s))
Remediation: apply-rulesets.sh
Affected repos: .github, .github-private, ContentTwin, TalkTerm, bmad-bgreat-suite, broodly, broodminder-export, demo-repository, google-app-scripts, incubator, markets, repo-template
| Repo | Check | Severity |
|---|---|---|
repo-template |
ruleset-drift-pr-quality-dismiss_stale_reviews_on_push |
error |
repo-template |
ruleset-drift-pr-quality-require_last_push_approval |
error |
.github |
ruleset-drift-pr-quality-dismiss_stale_reviews_on_push |
error |
.github |
ruleset-drift-pr-quality-require_last_push_approval |
error |
.github-private |
ruleset-drift-pr-quality-dismiss_stale_reviews_on_push |
error |
.github-private |
ruleset-drift-pr-quality-require_last_push_approval |
error |
markets |
ruleset-bypass-orgadmin-code-quality |
error |
markets |
ruleset-bypass-dependabot-code-quality |
error |
markets |
ruleset-drift-pr-quality-require_code_owner_review |
error |
markets |
ruleset-drift-pr-quality-dismiss_stale_reviews_on_push |
error |
markets |
ruleset-drift-pr-quality-require_last_push_approval |
error |
broodly |
ruleset-drift-pr-quality-require_code_owner_review |
error |
broodly |
ruleset-drift-pr-quality-dismiss_stale_reviews_on_push |
error |
broodly |
ruleset-drift-pr-quality-require_last_push_approval |
error |
google-app-scripts |
ruleset-drift-pr-quality-dismiss_stale_reviews_on_push |
error |
google-app-scripts |
ruleset-drift-pr-quality-require_last_push_approval |
error |
ContentTwin |
ruleset-drift-pr-quality-dismiss_stale_reviews_on_push |
error |
ContentTwin |
ruleset-drift-pr-quality-require_last_push_approval |
error |
incubator |
ruleset-drift-pr-quality-dismiss_stale_reviews_on_push |
error |
incubator |
ruleset-drift-pr-quality-require_last_push_approval |
error |
TalkTerm |
ruleset-drift-pr-quality-dismiss_stale_reviews_on_push |
error |
TalkTerm |
ruleset-drift-pr-quality-require_last_push_approval |
error |
bmad-bgreat-suite |
ruleset-drift-pr-quality-dismiss_stale_reviews_on_push |
error |
bmad-bgreat-suite |
ruleset-drift-pr-quality-require_last_push_approval |
error |
demo-repository |
missing-pr-quality |
error |
demo-repository |
missing-code-quality |
error |
broodminder-export |
ruleset-drift-pr-quality-dismiss_stale_reviews_on_push |
error |
broodminder-export |
ruleset-drift-pr-quality-require_last_push_approval |
error |
Workflows (18 finding(s))
Remediation: per-repo workflow additions
Affected repos: .github-private, ContentTwin, demo-repository, google-app-scripts, markets
| Repo | Check | Severity |
|---|---|---|
.github-private |
non-stub-agent-shield.yml |
error |
markets |
non-stub-feature-ideation.yml |
error |
google-app-scripts |
stub-surface-drift-pr-auto-review.yml-on |
error |
ContentTwin |
stub-surface-drift-dependency-audit.yml-concurrency |
warning |
ContentTwin |
stub-surface-drift-pr-review-mention.yml-concurrency |
warning |
ContentTwin |
stub-surface-drift-pr-auto-review.yml-concurrency |
warning |
demo-repository |
missing-ci.yml |
error |
demo-repository |
missing-sonarcloud.yml |
error |
demo-repository |
missing-dev-lead.yml |
error |
demo-repository |
missing-dependabot-automerge.yml |
error |
demo-repository |
missing-dependency-audit.yml |
error |
demo-repository |
missing-agent-shield.yml |
error |
demo-repository |
missing-pr-review-mention.yml |
error |
demo-repository |
missing-feature-ideation.yml |
error |
demo-repository |
missing-pr-auto-review.yml |
error |
demo-repository |
missing-initiative-driver.yml |
error |
demo-repository |
missing-permissions-auto-assign.yml |
warning |
demo-repository |
missing-permissions-proof-html.yml |
warning |
Action SHA Pinning (2 finding(s))
Remediation: pin actions to SHA in each workflow file
Affected repos: demo-repository
| Repo | Check | Severity |
|---|---|---|
demo-repository |
unpinned-actions-auto-assign.yml |
error |
demo-repository |
unpinned-actions-proof-html.yml |
error |
Dependabot Configuration (2 finding(s))
Remediation: per-repo .github/dependabot.yml
Affected repos: demo-repository, repo-template
| Repo | Check | Severity |
|---|---|---|
repo-template |
missing-github-actions-ecosystem |
error |
demo-repository |
missing-config |
error |
Agent Standards (CLAUDE.md / AGENTS.md / copilot-setup-steps.yml) (4 finding(s))
Remediation: per-repo doc and workflow additions
Affected repos: demo-repository
| Repo | Check | Severity |
|---|---|---|
demo-repository |
missing-claude-md |
error |
demo-repository |
missing-agents-md |
error |
demo-repository |
missing-copilot-setup-steps |
warning |
demo-repository |
missing-copilot-instructions |
error |
Generated by the weekly compliance audit on 2026-08-07 13:28 UTC.
Address each remediation category as a single coordinated PR to avoid duplicate agent work.
Activity
don-petry commentedon Aug 12, 2026
Dev-Lead: Scope Analysis — no in-repo code change applies
I picked this issue up as a code-implementing dev-lead and worked through Phase 1 (scope). Reporting the finding before touching any files, because none of the 65 findings map to a source change in
petry-projects/.githubitself.Why
apply-rulesets.sh(admin token)standards/rulesets/pr-quality.jsonalready carries both drifted keys (dismiss_stale_reviews_on_push: true,require_last_push_approval: true). The drift is live-side only.apply-repo-settings.sh(admin API)demo-repositoryapply-repo-settings.sh+ per-repoci.yml/.gitignorerepo-template,.github-private,markets,demo-repositorydemo-repository); source templates already exist instandards/workflows/demo-repositoryfiles.github/dependabot.ymldemo-repository,repo-template; templates exist instandards/dependabot/demo-repositorydocsEvery remediation is either a live admin-API operation or a file addition to a different repository. The audit (
scripts/compliance-audit.sh:735) treats the codifiedstandards/rulesets/*.jsonas the source of truth, and it is already correct.standards/ruleset-remediation-runbook.mdexplicitly notes ruleset changes are not auto-remediated — they require an admin token the CIGITHUB_TOKENdoes not carry.Correct remediation (operator with admin token)
Recommendation
This umbrella was routed to a code-implementing dev-lead, but it is an operational, multi-repo task. There is no file in this repo I can edit that closes any finding — the standards that source the remediations are already present and correct. I am not fabricating an in-repo PR (e.g., copying
demo-repository's files into this standards repo), as that would pollutestandards/without remediating anything live.Closing my run with no file changes. Suggest routing to an operator/admin-token workflow, or splitting per-repo file additions (
demo-repository,repo-template) into their own repo-scoped issues.don-petry commentedon Aug 12, 2026
Dev-Lead Implementation Plan
Issue: #958 — Compliance audit — 2026-08-07
Scope
This PR closes the only change actionable inside
petry-projects/.githubitself:lock the codified
pr-qualityruleset'sdismiss_stale_reviews_on_pushparameterwith an anti-divergence guard test — the direct companion to #957, which locked
require_last_push_approval.Why the other 63 findings are out of scope for this PR:
standards/github-settings.md),.githubowns policy; it cannot edit files in other repos (
markets,demo-repository,broodly, …). Those per-repo workflow/settings/dependabot findings are fixed byPRs in each target repo, not here.
ruleset-drift-*findings are live drift between each repo's GitHub-sideruleset and the codified source of truth. The canonical
standards/rulesets/pr-quality.jsonalready setsdismiss_stale_reviews_on_push: trueand
require_last_push_approval: true. Converging the live rulesets is a manual,admin-token operation (
apply-rulesets.sh, per the Ruleset Remediation Runbook) —not a code change, and explicitly skipped by
compliance-remediate.sh.ruleset-drift-pr-quality-<param>finding is theguard test that prevents the codified source of truth from silently regressing, so
the applier can never push a drifted value fleet-wide. Compliance: ruleset-drift-pr-quality-require_last_push_approval #957 established this pattern.
Implementation Checklist
test/scripts/apply-rulesets/apply-rulesets.bats— add adismiss_stale_reviews_on_push == trueanti-divergence guard, mirroring the existing
require_last_push_approvalguard (Compliance: ruleset-drift-pr-quality-require_last_push_approval #957)Tests to Write
pr-quality.json: dismisses stale reviews on push (dismiss_stale_reviews_on_push == true)— proven red by temporarily flipping the codified value to
false, then green once restoredTest Command
./node_modules/.bin/bats test/scripts/apply-rulesets/apply-rulesets.batsdon-petry commentedon Aug 12, 2026
Dev-Lead: Implementation Complete
Plan Execution
dismiss_stale_reviews_on_push == trueanti-divergence guard totest/scripts/apply-rulesets/apply-rulesets.bats, mirroring the Compliance: ruleset-drift-pr-quality-require_last_push_approval #957require_last_push_approvalguardfalse→ test failed), then restored the source of truthdev-lead-lint.shgreenScope note
This is the only change actionable inside
petry-projects/.githubfor issue #958.The
.githubrepo owns policy but cannot edit other repos (#576), andruleset-drift-*findings are live drift converged by the manual
apply-rulesets.shadmin procedure —not a code change.
standards/rulesets/pr-quality.jsonalready codifiesdismiss_stale_reviews_on_push: true; the in-repo deliverable is the guard that stops thecodified source of truth from silently regressing (same pattern #957 set for
require_last_push_approval). The remaining 63 umbrella findings belong to per-repo PRs.Test Results
Files Changed
test/scripts/apply-rulesets/apply-rulesets.bats: added one anti-divergence guard test asserting the codifiedpr-qualityruleset keepsdismiss_stale_reviews_on_push == trueNotes
Phase 2 TDD note: the codified JSON already satisfies the invariant, so "red" was
demonstrated by temporarily flipping the value to
falseand confirming the new guardfails, then restoring it. No production/source files were modified — the change is a
regression lock only.
don-petry commentedon Aug 12, 2026
Dev-Lead: cannot implement issue #958 — needs human attention
A stage timed out (exit 124) while implementing this issue. A timeout is treated as a first-class, non-retryable condition — retrying with the same budget would just time out again — so this escalates for human review on the first occurrence instead of wasting a same-budget retry.
timeoutThis hit the max action budget. Split this issue into smaller, independently-implementable pieces, or raise
vars.ACTION_TIMEOUT_SEC, then re-apply thedev-leadlabel.don-petry commentedon Aug 12, 2026
Dev-Lead Implementation Plan
Issue: #958 — Compliance audit — 2026-08-07
Scope
Lock the codified
pr-qualityruleset'sdismiss_stale_reviews_on_pushparameter with ananti-divergence guard test — the direct companion to #957, which locked
require_last_push_approval. This is the only change actionable insidepetry-projects/.githubitself for this umbrella.Why the other 63 findings are out of scope for this PR:
standards/github-settings.md):.githubowns policy; itcannot edit files in other repos (
markets,demo-repository,broodly, …). Per-repoworkflow/settings/dependabot/doc findings are fixed by PRs in each target repo.
ruleset-drift-*findings are live drift between each repo's GitHub-side ruleset andthe codified source of truth.
standards/rulesets/pr-quality.jsonalready setsdismiss_stale_reviews_on_push: true(andrequire_last_push_approval: true).Converging live rulesets is a manual, admin-token operation (
apply-rulesets.sh,per the Ruleset Remediation Runbook) — not a code change, and explicitly skipped by
compliance-remediate.sh.ruleset-drift-pr-quality-<param>finding is the guardtest that prevents the codified source of truth from silently regressing. Compliance: ruleset-drift-pr-quality-require_last_push_approval #957 set this
pattern; this PR extends it to the sibling parameter.
Implementation Checklist
test/scripts/apply-rulesets/apply-rulesets.bats— add adismiss_stale_reviews_on_push == trueanti-divergence guard, mirroring the existingrequire_last_push_approvalguard (Compliance: ruleset-drift-pr-quality-require_last_push_approval #957)Tests to Write
pr-quality.json: dismisses stale reviews on push (dismiss_stale_reviews_on_push == true)— proven red by temporarily flipping thecodified value to
false, then green once restoredTest Command
./node_modules/.bin/bats test/scripts/apply-rulesets/apply-rulesets.batsdon-petry commentedon Aug 12, 2026
Dev-Lead: Implementation Complete
Plan Execution
dismiss_stale_reviews_on_push == trueanti-divergence guard totest/scripts/apply-rulesets/apply-rulesets.bats, mirroring the Compliance: ruleset-drift-pr-quality-require_last_push_approval #957require_last_push_approvalguardfalse→ test failed at[ "$output" = "true" ]), then restored the source of truthdev-lead-lint.shall greenScope note
This is the only change actionable inside
petry-projects/.githubfor issue #958.The
.githubrepo owns policy but cannot edit other repos (#576), andruleset-drift-*findings are live drift converged by the manual
apply-rulesets.shadmin procedure —not a code change.
standards/rulesets/pr-quality.jsonalready codifiesdismiss_stale_reviews_on_push: true; the in-repo deliverable is the guard that stops thecodified source of truth from silently regressing (same pattern #957 set for
require_last_push_approval). The remaining per-repo findings (settings, workflows,dependabot, docs, SHA pinning, push-protection) belong to PRs in each target repo.
Test Results
Files Changed
test/scripts/apply-rulesets/apply-rulesets.bats: added one anti-divergence guard test asserting the codifiedpr-qualityruleset keepsdismiss_stale_reviews_on_push == trueNotes
Phase 2 TDD note: the codified JSON already satisfies the invariant, so "red" was
demonstrated by temporarily flipping the value to
falseand confirming the new guardfails, then restoring it. No production/source files were modified — the change is a
regression lock only. Prior attempt on this umbrella timed out (2100s) before pushing;
this run reproduces the minimal in-repo deliverable only, so it stays well within budget.
don-petry commentedon Aug 14, 2026
Resolved! This check is now passing as of 2026-08-14. Closing automatically.
feat: implement issue #958 — Compliance audit — 2026-08-07
feat: implement issue #958 — Compliance audit — 2026-08-07 (#970)