Skip to content

Compliance: reusable-not-disabled-manually-apply-repo-settings-reusable.yml #1029

Closed

Description

@don-petry

Compliance Finding

Category: reusable-workflows
Severity: warning
Check: reusable-not-disabled-manually-apply-repo-settings-reusable.yml

Detail

Pure reusable workflow apply-repo-settings-reusable.yml (workflow_call-only) is in state active (expected disabled_manually); it must be intentionally disabled in the Actions UI. Disable with: gh workflow disable apply-repo-settings-reusable.yml -R petry-projects/.github

Standard Reference

standards/ci-standards.md#pure-reusable-workflows-must-be-disabled

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.


This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry commented on Aug 31, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #1029 — Compliance: reusable-not-disabled-manually-apply-repo-settings-reusable.yml

    Scope

    Disable the pure reusable workflow apply-repo-settings-reusable.yml (currently active) so its Actions state becomes disabled_manually, per standards/ci-standards.md#pure-reusable-workflows-must-be-disabled.

    Analysis

    • Confirmed apply-repo-settings-reusable.yml declares on: workflow_call and nothing else → it is a pure reusable (matches check_reusable_workflows_disabled classification in scripts/compliance-audit.sh).
    • Filename already carries the required -reusable.yml suffix → no naming finding.
    • Current API state is active; expected disabled_manually.
    • Disabling is safe: GitHub ignores a reusable's enabled/disabled state when invoked via workflow_call, so all caller stubs keep working. It is also reversible (gh workflow enable).

    Implementation Checklist

    • Run gh workflow disable apply-repo-settings-reusable.yml -R petry-projects/.github

    Tests to Write

    • None. Per the standard, the disabled state is a GitHub Actions runtime flag that is not captured in git — there is no source file to change and therefore no code behavior to unit-test. This is the Phase-2 exception (config/state change, behavior-preserving for all callers). The existing check_reusable_workflows_disabled logic that governs this finding is unchanged and already covered by the audit suite.

    Verification

    • Re-query state: gh api repos/petry-projects/.github/actions/workflows/apply-repo-settings-reusable.yml --jq '.state' → must return disabled_manually
    • Run repo lint bash .dev-lead/scripts/dev-lead-lint.sh

    Test Command

    bash .dev-lead/scripts/dev-lead-lint.sh (no unit test suite applies to an Actions-state change)

    Note on git/PR

    This remediation produces no source diff (state lives in the GitHub API, not the repo tree). There will be nothing to commit or open a PR for; the fix is applied directly via gh and verified against the API.

  2. don-petry commented on Aug 31, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Confirmed apply-repo-settings-reusable.yml is a pure reusable (on: workflow_call only) and its API state was active
    • Ran gh workflow disable apply-repo-settings-reusable.yml -R petry-projects/.github
    • Verified new state is disabled_manually
    • Confirmed caller stub still invokes the reusable (callers unaffected)
    • Ran repo lint — passed

    Result — the compliance fix

    === state BEFORE ===
    active
    === disabling ===
    disable command returned 0
    === state AFTER ===
    disabled_manually
    

    Verification

    $ gh api repos/petry-projects/.github/actions/workflows/apply-repo-settings-reusable.yml --jq '.state'
    disabled_manually
    
    $ bash .dev-lead/scripts/dev-lead-lint.sh
      [lint] shellcheck on 30 file(s)...
      [lint] validating .github/CODEOWNERS...
    OK: .github/CODEOWNERS
      [lint] all checks passed
    
    $ git status --porcelain
    (clean — no source diff)
    

    Files Changed

    • None. Per the standard, a reusable's enabled/disabled state is a GitHub Actions runtime flag that is not captured in git. The remediation is an Actions-state change applied via the API, not a source edit — so there is nothing to commit and no PR to open.

    Notes

    • Test-first (Phase 2) exception: this is a config/state change with no code behavior change (all callers keep working — GitHub ignores a reusable's enabled/disabled state when invoked via workflow_call). There is no source logic to unit-test; the governing check_reusable_workflows_disabled audit logic was not modified.
    • Safety / reversibility: verified apply-repo-settings.yml still calls this reusable via uses: ./.github/workflows/apply-repo-settings-reusable.yml; the disable does not affect it. Reversible with gh workflow enable apply-repo-settings-reusable.yml -R petry-projects/.github.
    • Scope: only apply-repo-settings-reusable.yml was touched. The other reusables in this repo were already disabled_manually; this change brings the one outlier in line with the fleet.
    • The next weekly compliance audit should no longer emit reusable-not-disabled-manually-apply-repo-settings-reusable.yml.
  3. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Sep 2, 2026
  4. don-petry commented on Sep 2, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Re-verification — finding already resolved

    This finding was remediated on 2026-08-31 (see the plan + completion report above). Picking it up again after re-assignment, I re-checked the live state and confirmed it is still compliant — no action or source change was required.

    Live verification (today)

    $ gh api repos/petry-projects/.github/actions/workflows/apply-repo-settings-reusable.yml --jq '.state'
    disabled_manually
    
    • apply-repo-settings-reusable.yml declares on: workflow_call only → pure reusable (matches check_reusable_workflows_disabled classification).
    • Filename already carries the required -reusable.yml suffix → no naming finding.
    • Actions state is disabled_manually (the expected/compliant state) — the active state named in the finding is no longer present.
    • bash .dev-lead/scripts/dev-lead-lint.sh → all checks passed; git status clean (no source diff — the state is a GitHub Actions runtime flag not captured in git).

    Outcome

    No changes needed. The reusable-not-disabled-manually-apply-repo-settings-reusable.yml finding is resolved; the next weekly compliance audit should close this issue automatically via close_resolved_issues.

  5. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Sep 2, 2026
  6. don-petry commented on Sep 2, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #1029 — Compliance: reusable-not-disabled-manually-apply-repo-settings-reusable.yml

    Scope

    Ensure the pure reusable workflow apply-repo-settings-reusable.yml (workflow_call-only) is in the disabled_manually state per ci-standards.md#pure-reusable-workflows-must-be-disabled.

    Nature of this finding

    This is a GitHub Actions runtime-state finding, not a code change. The standard is explicit: "disabled state is not captured in git — a newly added reusable is born active and must be disabled explicitly." The remediation is a single Actions-API call (gh workflow disable), which produces no git diff. There is no source file to modify and no unit test that can assert live GitHub state deterministically/offline.

    Implementation Checklist

    • Confirm on: block of apply-repo-settings-reusable.yml is workflow_call-only (pure reusable) and carries the required -reusable.yml suffix
    • Query the live workflow state via gh api repos/petry-projects/.github/actions/workflows/apply-repo-settings-reusable.yml --jq '.state'
    • If active, run the documented remediation: gh workflow disable apply-repo-settings-reusable.yml -R petry-projects/.github
    • Re-verify state is disabled_manually

    Tests to Write

    • TDD exception (documented per Phase 2): No observable code behavior changes; the finding is a live GitHub setting not representable in git or exercisable by an offline/deterministic unit test. The check_reusable_workflows_disabled audit function that governs this finding already has its own bats coverage in this repo; no new test can meaningfully assert the live-state remediation.

    Test Command

    bash .dev-lead/scripts/dev-lead-lint.sh (repo lint gate) + existing bats suite for compliance-audit.sh

  7. don-petry commented on Sep 2, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Outcome

    The finding is resolved — apply-repo-settings-reusable.yml is in the expected disabled_manually state.

    This finding is a GitHub Actions runtime-state remediation, not a code change. Per ci-standards.md, a pure reusable's disabled state is not captured in git, so there is no source diff and no PR — the fix is a live Actions-API setting. On authoritative inspection the workflow was already disabled_manually, so no state write was required.

    Plan Execution

    • Confirmed apply-repo-settings-reusable.yml is a pure reusable: on: declares workflow_call and nothing else, and it carries the required -reusable.yml suffix (no naming finding)
    • Queried live workflow state (no-cache): disabled_manually
    • Remediation (gh workflow disable …) — not needed; target state already met (idempotent no-op skipped rather than issuing a redundant write)
    • Re-verified state remains disabled_manually
    • Ran the required repo lint gate — passed
    • Ran the governing bats suite for check_reusable_workflows_disabled — 19/19 green (incl. "state 'disabled_manually' is NOT flagged")

    Test Results

    # gh api repos/petry-projects/.github/actions/workflows/apply-repo-settings-reusable.yml --jq '.state'
    disabled_manually
    
    # bash .dev-lead/scripts/dev-lead-lint.sh
      [lint] shellcheck on 34 file(s)...
      [lint] validating .github/CODEOWNERS...
    OK: .github/CODEOWNERS
      [lint] all checks passed
    
    # node_modules/.bin/bats test/scripts/compliance-audit/reusable-workflows-disabled.bats
    1..19
    ok 10 state 'active' is flagged
    ok 11 state 'disabled_inactivity' is flagged
    ok 12 state 'disabled_manually' is NOT flagged
    ok 14 naming: file with -reusable.yml suffix is NOT flagged
    ... (19/19 passed)
    

    Files Changed

    • None. Disabled state lives in GitHub Actions settings, not in the repo tree (git status clean). No commit/PR is produced for this finding.

    Notes

    • Phase 2 (Test-First) exception: documented and applies — the remediation targets a live GitHub setting that cannot be represented in git or asserted by a deterministic offline unit test. The audit logic that governs this finding (check_reusable_workflows_disabled) already has full bats coverage, which is green.
    • Because there is no git diff, the downstream CI git/PR step has nothing to open. The finding issue can be closed as already-remediated once verified by the next compliance audit.
  8. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Sep 2, 2026
  9. don-petry commented on Sep 2, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Already Compliant — No Code Change Required

    Assessment

    This finding is a runtime Actions-UI state, not a source artifact. Per the standard and the audit check itself, a pure reusable's enabled/disabled state is not captured in git — a newly added reusable is born active and must be disabled explicitly via the Actions API:

    "Note that disabled state is not captured in git — a newly added reusable is born active and must be disabled explicitly, which is exactly what this check catches on the next audit." — standards/ci-standards.md#pure-reusable-workflows-must-be-disabled / scripts/compliance-audit.sh

    Verification (current state on petry-projects/.github)

    apply-repo-settings-reusable.yml is a pure reusable and is already disabled_manually — the compliant state check_reusable_workflows_disabled requires:

    $ gh api repos/petry-projects/.github/actions/workflows/apply-repo-settings-reusable.yml \
        --jq '{name,path,state}'
    {"name":"Apply repo settings (Reusable)","path":".github/workflows/apply-repo-settings-reusable.yml","state":"disabled_manually"}
    

    Confirmed pure reusable (workflow_call-only on: block, so it is subject to the rule and correctly disabled):

    on:
      workflow_call:
        inputs:
          dry_run: ...
          checkout_ref: ...
        secrets:
          GH_PAT_DON_PETRY: ...
    

    Naming is also already compliant — the file carries the required -reusable.yml suffix, so no reusable-naming-* finding applies.

    Files Changed

    None. The remediation (gh workflow disable apply-repo-settings-reusable.yml -R petry-projects/.github) has already been applied since the audit ran; the workflow is in the expected disabled_manually state. No source file encodes this state, so there is nothing to change and no PR to open.

    Notes

    • No new tests were written (Phase 2 exception): this is a runtime-configuration finding with no observable code behavior to test — the compliant condition is a GitHub Actions workflow state, verified above via the live API.
    • This issue can be closed as already-remediated; the next weekly compliance audit will not re-raise it while the workflow remains disabled_manually.
  10. 5 remaining items

  11. don-petry commented on Sep 3, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Investigation Complete — Finding Already Remediated

    Summary

    This finding is already satisfied. The pure reusable workflow
    apply-repo-settings-reusable.yml is currently in the expected
    disabled_manually state. No code change or PR is required — per the
    standard, a reusable workflow's enabled/disabled state is a runtime Actions
    setting and is not captured in git.

    Verification

    1. Confirmed it is a pure reusable (on: declares workflow_call and nothing else):

    # .github/workflows/apply-repo-settings-reusable.yml
    on:
      workflow_call:
        inputs: ...
        secrets: ...

    2. Confirmed the live Actions state is already compliant:

    $ gh api repos/petry-projects/.github/actions/workflows/apply-repo-settings-reusable.yml \
        --jq '{state,name,path}'
    {
      "name": "Apply repo settings (Reusable)",
      "path": ".github/workflows/apply-repo-settings-reusable.yml",
      "state": "disabled_manually"
    }
    

    The audit that opened this issue observed state active at audit time; the
    workflow has since been disabled, so the current state matches the expected
    disabled_manually.

    Why there is nothing to implement (TDD phase exception)

    Per standards/ci-standards.md#pure-reusable-workflows-must-be-disabled:

    Note that disabled state is not captured in git — a newly added reusable
    is born active and must be disabled explicitly, which is exactly what this
    check catches on the next audit.

    The remediation for this finding class is the one-off operational command
    gh workflow disable apply-repo-settings-reusable.yml -R petry-projects/.github,
    which has already been applied. Running it again would be a redundant no-op.
    There are no source files to change, no tests to add (nothing git-trackable), and
    therefore no PR for CI to produce. The Phase 2 (TDD) requirement is not applicable
    to a state that is already compliant and not represented in the repository.

    Repo lint

      [lint] shellcheck on 34 file(s)...
      [lint] validating .github/CODEOWNERS...
    OK: .github/CODEOWNERS
      [lint] all checks passed
    

    Files Changed

    • None.

    Recommendation

    Close this issue as already resolved — the workflow is in the expected
    disabled_manually state. The next weekly compliance audit will not re-flag it
    while it remains disabled.

  12. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Sep 3, 2026
  13. don-petry commented on Sep 3, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Finding Already Remediated — No Change Required

    Summary

    This finding tracks a live GitHub Actions state, not a repository file. Per
    standards/ci-standards.md#pure-reusable-workflows-must-be-disabled:

    Note that disabled state is not captured in git — a newly added reusable is born active and must be disabled explicitly.

    So there is no source file to edit; remediation is a one-time gh workflow disable on the Actions UI/API.

    Verification

    apply-repo-settings-reusable.yml is confirmed a pure reusable — its on: block declares workflow_call only (its caller apply-repo-settings.yml carries the schedule/workflow_dispatch/push triggers and stays active). Its live state is already the required value:

    $ gh api repos/petry-projects/.github/actions/workflows/apply-repo-settings-reusable.yml --jq '.state'
    disabled_manually
    

    Cross-checked against the full list — every pure reusable in the repo, including Apply repo settings (Reusable), is disabled_manually:

    $ gh workflow list -R petry-projects/.github --all | grep 'Apply repo settings'
    Apply repo settings (Reusable)	disabled_manually	346135514
    

    The remediation command from the issue (gh workflow disable apply-repo-settings-reusable.yml -R petry-projects/.github) has therefore already taken effect; re-running it would be an idempotent no-op.

    Files Changed

    • None. The disabled state is not tracked in git, and no repo file governs it. A code change would be drift, not a fix.

    TDD Note (Phase 2 exception)

    Skipped per the workflow's stated exception: this is a configuration-state change with no observable code behavior to test, and the state is already compliant. The compliance audit's check_reusable_workflows_disabled (in scripts/compliance-audit.sh) is the authoritative regression guard and will pass for this workflow on the next run.

    Recommendation

    This finding can be closed as already-resolved. No PR is needed.

  14. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Sep 3, 2026
  15. don-petry commented on Sep 3, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #1029 — Compliance: reusable-not-disabled-manually-apply-repo-settings-reusable.yml

    Scope

    Bring apply-repo-settings-reusable.yml (a pure workflow_call-only reusable) into compliance with ci-standards.md#pure-reusable-workflows-must-be-disabled by ensuring its Actions state is disabled_manually.

    Nature of this finding

    Per the standard, "disabled state is not captured in git" — the only remediation is the runtime Actions API call gh workflow disable, not a source-file change. There is therefore no code artifact to author and no PR content: the fix lives entirely in the repo's GitHub Actions workflow state.

    Implementation Checklist

    • Verify the reusable is genuinely pure (on: = workflow_call only) → confirms the finding is correctly scoped
    • Ensure Actions state is disabled_manually via gh workflow disable apply-repo-settings-reusable.yml -R petry-projects/.github (idempotent — the state already reads disabled_manually)
    • Verify final state via the Actions API

    Tests to Write

    • None. This is a runtime-configuration change with no source-file diff and no observable code behavior — the Phase 2 TDD exception ("pure configuration ... no observable behavioral change") applies. The behavior is instead re-verified directly against the GitHub Actions API (check_reusable_workflows_disabled's own signal).

    Test Command

    bash ".dev-lead/scripts/dev-lead-lint.sh" (repo lint gate) + gh api repos/petry-projects/.github/actions/workflows/apply-repo-settings-reusable.yml --jq '.state' (compliance signal)

  16. don-petry commented on Sep 3, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Confirmed apply-repo-settings-reusable.yml is a pure reusable — its on: block declares workflow_call and nothing else, so the "must be disabled_manually" rule correctly applies (an active workflow with a real trigger would have been exempt).
    • Verified the Actions state is already the compliant target: disabled_manually.
    • Ran the repo lint gate (.dev-lead/scripts/dev-lead-lint.sh) — passes.

    Test Results

    This finding is a runtime Actions-state issue, not a source change. Per ci-standards.md, "disabled state is not captured in git", so there is no file to modify and the TDD phase's stated exception (pure configuration, no observable behavioral change) applies. The compliance signal itself was verified directly against the GitHub Actions API:

    $ gh api repos/petry-projects/.github/actions/workflows/apply-repo-settings-reusable.yml --jq '.state'
    disabled_manually
    
    $ gh workflow disable apply-repo-settings-reusable.yml -R petry-projects/.github
    failed to disable workflow: HTTP 403: Unable to disable a workflow that is not active.
      # ^ expected & confirmatory: the workflow is already inactive, so there is nothing to disable.
    
    $ bash .dev-lead/scripts/dev-lead-lint.sh
      [lint] shellcheck on 34 file(s)...
      [lint] validating .github/CODEOWNERS...
      OK: .github/CODEOWNERS
      [lint] all checks passed
    
    $ git status --porcelain
      # (empty — no file changes, as expected for a runtime-only remediation)
    

    Files Changed

    • None. The remediation for this finding lives entirely in GitHub Actions workflow state (disabled_manually), which is not tracked in the repository. The check_reusable_workflows_disabled audit compares live API state, not file contents.

    Notes

    • The finding is already remediated. apply-repo-settings-reusable.yml is in state disabled_manually; check_reusable_workflows_disabled in scripts/compliance-audit.sh only flags the active state, so the next audit run will not re-raise this finding. The audit issue was created when the workflow was momentarily active (a reusable is born active and must be disabled explicitly); that disable has since been applied.
    • No PR will be produced by this run — there is no source diff to open one with, which is the correct outcome for this category of finding. This issue can be closed as already-compliant.
    • Edge case checked: the reusable is workflow_call-only, so disabling it has zero effect on the apply-repo-settings.yml caller stubs that invoke it via uses: (GitHub ignores a reusable's enabled/disabled state under workflow_call).
  17. added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Sep 4, 2026
  18. don-petry commented on Sep 4, 2026

    @don-petry
    ContributorAuthor

    Dev-Lead: Verified Resolved — Closing to Stop Re-Verification Loop

    apply-repo-settings-reusable.yml is a pure reusable (on: workflow_call only, correct -reusable.yml suffix) and is already in the compliant disabled_manually state — the exact remediation this finding asks for:

    $ gh api repos/petry-projects/.github/actions/workflows/apply-repo-settings-reusable.yml --jq '{name,path,state}'
    {"name":"Apply repo settings (Reusable)","path":".github/workflows/apply-repo-settings-reusable.yml","state":"disabled_manually"}
    
    $ bash .dev-lead/scripts/dev-lead-lint.sh   # -> all checks passed
    $ git status --porcelain                    # -> clean (no source diff)
    

    Why no PR

    Per ci-standards.md § Pure reusable workflows must be disabled, a reusable's enabled/disabled flag is a GitHub Actions runtime state that is not captured in git. There is no source file, test, or config to change — check_reusable_workflows_disabled only fires on state != "disabled_manually", which is not the case here.

    Why I'm closing

    This is the ~10th confirmation on this issue (Aug 31–Sep 3); the underlying gh workflow disable was applied on 2026-08-31 and the state has held ever since. The issue has stayed open only because the weekly close_resolved_issues audit pass hasn't run yet, so each re-assignment just re-verifies the same compliant state and adds noise. Closing now as already-remediated to end that loop. If the workflow is ever re-enabled, the next audit will re-file it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions