Repository navigation
feat: implement issue #2220 — dev-lead repins its own caller stub to the legacy dev-lead/v1-stable channel to silence template-drift (salvaged checkpoint) - #2238
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This comment has been minimized.
This comment has been minimized.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
CodeAnt Nitpicks1 code suggestion1. When this guard refuses
|
CodeAnt PR Risk: Low Risk
Assessed commit: |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T02:02:02Z. |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
f91667c to
c188161
Compare
Dev-Lead — rebase (applied)Rebase completed and pushed; PR is no longer conflicting. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T02:51:19Z. |
|
No description provided. |
|
No description provided. |
|
This is a rate-limit notice from the bot indicating it has reached its daily quota. No code changes are needed — the bot will resume processing requests after 24 hours. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
No description provided. |
|
Fixed in scripts/dev-lead-fix-reviews.sh: updated the status-4 handler messages for fix-bot-comment and review-changes to include 'channel-pin' guard in the list of possible guard refusals, matching the complete list mentioned in the fix-reviews handler. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T03:20:11Z. |
…nel-pin When fix-bot-comment or review-changes guards refuse due to channel-pin violations, the status-4 handlers now report all possible guard refusals (test tamper/regression, sync-stub, and channel-pin) to match fix-reviews. Previously these handlers were misleading operators by only mentioning test and sync-stub guards, omitting the channel-pin guard that could have triggered the refusal. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
784ae62 to
244b374
Compare
Dev-Lead — rebase (applied)Rebase completed and pushed; PR is no longer conflicting. |
|
No description provided. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T04:54:00Z. |
|
No description provided. |
Test suite newly red — human attention neededThe |
|
dev-lead is withholding action on this item. It is labeled To re-enable automated pickup: remove the |
…ts from #2220 - scripts/dev-lead-fix-ci.sh: resolve lib/dev-lead-pr-body.sh and lib/sync-stub-guard.sh from BASH_SOURCE[0] instead of $0, so the script loads its libs when a bats test sources it (the source guard added for the channel-pin guard tests already assumes this). - tests/dev-lead/unit/test_channel_pin_guard.bats: the idempotency test pinned an out-of-date status list with an ERE that could not match; assert the script's literal list (now including `declined`) with -F. - tests/dev-lead/unit/test_sync_stub_guard_fix_ci.bats: the wiring test pinned the old `$0` form of the sync-stub-guard source line. - scripts/template_stub_drift.sh, tests/template_stub_drift.bats: restored to main. The annotation change moves to issue #2215. Test-Change-Justification: the wiring assertion in test_sync_stub_guard_fix_ci.bats pinned the literal `$(dirname "$0")` source line; it now pins the `${BASH_SOURCE[0]}` form the graphite-app review thread on scripts/dev-lead-fix-ci.sh:20 (PR #2238) asked for. The assertion still checks that fix-ci sources the guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-10-11T15:49:33Z. |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
…ranch added cpg_scan_pass skipped the base-branch exemption when a workflow file had no channel pin at the pre-pass head. A pass that merged or rebased onto a base that had added a channel-pinned workflow (or newly pinned an existing one) was reported as drift, so the push was refused, the PR flagged and auto-merge disabled, although the file carried the base's own pins. Apply the same base comparison on that path. A pin that differs from the base's is still drift. Raised by the graphite-app review thread on scripts/lib/channel-pin-guard.sh (PR #2238). AGENTS.md: the template-drift note said the check's annotations no longer carry a `file=` anchor. That change was dropped from this PR and is tracked in issue #2215, so the note now says the anchor is still there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|



Closes #2220
Provenance: salvaged checkpoint, not a finished pass
dev-lead's run on #2220 (38094945253) hit the 45-minute action budget and escalated. Before stopping it pushed its work as one commit,
ab82dc92("checkpoint(dev-lead): INCOMPLETE — partial work for issue #2220 (stage timeout — unreviewed, do not merge)"). This PR is opened from that branch unchanged, so CI and the normal review passes can finish it in smaller steps. Nothing here has been reviewed yet.What the checkpoint contains
scripts/lib/channel-pin-guard.sh(new): a harness guard that scans a pass's diff and refuses a change to a first-party channel pin on a caller stub (uses:ref oragent_ref), including SHA-pinning or deleting the stub. Restoring the base branch's pin, or adopting a pin the base branch moved to, is allowed.scripts/dev-lead-fix-reviews.sh,scripts/dev-lead-fix-ci.sh: the guard runs before the push for every pushing intent; a refusal stops the pass and escalates..github/workflows/dev-lead-reusable.yml,scripts/dev-lead-fix-ci.sh,prompts/dev-lead/fix-ci.md: a redtemplate-driftcheck is no longer relayed and no longer starts a fix-ci pass on its own.scripts/template_stub_drift.sh: a DRIFTED or MISSING row no longer carries afile=anchor on this repo's stub, and says the drift is inpetry-projects/repo-template.tests/dev-lead/unit/test_channel_pin_guard.bats(new, 351 lines) and additions totests/template_stub_drift.bats.AGENTS.md: the rule in prose.Against the issue's criteria
template-driftis not a fix-ci triggerdev-lead/v1-stablerepin and must be restored separatelyKnown before review
main.scripts/template_stub_drift.shalso changed onmainat 00:22 UTC on 2026-10-11 (fix: template-drift classifies a template ahead of the standards channel as AHEAD, not DRIFTED (#1926) #2219, AHEAD classification), so expect a rebase conflict in that file..github/workflows/dev-lead-reusable.yml(the reusable, +6/−1), which is the intended place for the relay exclusion. It does not touch any caller stub.Related: #2215 (on hold behind this issue; covers what this does not), #2214, #2185, #2212.
🤖 Generated with Claude Code
Problem
See the linked issue.
Risk
Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.
Test plan
Tests added/updated:
tests/dev-lead/unit/test_channel_pin_guard.bats,tests/template_stub_drift.bats. Verification:bash scripts/dev-lead-lint.sh(shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.