Copilot code review says "Approval recommended" but always submits COMMENTED, never APPROVED #206810
Replies: 3 comments 1 reply
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
|
This is most likely expected behavior for the current public preview. “Approval recommended” appears to indicate that Copilot considers the PR ready for approval, but it does not necessarily mean that the review will be submitted with an The settings such as “Count Copilot approvals toward merge requirements” appear to control whether an approval can satisfy branch/merge requirements, rather than forcing Copilot to submit an Since the feature is still in public preview, the For now, I would treat |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
🏷️ Discussion Type
Bug
💬 Feature/Topic Area
Copilot in GitHub
Body
Repo: https://github.com/mlflow/mlflow (public, open source)
This is about Copilot code review can now approve pull
requests
(2026-09-01). The feature is in public preview, so this may just be a preview
gap, but I would like to know whether what we see is expected. Copilot code review runs
on essentially every PR in our repo and the reviews are genuinely useful. It has
never once submitted an approving review, including on PRs where its own
overview comment says it is ready to approve.
Our configuration
All three admin layers are permissive, each deferring to the one below it:
organizations decide.
requests" is toggled ON.
for all files", so this should not be filtering anything out.
So nothing above the repository is saying no, and the repository is saying yes.
What we observe
copilot-pull-request-reviewersubmitted 78 reviews. All 78 are
COMMENTED. Zero areAPPROVED.were still submitted as
COMMENTED.(#25584,
#25578,
#25533), an outside
contributor's PR (#25509), and
Copilot-authored PRs (#25567,
#25544). So this is not
"Copilot will not approve its own work".
as
COMMENTEDin the first place, not approved and later dismissed by a newcommit.
dynamic, pathdynamic/agents/copilot-pull-request-reviewer) logs a detector flag stringthat includes
EnableAutoApproval=trueandInlineApprovalReadinessReasoning=true. Example run:https://github.com/mlflow/mlflow/actions/runs/33862698768
Already ruled out
required_approving_review_countfrom 0 to 1 in ourmasterruleset. Thenext review (#25567) still came
back "Approval recommended" and
COMMENTED.Questions
further prerequisite for Copilot to actually submit an approving review? By
the documented settings this should already be working, which is why I
suspect a bug rather than a misconfiguration on our side.
merge requirements" and the second repository toggle "Allow Copilot approvals
to count toward merge requirements" only govern whether an approval satisfies
merge rules, and cannot cause the review to be submitted as
COMMENTEDinstead of
APPROVED? The naming makes this ambiguous.EnableAutoApproval=truein the Actions run log reflect ourconfiguration, or is it an unrelated internal rollout flag? If it reflects
our config, it and the resulting
COMMENTEDstate contradict each other.included, come from personal forks, and the docs do not mention forks either
way.
All reactions