Cpp linter by ClemensLinnhoff · Pull Request #5 · openMSL/sl-1-2-reflection-based-lidar-object-model

ClemensLinnhoff · 2023-01-23T10:01:11Z

No description provided.

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>

…-tidy Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

…nput file for OSI Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

github-actions · 2023-02-11T20:46:18Z

📜 Run `clang-format` on the following files

src/model/strategies/binary-sensordata-output-strategy/src/OSIBinSensorDataOutput.cpp
src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp

💬 Output from `clang-tidy`

src/model/include/strategy.hpp

/src/model/include/strategy.hpp:22:7: warning: [cppcoreguidelines-special-member-functions]

class 'Strategy' defines a default destructor, a copy constructor and a copy assignment operator but does not define a move constructor or a move assignment operator

class Strategy
      ^

/src/model/include/strategy.hpp:36:20: warning: [cppcoreguidelines-non-private-member-variables-in-classes]

member variable 'profile' has protected visibility

    const Profile& profile;
                   ^

/src/model/include/strategy.hpp:37:16: warning: [cppcoreguidelines-non-private-member-variables-in-classes]

member variable 'log' has protected visibility

    const Log& log;
               ^

/src/model/include/strategy.hpp:38:18: warning: [cppcoreguidelines-non-private-member-variables-in-classes]

member variable 'alert' has protected visibility

    const Alert& alert;
                 ^

src/model/profiles/profile_list.hpp

/src/model/profiles/profile_list.hpp:20:6: error: [clang-diagnostic-error]

use of undeclared identifier 'CFrameworkPackaging'

bool CFrameworkPackaging::try_load_profile(const std::string& name)
     ^

src/model/strategies/binary-sensordata-output-strategy/src/OSIBinSensorDataOutput.cpp

/src/model/strategies/binary-sensordata-output-strategy/src/OSIBinSensorDataOutput.cpp:49:5: warning: [cppcoreguidelines-avoid-c-arrays]

do not declare C-style arrays, use std::array<> instead

    char character[4];
    ^

/src/model/strategies/binary-sensordata-output-strategy/src/OSIBinSensorDataOutput.cpp:50:12: warning: [cppcoreguidelines-pro-bounds-array-to-pointer-decay]

do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead

    memcpy(character, (char*)&message_size, sizeof(MessageSizeT));
           ^

/src/model/strategies/binary-sensordata-output-strategy/src/OSIBinSensorDataOutput.cpp:50:23: warning: [cppcoreguidelines-pro-type-cstyle-cast]

do not use C-style cast to convert between unrelated types

    memcpy(character, (char*)&message_size, sizeof(MessageSizeT));
                      ^

/src/model/strategies/binary-sensordata-output-strategy/src/OSIBinSensorDataOutput.cpp:59:44: warning: [cppcoreguidelines-narrowing-conversions]

narrowing conversion from 'std::basic_string::size_type' (aka 'unsigned long') to signed type 'std::streamsize' (aka 'long') is implementation-defined

    bin_file.write(osi_msg_string.c_str(), osi_msg_string.length());
                                           ^

src/model/strategies/binary-sensorview-output-strategy/src/OSIBinSensorViewOutput.cpp

/src/model/strategies/binary-sensorview-output-strategy/src/OSIBinSensorViewOutput.cpp:54:5: warning: [cppcoreguidelines-avoid-c-arrays]

do not declare C-style arrays, use std::array<> instead

    char character[4];
    ^

/src/model/strategies/binary-sensorview-output-strategy/src/OSIBinSensorViewOutput.cpp:55:12: warning: [cppcoreguidelines-pro-bounds-array-to-pointer-decay]

do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead

    memcpy(character, (char*)&message_size, sizeof(MessageSizeT));
           ^

/src/model/strategies/binary-sensorview-output-strategy/src/OSIBinSensorViewOutput.cpp:55:23: warning: [cppcoreguidelines-pro-type-cstyle-cast]

do not use C-style cast to convert between unrelated types

    memcpy(character, (char*)&message_size, sizeof(MessageSizeT));
                      ^

/src/model/strategies/binary-sensorview-output-strategy/src/OSIBinSensorViewOutput.cpp:64:44: warning: [cppcoreguidelines-narrowing-conversions]

narrowing conversion from 'std::basic_string::size_type' (aka 'unsigned long') to signed type 'std::streamsize' (aka 'long') is implementation-defined

    bin_file.write(osi_msg_string.c_str(), osi_msg_string.length());
                                           ^

src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp

/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:29:34: warning: [readability-function-cognitive-complexity]

function 'apply' has cognitive complexity of 37 (threshold 25)

void model::CsvOutputDetections::apply(SensorData& sensor_data)
                                 ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:33:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if ((sensor_data.sensor_view_size() == 0) || (!sensor_data.has_feature_data()))
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:33:47: note: +1
    if ((sensor_data.sensor_view_size() == 0) || (!sensor_data.has_feature_data()))
                                              ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:39:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if (!sensor_data.sensor_view(0).has_global_ground_truth())
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:49:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if (!sensor_data.sensor_view(0).lidar_sensor_view().empty())
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:51:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if (first_call && (!sensor_data.feature_data().lidar_sensor(0).detection().empty()))
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:51:24: note: +1
        if (first_call && (!sensor_data.feature_data().lidar_sensor(0).detection().empty()))
                       ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:57:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        for (int sensor_idx = 0; sensor_idx < sensor_data.sensor_view(0).lidar_sensor_view_size(); sensor_idx++)
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:59:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (!sensor_data.feature_data().lidar_sensor(sensor_idx).detection().empty())
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:63:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                for (const auto& detection : sensor_data.feature_data().lidar_sensor(sensor_idx).detection())
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:66:21: note: +5, including nesting penalty of 4, nesting level increased to 5
                    if (detection.has_intensity())
                    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:76:26: note: +1, nesting level increased to 5
                    else if (detection.has_echo_pulse_width())
                         ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:91:10: note: +1, nesting level increased to 1
    else if (!sensor_data.sensor_view(0).radar_sensor_view().empty())
         ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:93:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if (first_call && (!sensor_data.feature_data().radar_sensor(0).detection().empty()))
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:93:24: note: +1
        if (first_call && (!sensor_data.feature_data().radar_sensor(0).detection().empty()))
                       ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:99:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        for (int sensor_idx = 0; sensor_idx < sensor_data.sensor_view(0).radar_sensor_view_size(); sensor_idx++)
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:101:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (!sensor_data.feature_data().radar_sensor(sensor_idx).detection().empty())
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:105:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                for (const auto& detection : sensor_data.feature_data().radar_sensor(sensor_idx).detection())
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:117:13: note: +1, nesting level increased to 3
            else
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:123:5: note: +1, nesting level increased to 1
    else
    ^

/src/model/strategies/csv-output-detections-strategy/src/CsvOutputDetections.cpp:95:13: warning: [readability-duplicate-include]

duplicate include

            #include <csvoutputdetections/set_csv_file_path_detections.cpp>
~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/model/strategies/lidar-detection-sensing-strategy/include/detectionsensing/DetectionSensing.hpp

/src/model/strategies/lidar-detection-sensing-strategy/include/detectionsensing/DetectionSensing.hpp:26:15: warning: [readability-identifier-naming]

invalid case style for public member 'signal_strength_in_mW'

        float signal_strength_in_mW = 0.0;
              ^~~~~~~~~~~~~~~~~~~~~
              signal_strength_in_m_w

/src/model/strategies/lidar-detection-sensing-strategy/include/detectionsensing/DetectionSensing.hpp:31:15: warning: [readability-identifier-naming]

invalid case style for public member 'signal_strength_in_mW'

        float signal_strength_in_mW = 0.0;
              ^~~~~~~~~~~~~~~~~~~~~
              signal_strength_in_m_w

/src/model/strategies/lidar-detection-sensing-strategy/include/detectionsensing/DetectionSensing.hpp:36:15: warning: [readability-identifier-naming]

invalid case style for public member 'signal_strength_in_dBm'

        float signal_strength_in_dBm = 0.0;
              ^~~~~~~~~~~~~~~~~~~~~~
              signal_strength_in_d_bm

/src/model/strategies/lidar-detection-sensing-strategy/include/detectionsensing/DetectionSensing.hpp:41:15: warning: [readability-identifier-naming]

invalid case style for public member 'signal_strength_in_dBm'

        float signal_strength_in_dBm = 0.0;
              ^~~~~~~~~~~~~~~~~~~~~~
              signal_strength_in_d_bm

src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp

/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:124:22: warning: [readability-identifier-naming]

invalid case style for local variable 'signal_strength_in_dBm'

                auto signal_strength_in_dBm = rendering_result.received_signal().signal_strength();
                     ^~~~~~~~~~~~~~~~~~~~~~
                     signal_strength_in_d_bm

/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:176:24: warning: [readability-function-cognitive-complexity]

function 'process_collected_beam_cells' has cognitive complexity of 52 (threshold 25)

void DetectionSensing::process_collected_beam_cells(LidarDetectionData* current_sensor,
                       ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:187:15: note: nesting level increased to 1
              [](const DetectionSensing::LidarBeamCellmW& first, const DetectionSensing::LidarBeamCellmW& second) { return first.dist_cell_idx < second.dist_cell_idx; });
              ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:195:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    for (auto& lidar_cuboid_cell_of_beam : lidar_cuboid_cells_of_beam)
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:197:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if (lidar_cuboid_cell_of_beam.dist_cell_idx == summed_dist_cell_of_beam.dist_cell_idx)
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:201:9: note: +1, nesting level increased to 2
        else
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:210:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if (!thresholded_summed_dist_cells.empty())
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:227:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        for (size_t thresholded_summed_dist_cell_dB_idx = 1; thresholded_summed_dist_cell_dB_idx < thresholded_summed_dist_cells.size(); thresholded_summed_dist_cell_dB_idx++)
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:230:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if ((float)thresholded_summed_dist_cells[thresholded_summed_dist_cell_dB_idx].dist_cell_idx >
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:236:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                if (no_of_peaks_in_beam > profile.detection_sensing_parameters.max_echos_per_beam)
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:252:13: note: +1, nesting level increased to 3
            else
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:258:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                if (thresholded_summed_dist_cells[thresholded_summed_dist_cell_dB_idx].signal_strength_in_dBm > peaks_in_beam[no_of_peaks_in_beam - 1].signal_strength_in_dBm)
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:269:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        for (auto& current_peak : peaks_in_beam)
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:275:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (profile.detection_sensing_parameters.echo_determination_mode == "peak")
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:279:13: note: +1, nesting level increased to 3
            else
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:287:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if ((profile.vertical_angle_clamping != "center") && (profile.beam_step_elevation > 0))
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:287:63: note: +1
            if ((profile.vertical_angle_clamping != "center") && (profile.beam_step_elevation > 0))
                                                              ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:289:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                if (profile.vertical_angle_clamping == "max_abs")
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:294:22: note: +1, nesting level increased to 4
                else if (profile.vertical_angle_clamping == "top")
                     ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:298:22: note: +1, nesting level increased to 4
                else if (profile.vertical_angle_clamping == "bottom")
                     ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:305:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (profile.detection_sensing_parameters.distance_stddev > 0.0)
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:321:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (profile.detection_sensing_parameters.intensity_or_epw == 0)
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:324:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                if (profile.detection_sensing_parameters.range_compensate_intensity)
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:335:17: note: +1, nesting level increased to 4
                else
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:358:13: note: +1, nesting level increased to 3
            else
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:373:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                while ((count < signal_strength_to_epw.size() - 1) &&
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:373:68: note: +1
                while ((count < signal_strength_to_epw.size() - 1) &&
                                                                   ^

/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:227:21: warning: [readability-identifier-naming]

invalid case style for local variable 'thresholded_summed_dist_cell_dB_idx'

        for (size_t thresholded_summed_dist_cell_dB_idx = 1; thresholded_summed_dist_cell_dB_idx < thresholded_summed_dist_cells.size(); thresholded_summed_dist_cell_dB_idx++)
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                    thresholded_summed_dist_cell_d_b_idx     thresholded_summed_dist_cell_d_b_idx                                        thresholded_summed_dist_cell_d_b_idx

/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:326:28: warning: [readability-identifier-naming]

invalid case style for local variable 'signal_strength_in_mW'

                    double signal_strength_in_mW = pow(10, current_peak.signal_strength_in_dBm / 10);
                           ^~~~~~~~~~~~~~~~~~~~~
                           signal_strength_in_m_w

/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:327:28: warning: [readability-identifier-naming]

invalid case style for local variable 'signal_strength_in_mW_range_compensated'

                    double signal_strength_in_mW_range_compensated = signal_strength_in_mW * (pow(detection->position().distance(), 2));
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                           signal_strength_in_m_w_range_compensated

/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:329:28: warning: [readability-identifier-naming]

invalid case style for local variable 'emitted_signal_strength_mW'

                    double emitted_signal_strength_mW = pow(10.0, profile.max_emitted_signal_strength_in_dBm / 10.0);
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~
                           emitted_signal_strength_m_w

/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:393:10: warning: [readability-identifier-naming]

invalid case style for local variable 'summed_signal_strength_in_dBm'

    auto summed_signal_strength_in_dBm = 10 * std::log10(summed_dist_cell_of_beam_ptr->signal_strength_in_mW);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         summed_signal_strength_in_d_bm

/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:401:20: warning: [readability-identifier-naming]

invalid case style for local variable 'threshold_mW'

            double threshold_mW = pow(10.0, threshold / 10.0) * pow(thres_distance_m, 2) / pow(range, 2);
                   ^~~~~~~~~~~~
                   threshold_m_w

/src/model/strategies/lidar-detection-sensing-strategy/src/DetectionSensing.cpp:408:26: warning: [readability-identifier-naming]

invalid case style for local variable 'thresholded_summed_dist_cell_dBm'

        LidarBeamCelldBm thresholded_summed_dist_cell_dBm;
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                         thresholded_summed_dist_cell_d_bm

src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp

/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:69:37: warning: [readability-function-cognitive-complexity]

function 'add_hydrometeor_detections' has cognitive complexity of 38 (threshold 25)

void DetectionEnvironmentalEffects::add_hydrometeor_detections(osi3::SensorData& sensor_data, osi3::LidarDetectionData* current_sensor, int sensor_idx, const TF::EgoData& ego_data)
                                    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:72:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if (!weather_sequence.empty())
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:80:10: note: +1, nesting level increased to 1
    else if (sensor_data.sensor_view(0).global_ground_truth().has_environmental_conditions() &&
         ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:81:110: note: +1
             sensor_data.sensor_view(0).global_ground_truth().environmental_conditions().has_precipitation() &&
                                                                                                             ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:88:10: note: +1, nesting level increased to 1
    else if (sensor_data.sensor_view(0).global_ground_truth().has_environmental_conditions() &&
         ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:89:100: note: +1
             sensor_data.sensor_view(0).global_ground_truth().environmental_conditions().has_fog() &&
                                                                                                   ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:97:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if (((is_rain || is_snow) && weather_intensity > 0) || (is_fog && weather_intensity < 10000))
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:97:57: note: +1
    if (((is_rain || is_snow) && weather_intensity > 0) || (is_fog && weather_intensity < 10000))
                                                        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:97:31: note: +1
    if (((is_rain || is_snow) && weather_intensity > 0) || (is_fog && weather_intensity < 10000))
                              ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:97:19: note: +1
    if (((is_rain || is_snow) && weather_intensity > 0) || (is_fog && weather_intensity < 10000))
                  ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:97:68: note: +1
    if (((is_rain || is_snow) && weather_intensity > 0) || (is_fog && weather_intensity < 10000))
                                                                   ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:104:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if (is_rain)
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:108:14: note: +1, nesting level increased to 2
        else if (is_snow)
             ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:112:14: note: +1, nesting level increased to 2
        else if (is_fog)
             ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:117:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        for (const auto& lidar_sensor_view : sensor_data.sensor_view(0).lidar_sensor_view())
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:123:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            for (int emitted_signal_idx = 0; emitted_signal_idx < current_lidar_sensor_view_config.emitted_signal_size(); emitted_signal_idx++)
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:126:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                if (existing_detection_idx.at(emitted_signal_idx) != -1)
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:130:17: note: +1, nesting level increased to 4
                else
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:141:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                if (random_var > (1 - (atm_detection_probability * profile.det_envir_effects.layer_comp_factors.at(layer_idx))))
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:157:21: note: +5, including nesting penalty of 4, nesting level increased to 5
                    if (is_detection_above_ground(sensor_data, position_sensor_coord, ego_data, sensor_idx))
                    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:165:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                if (is_fog)
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:169:22: note: +1, nesting level increased to 4
                else if (is_rain)
                     ^

/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:189:37: warning: [readability-function-cognitive-complexity]

function 'add_spray_detections' has cognitive complexity of 36 (threshold 25)

void DetectionEnvironmentalEffects::add_spray_detections(osi3::SensorData& sensor_data, osi3::LidarDetectionData* current_sensor, int sensor_idx, const TF::EgoData& ego_data)
                                    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:192:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if (water_film_height <= 0.0)
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:223:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    for (int emitted_signal_idx = 0; emitted_signal_idx < current_lidar_sensor_view_config.emitted_signal_size(); emitted_signal_idx++)
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:226:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if (existing_detection_idx.at(emitted_signal_idx) != -1)
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:231:9: note: +1, nesting level increased to 2
        else
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:242:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        for (auto& current_spray_cluster : spray_cluster_global)
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:244:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (current_beam.horizontal_angle() > current_spray_cluster.max_azimuth_rad || current_beam.horizontal_angle() < current_spray_cluster.min_azimuth_rad ||
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:244:164: note: +1
            if (current_beam.horizontal_angle() > current_spray_cluster.max_azimuth_rad || current_beam.horizontal_angle() < current_spray_cluster.min_azimuth_rad ||
                                                                                                                                                                   ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:251:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (cluster_center_sensor_coord.x() + current_spray_cluster.radius > object_min_dimension_in_sensor_coord.x() &&
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:253:123: note: +1
                cluster_center_sensor_coord.y() + current_spray_cluster.radius > object_min_dimension_in_sensor_coord.y() &&
                                                                                                                          ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:261:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (!dist_to_intersect.empty())
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:263:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                if (dist_to_intersect.size() == 2 && *std::min_element(dist_to_intersect.begin(), dist_to_intersect.end()) < max_distance_to_spray_detection)
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:263:51: note: +1
                if (dist_to_intersect.size() == 2 && *std::min_element(dist_to_intersect.begin(), dist_to_intersect.end()) < max_distance_to_spray_detection)
                                                  ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:274:21: note: +5, including nesting penalty of 4, nesting level increased to 5
                    if (random_number > (1.0 - existence_probability))
                    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:287:25: note: +6, including nesting penalty of 5, nesting level increased to 6
                        if (current_distance_to_spray_detection < max_distance_to_spray_detection &&
                        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:287:99: note: +1
                        if (current_distance_to_spray_detection < max_distance_to_spray_detection &&
                                                                                                  ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:306:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    for (int current_cluster_idx : cluster_to_erase)
    ^

/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:347:26: warning: [readability-identifier-naming]

invalid case style for local constant 'Gamma'

            const double Gamma = existing_detection.intensity() / 100.0 * 255.0 / 100.0;
                         ^~~~~
                         gamma

/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:620:37: warning: [readability-function-cognitive-complexity]

function 'add_sun_blinding_detections' has cognitive complexity of 41 (threshold 25)

void DetectionEnvironmentalEffects::add_sun_blinding_detections(SensorData& sensor_data, osi3::LidarDetectionData* current_sensor, const TF::EgoData& ego_data)
                                    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:628:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if (is_sun)
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:637:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if (sun.intensity > 0.0)
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:643:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        for (const auto& lidar_sensor_view : sensor_data.sensor_view(0).lidar_sensor_view())
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:652:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (sun_sensor_coord.azimuth > M_PI)
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:665:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            for (int emitted_signal_idx = 0; emitted_signal_idx < current_lidar_sensor_view_config.emitted_signal_size(); emitted_signal_idx++)
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:670:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                if (current_beam.horizontal_angle() > min_azimuth && current_beam.horizontal_angle() < max_azimuth && current_beam.vertical_angle() > min_elevation &&
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:670:165: note: +1
                if (current_beam.horizontal_angle() > min_azimuth && current_beam.horizontal_angle() < max_azimuth && current_beam.vertical_angle() > min_elevation &&
                                                                                                                                                                    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:679:21: note: +5, including nesting penalty of 4, nesting level increased to 5
                    if (sun.intensity < 30000)
                    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:686:21: note: +5, including nesting penalty of 4, nesting level increased to 5
                    if (random_var > (1 - detection_probability))
                    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:695:25: note: +6, including nesting penalty of 5, nesting level increased to 6
                        if (distance <= 20)
                        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:699:30: note: +1, nesting level increased to 6
                        else if (distance > 20 && distance <= 60)
                             ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:699:48: note: +1
                        else if (distance > 20 && distance <= 60)
                                               ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:703:30: note: +1, nesting level increased to 6
                        else if (distance > 60 && distance <= 80)
                             ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:703:48: note: +1
                        else if (distance > 60 && distance <= 80)
                                               ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:707:25: note: +6, including nesting penalty of 5, nesting level increased to 6
                        if (existing_detection_idx.at(emitted_signal_idx) == -1)
                        ^

/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:758:20: warning: [readability-identifier-naming]

invalid case style for local variable 'emitted_signal_strength_mW'

            double emitted_signal_strength_mW = pow(10.0, profile.max_emitted_signal_strength_in_dBm / 10.0);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~
                   emitted_signal_strength_m_w

/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:760:20: warning: [readability-identifier-naming]

invalid case style for local variable 'attenuated_power_mW'

            double attenuated_power_mW =
                   ^~~~~~~~~~~~~~~~~~~
                   attenuated_power_m_w

/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:766:20: warning: [readability-identifier-naming]

invalid case style for local variable 'attenuated_power_noise_mW'

            double attenuated_power_noise_mW = noise_distribution(generator);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~
                   attenuated_power_noise_m_w

/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:767:20: warning: [readability-identifier-naming]

invalid case style for local variable 'attenuated_power_dBm'

            double attenuated_power_dBm = 10 * log10(attenuated_power_noise_mW);
                   ^~~~~~~~~~~~~~~~~~~~
                   attenuated_power_d_bm

/src/model/strategies/lidar-environmental-effects-strategy/src/DetectionEnvironmentalEffects.cpp:775:28: warning: [readability-identifier-naming]

invalid case style for local variable 'threshold_mW'

                    double threshold_mW = pow(10.0, threshold / 10.0) * pow(thres_distance_m, 2) / pow(range, 2);
                           ^~~~~~~~~~~~
                           threshold_m_w

src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp

/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:24:16: warning: [readability-function-cognitive-complexity]

function 'apply' has cognitive complexity of 51 (threshold 25)

void Tracking::apply(SensorData& sensor_data)
               ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:30:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if ((sensor_data.sensor_view_size() == 0) || !sensor_data.sensor_view(0).has_global_ground_truth() || !sensor_data.sensor_view(0).global_ground_truth().has_timestamp())
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:30:104: note: +1
    if ((sensor_data.sensor_view_size() == 0) || !sensor_data.sensor_view(0).has_global_ground_truth() || !sensor_data.sensor_view(0).global_ground_truth().has_timestamp())
                                                                                                       ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:44:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if (!TF::get_ego_info(ego_data, sensor_data.sensor_view(0)))
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:57:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    for (const MovingObject& current_gt_object : sensor_data.sensor_view(0).global_ground_truth().moving_object())
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:60:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if (!current_gt_object.has_base())
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:68:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if (object_id == ego_data.ego_vehicle_id.value())
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:81:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if (current_gt_object.has_id())
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:86:9: note: +1, nesting level increased to 2
        else
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:96:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if (!data_of_current_time_step.pcl_segment_points_in_ego_coordinates.empty())
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:98:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (profile.tracking_parameters.dimension_and_position_flag > 0)
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:103:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (profile.tracking_parameters.dimension_and_position_flag > 0)
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:107:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (profile.tracking_parameters.velocity_flag > 0)
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:112:9: note: +1, nesting level increased to 2
        else
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:115:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (object_contained_in_history && history.sensor_data.back().moving_object(historical_object_no).has_base())
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:115:45: note: +1
            if (object_contained_in_history && history.sensor_data.back().moving_object(historical_object_no).has_base())
                                            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:117:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                if (profile.tracking_parameters.dimension_and_position_flag > 0)
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:121:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                if (profile.tracking_parameters.dimension_and_position_flag > 0)
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:125:17: note: +4, including nesting penalty of 3, nesting level increased to 4
                if (profile.tracking_parameters.velocity_flag > 0)
                ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:141:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if (object_contained_in_history && history.sensor_data.back().moving_object(historical_object_no).has_base())
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:141:41: note: +1
        if (object_contained_in_history && history.sensor_data.back().moving_object(historical_object_no).has_base())
                                        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:143:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (profile.tracking_parameters.tracking_flag == 0)
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:149:13: note: +1, nesting level increased to 3
            else
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:155:9: note: +1, nesting level increased to 2
        else
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:166:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if (!profile.sensor_view_configuration.radar_sensor_view_configuration().empty())
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:173:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if (!data_of_current_time_step.sensor_data.moving_object().empty())
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:179:5: note: +1, nesting level increased to 1
    else
    ^

/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:559:16: warning: [readability-function-cognitive-complexity]

function 'continue_tracking_for_current_pcl_segment' has cognitive complexity of 26 (threshold 25)

void Tracking::continue_tracking_for_current_pcl_segment(Data& data_of_current_time_step,
               ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:568:5: note: +1, including nesting penalty of 0, nesting level increased to 1
    if (object_tracked_in_history)
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:571:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if (!data_of_current_time_step.pcl_segment_points_in_ego_coordinates.empty())
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:577:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (history.object_was_moving.back()[historical_object_no])
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:581:13: note: +1, nesting level increased to 3
            else
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:586:9: note: +1, nesting level increased to 2
        else
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:593:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (current_moving_object->header().existence_probability() >= profile.tracking_parameters.existence_probability_threshold_for_tracking)
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:600:13: note: +1, nesting level increased to 3
            else
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:608:5: note: +1, nesting level increased to 1
    else
    ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:610:9: note: +2, including nesting penalty of 1, nesting level increased to 2
        if ((data_of_current_time_step.pcl_segment_points_in_ego_coordinates.size() > profile.tracking_parameters.min_detections_in_segment_for_tracking) ||
        ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:610:155: note: +1
        if ((data_of_current_time_step.pcl_segment_points_in_ego_coordinates.size() > profile.tracking_parameters.min_detections_in_segment_for_tracking) ||
                                                                                                                                                          ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:611:87: note: +1
            (!data_of_current_time_step.pcl_segment_points_in_ego_coordinates.empty() && current_absolute_gt_velocity > 0))
                                                                                      ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:613:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (!history.sensor_data.back().moving_object(historical_object_no).header().has_existence_probability())
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:617:13: note: +1, nesting level increased to 3
            else
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:623:13: note: +3, including nesting penalty of 2, nesting level increased to 3
            if (current_moving_object->header().existence_probability() >= profile.tracking_parameters.existence_probability_threshold_for_tracking)
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:628:13: note: +1, nesting level increased to 3
            else
            ^
/home/runner/work/sl-1-2-reflection-based-lidar-object-model/sl-1-2-reflection-based-lidar-object-model/src/model/strategies/lidar-tracking-strategy/src/Tracking.cpp:633:9: note: +1, nesting level increased to 2
        else
        ^

src/model/strategies/ros-output-detectedobjects-strategy/include/ros_detectedobjects/ros_detectedobjects.hpp

/src/model/strategies/ros-output-detectedobjects-strategy/include/ros_detectedobjects/ros_detectedobjects.hpp:13:10: error: [clang-diagnostic-error]

'ros/ros.h' file not found

#include <ros/ros.h>
         ^~~~~~~~~~~

src/model/strategies/ros-output-detectedobjects-strategy/src/ros_detectedobjects.cpp

/src/model/strategies/ros-output-detectedobjects-strategy/src/ros_detectedobjects.cpp:6:10: error: [clang-diagnostic-error]

'ros_detectedobjects/ros_detectedobjects.hpp' file not found

#include "ros_detectedobjects/ros_detectedobjects.hpp"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/model/strategies/ros-output-detections-strategy/include/ros_detections/ros_detections.hpp

/src/model/strategies/ros-output-detections-strategy/include/ros_detections/ros_detections.hpp:13:10: error: [clang-diagnostic-error]

'ros/ros.h' file not found

#include <ros/ros.h>
         ^~~~~~~~~~~

src/model/strategies/ros-output-detections-strategy/src/ros_detections.cpp

/src/model/strategies/ros-output-detections-strategy/src/ros_detections.cpp:6:10: error: [clang-diagnostic-error]

'ros_detections/ros_detections.hpp' file not found

#include "ros_detections/ros_detections.hpp"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/model/strategies/ros-output-gtobjects-strategy/include/ros_gt_objects/ros_gt_objects.hpp

/src/model/strategies/ros-output-gtobjects-strategy/include/ros_gt_objects/ros_gt_objects.hpp:13:10: error: [clang-diagnostic-error]

'ros/ros.h' file not found

#include <ros/ros.h>
         ^~~~~~~~~~~

src/model/strategies/ros-output-gtobjects-strategy/src/ros_gt_objects.cpp

/src/model/strategies/ros-output-gtobjects-strategy/src/ros_gt_objects.cpp:6:10: error: [clang-diagnostic-error]

'ros_gt_objects/ros_gt_objects.hpp' file not found

#include "ros_gt_objects/ros_gt_objects.hpp"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/model/strategies/ros-output-logicaldetections-strategy/include/ros_logicaldetections/ros_logicaldetections.hpp

/src/model/strategies/ros-output-logicaldetections-strategy/include/ros_logicaldetections/ros_logicaldetections.hpp:13:10: error: [clang-diagnostic-error]

'ros/ros.h' file not found

#include <ros/ros.h>
         ^~~~~~~~~~~

src/model/strategies/ros-output-logicaldetections-strategy/src/ros_logicaldetections.cpp

/src/model/strategies/ros-output-logicaldetections-strategy/src/ros_logicaldetections.cpp:6:10: error: [clang-diagnostic-error]

'ros_logicaldetections/ros_logicaldetections.hpp' file not found

#include "ros_logicaldetections/ros_logicaldetections.hpp"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

ClemensLinnhoff · 2023-02-11T20:52:02Z

Remaining clang-tidy annotations from cpp-linter are not relevant.

ClemensLinnhoff and others added 22 commits December 19, 2022 16:52

Added cpp linter workflow

28eaee4

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Simplify clang-format file

0116224

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Added clang-tidy file

900deff

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Removed clang-diagnostic from clang-tidy

285b422

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Use clang-tidy file

79b0b8e

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Disable clang-tidy checks

149b5c8

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Activate Thread comments

0e17be4

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Added pull request master to pipeline trigger

0d1a044

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

More detailed clang format file

8b2e6a3

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>

Remove executing linter on branch

eee095b

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>

Autoformat with clang-format file

f5f237f

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>

Remove clang format in subfolders

9fed536

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>

Added new clang-tidy file and enabled clang-tidy checks in cpp-linter

55e99f1

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>

Add readme badge

4a60331

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>

Merge master

fed602f

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>

Added build step to cpp linter to test using cmake commands for clang…

fd0a927

…-tidy Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Changed workflow branches to main

2633b29

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Added compile command cmake option

49e143e

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Ignore build and protobuf folders

1de0309

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Major refactoring to comply with clang-tidy

830694f

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Further clang-tidy fixes

5bc2b29

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Apply clang-format

454ed4d

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

ClemensLinnhoff mentioned this pull request Feb 3, 2023

'stddef.h' file not found cpp-linter/cpp-linter-action#121

Closed

ClemensLinnhoff added 7 commits February 6, 2023 09:38

clang-tidy fixes

ec0850c

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Specify clang version 14

1937b17

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Update clang-tools to version 15

f81409e

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Change back to version 14, since 15 did not work; Add manual header i…

1958ff3

…nput file for OSI Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

change source file specification

54eafb3

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Remove build from ignore folder

b3550d5

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Another try

b476f80

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

ClemensLinnhoff added 15 commits February 10, 2023 15:50

Added cmake build step

396e53a

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Remove protobuf cache

92c36e9

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Reactivate caching for protobuf

c6aa9ee

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Update proto version

3f6fe7d

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Fix protobuf link

11a454b

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Fix protobuf folder

2eca9ac

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Fix ignore directory

0488b13

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Ignore OSMP folder

1c11df2

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Refactoring to comply with clang-tidy

b47006f

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

clang format

510c9a2

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Last clang tidy fixes

54de4ae

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Change badge links in readme due to model renaming

6d6d1b5

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Fix refactoring bugs

40a36f9

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

clang format

ef5b427

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

Lint only changed files

e865095

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

ClemensLinnhoff requested a review from a team February 11, 2023 18:51

Added output strategies to configs except for ros

848e836

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

ClemensLinnhoff removed the request for review from a team February 11, 2023 20:13

Further clang tidy fixes

016c0c3

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>

ClemensLinnhoff requested a review from a team February 11, 2023 20:52

ClemensLinnhoff added the ready for maintainer review label Feb 11, 2023

jdsika requested review from LukasElster and removed request for LukasElster February 13, 2023 12:17

LukasElster approved these changes Feb 28, 2023

View reviewed changes

ClemensLinnhoff merged commit 487bb07 into main Feb 28, 2023

ClemensLinnhoff deleted the cpp-linter branch February 28, 2023 07:54

Navigation Menu

Repository navigation

Cpp linter - #5

Cpp linter#5
ClemensLinnhoff merged 46 commits into
mainfrom
cpp-linter

ClemensLinnhoff commented Jan 23, 2023

Uh oh!

github-actions Bot commented Feb 11, 2023

Uh oh!

ClemensLinnhoff commented Feb 11, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ClemensLinnhoff commented Jan 23, 2023

Uh oh!

github-actions Bot commented Feb 11, 2023

📜 Run clang-format on the following files

💬 Output from clang-tidy

Uh oh!

ClemensLinnhoff commented Feb 11, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

📜 Run `clang-format` on the following files

💬 Output from `clang-tidy`