From 2ff6d452f548a220d12b388baebe99f79d1f2099 Mon Sep 17 00:00:00 2001 From: Max Date: Mon, 3 Aug 2026 14:36:09 +0200 Subject: [PATCH 1/2] chore(test): direct editing permissions Signed-off-by: Max --- cypress/e2e/directediting.spec.js | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/cypress/e2e/directediting.spec.js b/cypress/e2e/directediting.spec.js index b1bc55e258c..cd5d51713d4 100644 --- a/cypress/e2e/directediting.spec.js +++ b/cypress/e2e/directediting.spec.js @@ -28,6 +28,12 @@ describe('direct editing', function () { initUserAndFiles(user, 'test.md', 'empty.md', 'empty.txt') }) + beforeEach(function() { + // ensure user is enabled if it was disabled before + cy.clearCookies() + cy.enableUser(user, true) + }) + it('Open an existing file, edit it', () => { cy.login(user) cy.createDirectEditingLink('empty.md').then((token) => { @@ -69,4 +75,26 @@ describe('direct editing', function () { '# This is a headline\nSome text\n', ) }) + + it('Cannot open as disabled user', () => { + cy.login(user) + cy.createDirectEditingLink('empty.md').as('token') + cy.clearCookies() + cy.enableUser(user, false) + cy.get('@token') + .then((token) => { cy.request({ url: token, failOnStatusCode: false }) }) + .its('status') + .should('equal', 404) + }) + + it('Cannot open as deleted user', () => { + cy.login(user) + cy.createDirectEditingLink('empty.md').as('token') + cy.clearCookies() + cy.deleteUser(user) + cy.get('@token') + .then((token) => { cy.request({ url: token, failOnStatusCode: false }) }) + .its('status') + .should('equal', 404) + }) }) From e30e09726c58f94c1b5804e12e4bc92099d0fd86 Mon Sep 17 00:00:00 2001 From: silver Date: Wed, 5 Aug 2026 10:28:19 +0200 Subject: [PATCH 2/2] fix(prettier): run prettier fix Signed-off-by: silver --- cypress/e2e/directediting.spec.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/cypress/e2e/directediting.spec.js b/cypress/e2e/directediting.spec.js index cd5d51713d4..d9df954ff5b 100644 --- a/cypress/e2e/directediting.spec.js +++ b/cypress/e2e/directediting.spec.js @@ -28,7 +28,7 @@ describe('direct editing', function () { initUserAndFiles(user, 'test.md', 'empty.md', 'empty.txt') }) - beforeEach(function() { + beforeEach(function () { // ensure user is enabled if it was disabled before cy.clearCookies() cy.enableUser(user, true) @@ -82,7 +82,9 @@ describe('direct editing', function () { cy.clearCookies() cy.enableUser(user, false) cy.get('@token') - .then((token) => { cy.request({ url: token, failOnStatusCode: false }) }) + .then((token) => { + cy.request({ url: token, failOnStatusCode: false }) + }) .its('status') .should('equal', 404) }) @@ -93,7 +95,9 @@ describe('direct editing', function () { cy.clearCookies() cy.deleteUser(user) cy.get('@token') - .then((token) => { cy.request({ url: token, failOnStatusCode: false }) }) + .then((token) => { + cy.request({ url: token, failOnStatusCode: false }) + }) .its('status') .should('equal', 404) })