chore: Update experimental module detection test and pin exact Node versions (#5417)

Author: mark-wiemer

.github/workflows/mocha.yml

@@ -23,8 +23,7 @@ jobs:
   smoke:
     uses: ./.github/workflows/npm-script.yml
     with:
-      # The 22.11.0 is instead of lts per https://github.com/mochajs/mocha/issues/5278
-      node-versions: '18,20,22.11.0,24'
+      node-versions: '18,20,22,24'
       npm-script: test-smoke
 
   test-node-lts:
@@ -66,9 +65,10 @@ jobs:
             coverage: false
     with:
       os: 'ubuntu-latest,windows-latest'
-      # The 20.18.3 is instead of 20 per https://github.com/mochajs/mocha/issues/5052
-      # The 22.11.0 is instead of 22 per https://github.com/mochajs/mocha/issues/5278
-      node-versions: '18,20.18.3,22.11.0,24'
+      # We pin exact versions here per https://github.com/mochajs/mocha/issues/5052
+      # Use 20.18.3 per https://github.com/mochajs/mocha/issues/5278
+      # Ref https://nodejs.org/en/about/previous-releases
+      node-versions: '18.20.8,20.18.3,22.17.1,24.4.1'
       npm-script: test-node:${{ matrix.test-part }}
       coverage: ${{ matrix.coverage }}
 

.github/workflows/npm-script.yml

@@ -54,8 +54,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        # The 22.11.0 is instead of "lts/*" per https://github.com/mochajs/mocha/issues/5278
-        node_version: ${{ fromJson(needs.resolve-inputs.outputs.nodeVersions || '["22.11.0"]') }}
+        node_version: ${{ fromJson(needs.resolve-inputs.outputs.nodeVersions || '["22"]') }}
         os: ${{ fromJson(needs.resolve-inputs.outputs.os || '["ubuntu-latest"]') }}
         browser: ${{ fromJson(needs.resolve-inputs.outputs.browsers || '[""]') }}
     steps:

package-lock.json

@@ -166,6 +166,7 @@
     "rollup-plugin-node-globals": "^1.4.0",
     "rollup-plugin-polyfill-node": "^0.8.0",
     "rollup-plugin-visualizer": "^5.6.0",
+    "semver": "^7.7.2",
     "sinon": "^9.0.3",
     "unexpected": "^11.14.0",
     "unexpected-eventemitter": "^2.2.0",

package.json

@@ -1,6 +1,7 @@
 'use strict';
 
 var invokeMochaAsync = require('../helpers').invokeMochaAsync;
+const semver = require('semver');
 
 /**
  * Extracts root hook log messages from run results
@@ -136,7 +137,25 @@ describe('root hooks', function () {
     });
 
     describe('support ESM via .js extension w/o type=module', function () {
-      describe('should fail due to ambiguous file type', function () {
+      // --(no-)experimental-detect-module was experimental when these tests were written
+      // https://nodejs.org/api/cli.html#--no-experimental-detect-module
+      // https://nodejs.org/api/packages.html#syntax-detection
+      // (introduced in Node 20.10.0, 21.1.0)
+      // newer versions of Node no longer fail :)
+      function isNewerVersion(vString) {
+        // Latest versions considered "older": 18.20.8, 20.18.3, 22.11.0
+        // (May update after writing)
+        return semver.satisfies(vString, '^20.19.0 || ^22.12.0 || ^24.0.0');
+      }
+
+      describe('on older versions, should fail due to ambiguous file type', function () {
+        // --(no-)experimental-detect-module was experimental when these tests were written
+        // (introduced in Node 20.10.0, 21.1.0)
+        // newer versions of Node no longer fail :)
+        if (isNewerVersion(process.versions.node)) {
+          return true; // skip test on newer Node versions
+        }
+
         const filename =
           '../fixtures/plugins/root-hooks/root-hook-defs-esm-broken.fixture.js';
         const noDetectModuleRegex = /SyntaxError: Unexpected token/;
@@ -158,7 +177,8 @@ describe('root hooks', function () {
         });
 
         it('with --experimental-detect-module', function () {
-          // --experimental-detect-module was introduced in Node 21.1.0
+          // --experimental-detect-module was introduced in Node 20.10.0, 21.1.0
+          // adding the flag to older versions of Node does nothing
           const expectedRegex =
             process.version >= 'v21.1.0'
               ? detectModuleRegex
@@ -177,6 +197,47 @@ describe('root hooks', function () {
           );
         });
       });
+
+      describe('on newer versions, should work', function () {
+        if (!isNewerVersion(process.versions.node)) {
+          return true; // skip test on older Node versions
+        }
+
+        const filename =
+          '../fixtures/plugins/root-hooks/root-hook-defs-esm-broken.fixture.js';
+        const runSuccessRegex = /0 passing/;
+
+        it('with --no-experimental-detect-module', function () {
+          return expect(
+            invokeMochaAsync(
+              [
+                '--require=' + require.resolve(filename), // as object
+                '--no-experimental-detect-module'
+              ],
+              'pipe'
+            )[1],
+            'when fulfilled',
+            'to contain output',
+            runSuccessRegex
+          );
+        });
+
+        it('with --experimental-detect-module', function () {
+          return expect(
+            invokeMochaAsync(
+              [
+                '--require=' + require.resolve(filename), // as object
+                 // enabled by default in these newer versions, but clearer to use it explicitly
+                '--experimental-detect-module'
+              ],
+              'pipe'
+            )[1],
+            'when fulfilled',
+            'to contain output',
+            runSuccessRegex
+          );
+        });
+      });
     });
   });