Skip to content

fix(a11y): improve contrast ratio on component style stories - #3421

Merged
Mnickii merged 2 commits into
mainfrom
fix/a11y-3370
Mar 25, 2025
Merged

fix(a11y): improve contrast ratio on component style stories#3421
Mnickii merged 2 commits into
mainfrom
fix/a11y-3370

Conversation

@Mnickii

@Mnickii Mnickii commented Mar 24, 2025

Copy link
Copy Markdown
Collaborator

Closes #3370
Closes #3372

PR Type

Bugfix

Description of the changes

Corrects contrast ratio in elements

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Testing

  1. Open Desktop Accessibility Insights.
  2. Go through the provided link and ensure the mgt-planner custom css properties story and mgt-person More Examples story have the required contrast ratios between the previously flagged elements.

@ElinorW

ElinorW commented Mar 24, 2025

Copy link
Copy Markdown
Contributor

Hey,
still getting a color contrast issue on the planner component
image

@github-actions

Copy link
Copy Markdown

馃摉 The updated storybook is available here

@sonarqubecloud

Copy link
Copy Markdown

@github-project-automation github-project-automation Bot moved this to Done 鉁旓笍 in Graph Toolkit Mar 24, 2025
@Mnickii
Mnickii merged commit b69872a into main Mar 25, 2025
@Mnickii
Mnickii deleted the fix/a11y-3370 branch March 25, 2025 07:49
@github-project-automation github-project-automation Bot moved this from Done 鉁旓笍 to Shipped 馃殌 in Graph Toolkit Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment