Skip to content

fixed file list pagination not working when filtering file extensions - #3414

Merged
Nickii Miaro (Mnickii) merged 2 commits into
microsoftgraph:mainfrom
NextStageAI:fix/mgt-file-list-extension-pagination
Mar 24, 2025
Merged

fixed file list pagination not working when filtering file extensions#3414
Nickii Miaro (Mnickii) merged 2 commits into
microsoftgraph:mainfrom
NextStageAI:fix/mgt-file-list-extension-pagination

Conversation

@andyevers

@andyevers Andrew Evers (andyevers) commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Closes # 3413

PR Type

  • Bugfix

Description of the changes

  • Fixed broken pagination when filtering by extension. This was caused by this._preloadedFiles not being updated after fetching data in mgt-file-list.ts.
  • Additionally, files will now be fetched using the maximum pagination size because the pagination is done on the client side here. after everything is fetched, pagination will use the user-defined page size normally.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Thank you for creating a Pull Request Andrew Evers (@andyevers).

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@andyevers
Andrew Evers (andyevers) marked this pull request as ready for review March 18, 2025 12:29
@andyevers
Andrew Evers (andyevers) requested a review from a team as a code owner March 18, 2025 12:29
@github-project-automation github-project-automation Bot moved this to Done 鉁旓笍 in Graph Toolkit Mar 24, 2025
@Mnickii
Nickii Miaro (Mnickii) merged commit 90b8537 into microsoftgraph:main Mar 24, 2025
@github-project-automation github-project-automation Bot moved this from Done 鉁旓笍 to Shipped 馃殌 in Graph Toolkit Mar 24, 2025
@andyevers
Andrew Evers (andyevers) deleted the fix/mgt-file-list-extension-pagination branch April 2, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG] mgt-file-list pagination not working when using fileExtensions filter

2 participants