Skip to content

fix(a11y): narrate person list position in mgt-agenda - #3221

Merged
Nickii Miaro (Mnickii) merged 11 commits into
mainfrom
fix/bug-3080
Jul 1, 2024
Merged

fix(a11y): narrate person list position in mgt-agenda#3221
Nickii Miaro (Mnickii) merged 11 commits into
mainfrom
fix/bug-3080

Conversation

@Mnickii

@Mnickii Nickii Miaro (Mnickii) commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

Closes #3080

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii
Nickii Miaro (Mnickii) marked this pull request as draft June 14, 2024 09:55
@Mnickii
Nickii Miaro (Mnickii) marked this pull request as ready for review June 18, 2024 15:25
@Mnickii

Copy link
Copy Markdown
Collaborator Author

Raisul123 vagpt this is ready for testing

@musale

Copy link
Copy Markdown
Contributor

Nickii Miaro (@Mnickii) I've tested this, and it doesn't announce the position. It still says "group." Is it supposed to say, "Photo for Adele Vance, position one"?

@Mnickii

Copy link
Copy Markdown
Collaborator Author

Musale Martin (@musale) are you testing the people list? It doesn't say group. Yes, it should announce the position of the person in the list. Try refresh and test it again.

@vagpt

vagpt commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator

Nickii Miaro (@Mnickii)

This issue is still repro'ing on the URL below as SR is still announcing as Group.

URL - https://mgt.dev/next/pr/3221/?path=/docs/components-mgt-agenda--docs

Attachments:

SR.is.still.announcing.as.Group.mp4

@github-actions

Copy link
Copy Markdown

📖 The updated storybook is available here

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
59.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Swastika7

Copy link
Copy Markdown

Nickii Miaro (@Mnickii)
This issue is fixed on URL below , hence we are good to close the bug related to this PR.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[MGTP-Editor-Mgt -agenda -Docs page]: Screen reader is announcing information as ‘Group’ instead ‘Position’ for user profile list items.

5 participants