Skip to content

fix(a11y): correct mgt-get email story - #3194

Merged
Nickii Miaro (Mnickii) merged 2 commits into
mainfrom
fix/bug-3112
May 30, 2024
Merged

fix(a11y): correct mgt-get email story#3194
Nickii Miaro (Mnickii) merged 2 commits into
mainfrom
fix/bug-3112

Conversation

@Mnickii

@Mnickii Nickii Miaro (Mnickii) commented May 29, 2024

Copy link
Copy Markdown
Collaborator

Closes #3112

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Thank you for creating a Pull Request Nickii Miaro (@Mnickii).

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions

Copy link
Copy Markdown

📖 The updated storybook is available here

1 similar comment
@github-actions

Copy link
Copy Markdown

📖 The updated storybook is available here

@Mnickii

Copy link
Copy Markdown
Collaborator Author

vagpt this is ready for review

@github-actions

Copy link
Copy Markdown

📖 The updated storybook is available here

@vagpt

vagpt commented May 30, 2024

Copy link
Copy Markdown
Collaborator

This issue is working fine on the URL below, hence we are good to close the issue related to this PR.

URL - https://mgt.dev/next/pr/3194/?path=/story/components-mgt-get-html--get-email

Attachment:

Issue.is.working.fine.for.Heading.mp4

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 86% 75% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 82% 100% 0
mgt-components.src.components.mgt-person-card 77% 49% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 27% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 91% 73% 0
mgt-element.dist.es6.providers.src.providers 85% 76% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 68% 71% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 84% 100% 0
mgt-element.src.utils 72% 91% 0
Summary 67% (14557 / 21576) 74% (519 / 699) 0

@github-actions

Copy link
Copy Markdown

📖 The updated storybook is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[MGTP-Get-HTML-Get email]: Screen reader announce incorrect information as 'Heading level 4 Microsoft viva group' for 'Microsoft viva button'.

3 participants