feat: Add async hook, plugin, and flag tracker - #463
Merged
Conversation
jsonbailey
force-pushed
the
jb/sdk-2737/async-hooks-plugins-tracker
branch
from
July 21, 2026 20:27
bc1d428 to
f0bd132
Compare
jsonbailey
force-pushed
the
jb/sdk-2737/async-hooks-plugins-tracker
branch
from
July 21, 2026 20:47
f0bd132 to
cc93fc2
Compare
jsonbailey
marked this pull request as ready for review
July 21, 2026 21:19
jsonbailey
force-pushed
the
jb/sdk-2737/async-hooks-plugins-tracker
branch
from
July 21, 2026 21:37
cc93fc2 to
9869242
Compare
keelerm84
approved these changes
Jul 22, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 733132b. Configure here.
jsonbailey
added a commit
that referenced
this pull request
Jul 29, 2026
Adds the full `AsyncConfig` class to `ldclient/async_config.py`, building on the previously-merged `AsyncBigSegmentsConfig` seed (#462). This is a stacked-PR slice of the async Python SDK epic (SDK-60), unblocked now that #463 merged `AsyncHook`/`AsyncPlugin`. `AsyncConfig` mirrors the sync `Config` surface for the async client: base/events/stream URIs, streaming vs. polling, event buffering, private attributes, big segments, hooks, plugins, HTTP config, application metadata, and the experimental data system config. The concrete `AsyncEventProcessor` is imported only under `TYPE_CHECKING` to keep aiohttp out of the runtime import graph. This is self-contained and reviewable on its own. It unblocks the upcoming async FDv1 polling (PR 7) and async event processor (PR 8), both of which import the full `AsyncConfig`. The public `AsyncConfig` (and `AsyncBigSegmentsConfig`) carry an experimental `.. caution::` note — this API may change without notice and is not yet production-ready. Tracked internally: SDK-2768 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Large new experimental configuration surface touches networking, events, and data-source wiring for the async client, though behavior is additive and sync Config changes are limited to shared constants. > > **Overview** > Adds **`AsyncConfig`** in `ldclient/async_config.py` so **`AsyncLDClient`** can be configured with the same knobs as sync **`Config`**: endpoints, streaming/polling, events, privacy, big segments, hooks/plugins, HTTP, payload filtering, and experimental data-system settings. It wires in **`AsyncFeatureStore`** (default **`AsyncInMemoryFeatureStore`**), **`AsyncHook`** / **`AsyncPlugin`**, and factory hooks for **`AsyncUpdateProcessor`** and **`AsyncEventProcessor`**, with experimental **`.. caution::`** on the public API. > > Sync **`Config`** now reuses shared **`DEFAULT_*_URI`** constants instead of inline URL literals. > > **`interfaces.py`** gains experimental **`AsyncUpdateProcessor`** and **`AsyncEventProcessor`** (async **`stop`**, plus **`flush_and_wait`** on the event processor) for upcoming async polling and event delivery. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 3303a25. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
This slice adds the async counterparts of the SDK's hook and plugin extension points, plus the async flag tracker used by the async client:
AsyncHook(ldclient/hook.py) — abstract base for async hooks.before_evaluation/after_evaluationare coroutines awaited by the async client.AsyncPlugin(ldclient/plugin.py) — abstract base for async plugins.register()is a coroutine (allowing async initialization such as connecting to telemetry backends);get_hooks()remains synchronous and returnsAsyncHookinstances.AsyncFlagTrackerImpl/AsyncFlagValueChangeListener(ldclient/impl/async_flag_tracker.py) — the async flag tracker implementation.Unit tests are added in
ldclient/testing/test_async_hooks.pyandldclient/testing/test_async_flag_tracker.py.The async public classes carry the experimental
.. caution::block, matching the rest of the async surface.This PR depends only on already-merged foundation work and can be reviewed independently.
Tracked internally: SDK-2737
Note
Low Risk
Additive experimental APIs and implementation behind the async client surface; no changes to sync evaluation paths, with behavior covered by new unit tests.
Overview
Adds experimental async extension points and flag-change tracking for
AsyncLDClient, paralleling the syncHook,Plugin, andFlagTrackerAPIs.AsyncHookandAsyncPluginintroduce coroutine-basedbefore_evaluation/after_evaluationandregister(), with syncget_hooks()returningAsyncHookinstances. New public types are marked with the experimental caution block.AsyncFlagTracker(interface) andAsyncFlagTrackerImplimplement async per-flag value listeners: subscription awaits an initial evaluation for a baseline, re-evaluates on config changes, and notifies only when the value differs. Work is scheduled viaAsyncCallbackSchedulerso notifications from worker threads remain safe.Docs clarify that
AsyncReadOnlyStoreis experimental and thatBigSegmentStoreStatusProvider.statusis non-blocking on the async client (available=Falseuntil the first background poll). Unit tests cover hook dispatch semantics and flag-tracker behavior, including cross-thread notify.Reviewed by Cursor Bugbot for commit 733132b. Bugbot is set up for automated code reviews on this repo. Configure here.