Conversation
yocontra
approved these changes
Dec 6, 2018
yocontra
left a comment
yocontra
left a comment
Member
There was a problem hiding this comment.
LGTM - if theres an upgrade guide this would be a good place to link to it.
demurgos
approved these changes
Dec 6, 2018
terinjokes
approved these changes
Dec 6, 2018
terinjokes
left a comment
terinjokes
left a comment
Contributor
There was a problem hiding this comment.
My only suggestion is that we link these bullets to the explanations in the docs.
Member
Author
|
@terinjokes I think being dropped into the APIs docs is pretty rough without reviewing the Getting Started guide first. I'm also planning to revamp the rest of the README to point to both the Getting Started guide and API docs. |
Contributor
Member
|
Sorry, late response.. Still, nicely done! |
This was referenced May 18, 2024
This was referenced May 26, 2024
This was referenced Jun 2, 2024
This was referenced Jun 27, 2024
This was referenced Jul 4, 2024
This was referenced Jul 12, 2024
This was referenced Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How's this look? Am I blatantly missing anything?
@contra @stevelacy @terinjokes @erikkemperman