You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a repository requires GitHub Merge Queue on the trunk branch, clicking "Merge stack" on a stacked PR appears to enqueue only the bottom PR. The UI says the stack can be merged together, but the merge queue only recognizes the PR whose base is the protected trunk branch.
Repro
Create a stack:
PR A targets dev
PR B targets PR A's branch
Ensure both PRs are approved, green, and linear.
Open PR B.
GitHub shows "Able to merge as a stack" and "Merge stack 2".
Click "Merge stack".
Expected behavior
Either:
The entire eligible stack is merged/queued correctly, or
The UI explains that merge queue can only queue the bottom PR and the rest must be merged after each lower layer lands.
Actual behavior
Only the bottom PR is recognized by merge queue. The upper PR remains unmerged and must be merged manually after the lower PR lands.
Why this is confusing
The button says "Merge stack" and shows a count of PRs, which implies the stack will merge as a unit. With required merge queue, the actual behavior is one-layer-at-a-time.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
When a repository requires GitHub Merge Queue on the trunk branch, clicking "Merge stack" on a stacked PR appears to enqueue only the bottom PR. The UI says the stack can be merged together, but the merge queue only recognizes the PR whose base is the protected trunk branch.
Repro
devExpected behavior
Either:
Actual behavior
Only the bottom PR is recognized by merge queue. The upper PR remains unmerged and must be merged manually after the lower PR lands.
Why this is confusing
The button says "Merge stack" and shows a count of PRs, which implies the stack will merge as a unit. With required merge queue, the actual behavior is one-layer-at-a-time.
FYI, our merge queue config is fine:
max_entries_to_build: 5min_entries_to_merge: 1max_entries_to_merge: 3ALLGREENBeta Was this translation helpful? Give feedback.
All reactions