Replies: 1 comment
-
|
Also running into this and it really defeats the purpose of stacks for me. There's no indication of why the squash + merge for the stack is taking so long and when you merge 1 PR, I had to manually merge every subsequent PR manually (then the next one rebases, CI runs, then someone re-reviews due to the stale review). |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I tried to merge my first 4 PR stack eagerly. I have been waiting for stacked PR for years now and think they are important for developer and reviewer velocity (which is made worse by AI on both sides).
Clicked merged. Waited hours. Nothing happened. I have very little workflows to run on merge and it should have been done in minutes if not seconds but nothign happened.
No worries. Stacks are for time shifting developers and reviewers. Merging an entire stack is just connivence. I'll just merge them one by one starting at the bottom.
Oh great. So now manually landing one change made the review stale. I think this is not a great feature before stacks but with stacks this is outright crazy. The whole point was to make reviews easier and now I can't land a full stack and landing each PR in a stack will require re-review.
Beta Was this translation helpful? Give feedback.
All reactions