From e6fd55d8c96aafc7fd0e5d684d18822aa9007fc4 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed, 29 Apr 2026 04:52:14 +0000 Subject: [PATCH 1/2] test(jsweep): add tests for performance_now.cjs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add comprehensive test coverage for performance_now.cjs which lacked tests: - Verify nowMs() returns a number - Verify nowMs() is close to Date.now() - Verify successive calls return non-decreasing values - Verify it uses performance.timeOrigin + performance.now() - Verify sub-millisecond precision support - Verify epoch-scale return values (year 2020–2100 range) - Verify correct addition when performance.now() is zero Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- actions/setup/js/performance_now.test.cjs | 78 +++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 actions/setup/js/performance_now.test.cjs diff --git a/actions/setup/js/performance_now.test.cjs b/actions/setup/js/performance_now.test.cjs new file mode 100644 index 00000000000..d1c786675e8 --- /dev/null +++ b/actions/setup/js/performance_now.test.cjs @@ -0,0 +1,78 @@ +// @ts-check +import { describe, it, expect, vi, afterEach } from "vitest"; +import { createRequire } from "module"; + +const req = createRequire(import.meta.url); +const perfHooks = req("perf_hooks"); + +describe("performance_now.cjs", () => { + afterEach(() => { + vi.restoreAllMocks(); + }); + + it("exports nowMs as a function", () => { + const { nowMs } = req("./performance_now.cjs"); + expect(typeof nowMs).toBe("function"); + }); + + it("returns a number", () => { + const { nowMs } = req("./performance_now.cjs"); + expect(typeof nowMs()).toBe("number"); + }); + + it("returns a value close to Date.now()", () => { + const { nowMs } = req("./performance_now.cjs"); + const before = Date.now(); + const result = nowMs(); + const after = Date.now(); + // Allow 5ms slack for test execution overhead + expect(result).toBeGreaterThanOrEqual(before - 5); + expect(result).toBeLessThanOrEqual(after + 5); + }); + + it("returns an increasing value on successive calls", () => { + const { nowMs } = req("./performance_now.cjs"); + const first = nowMs(); + const second = nowMs(); + expect(second).toBeGreaterThanOrEqual(first); + }); + + it("uses performance.timeOrigin + performance.now()", () => { + vi.spyOn(perfHooks.performance, "timeOrigin", "get").mockReturnValue(1000); + vi.spyOn(perfHooks.performance, "now").mockReturnValue(500.25); + + // Re-require the module to use the mocked values + const { nowMs } = req("./performance_now.cjs"); + const result = nowMs(); + expect(result).toBe(1500.25); + }); + + it("returns a floating-point value when performance.now() has sub-ms precision", () => { + vi.spyOn(perfHooks.performance, "timeOrigin", "get").mockReturnValue(1_700_000_000_000); + vi.spyOn(perfHooks.performance, "now").mockReturnValue(123.456); + + const { nowMs } = req("./performance_now.cjs"); + expect(nowMs()).toBeCloseTo(1_700_000_000_123.456, 2); + }); + + it("returns epoch-scale milliseconds (greater than year 2020)", () => { + const { nowMs } = req("./performance_now.cjs"); + // Jan 1 2020 in ms + expect(nowMs()).toBeGreaterThan(1_577_836_800_000); + }); + + it("returns epoch-scale milliseconds (less than year 2100)", () => { + const { nowMs } = req("./performance_now.cjs"); + // Jan 1 2100 in ms + expect(nowMs()).toBeLessThan(4_102_444_800_000); + }); + + it("handles zero performance.now() value", () => { + const origin = 1_700_000_000_000; + vi.spyOn(perfHooks.performance, "timeOrigin", "get").mockReturnValue(origin); + vi.spyOn(perfHooks.performance, "now").mockReturnValue(0); + + const { nowMs } = req("./performance_now.cjs"); + expect(nowMs()).toBe(origin); + }); +}); From ad5ef12674863bbf0c9568ef45ea6a11e63c3ecf Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 29 Apr 2026 05:29:18 +0000 Subject: [PATCH 2/2] fix: replace flaky Date.now() comparison with performance-based bracket test Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7724fa1c-419a-4d83-9c59-d5c79a08ee45 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --- actions/setup/js/performance_now.test.cjs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/actions/setup/js/performance_now.test.cjs b/actions/setup/js/performance_now.test.cjs index d1c786675e8..c18983e2a72 100644 --- a/actions/setup/js/performance_now.test.cjs +++ b/actions/setup/js/performance_now.test.cjs @@ -20,14 +20,13 @@ describe("performance_now.cjs", () => { expect(typeof nowMs()).toBe("number"); }); - it("returns a value close to Date.now()", () => { + it("returns a value within the current performance-based epoch range", () => { const { nowMs } = req("./performance_now.cjs"); - const before = Date.now(); + const before = perfHooks.performance.timeOrigin + perfHooks.performance.now(); const result = nowMs(); - const after = Date.now(); - // Allow 5ms slack for test execution overhead - expect(result).toBeGreaterThanOrEqual(before - 5); - expect(result).toBeLessThanOrEqual(after + 5); + const after = perfHooks.performance.timeOrigin + perfHooks.performance.now(); + expect(result).toBeGreaterThanOrEqual(before); + expect(result).toBeLessThanOrEqual(after); }); it("returns an increasing value on successive calls", () => {