Repository navigation
[eslint-refiner] ESLint Refiner — Daily Report 2026-07-18 #46357
Closed
Replies: 1 comment
|
This discussion has been marked as outdated by ESLint Refiner. A newer discussion is available at Discussion #46543. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Overview
The
eslint-factoryplugin grew from 12 → 19 registered rules during the 10-day gap since the last run (2026-07-08). This run completed a first-pass review of all 7 new rules and filed 2 refinement issues. With this pass, all 19 rules have been reviewed at least once.Headline finding: the new rules are mature and rigorously tested, and the
actions/setup/jscorpus is disciplined — every new rule shows grounded true positives with zero grounded false positives or false negatives. Two candidate false-positives were investigated and deliberately dropped because the test suites prove the behavior is intended.Key metrics
index.ts)New rules reviewed:
no-github-request-interpolated-route,no-throw-plain-object,no-core-exportvariable-non-string,require-mkdirsync-try-catch,require-new-url-try-catch,require-return-after-core-setfailed,require-spawnsync-error-check.Issues filed
core.*alias-detection inconsistency —no-core-setoutput-non-stringandno-core-exportvariable-non-stringonly match a literalcore/coreObjobject name, while the newerrequire-return-after-core-setfailedscope-resolvesconst c = corealiases andconst { setFailed } = coredestructuring. Proposed: extract a shared resolver and reuse it. False-negative + consistency gap (currently latent — no aliased/destructuredcorein the corpus).Grounded true positives validating the new rules
no-github-request-interpolated-route: catchesgithub.request(POST ${endpoint})(add_reaction.cjs:193, add_reaction_and_edit_comment.cjs:266),"POST " + endpointconcat (add_workflow_run_comment.cjs:444), and${owner}/${repo}interpolated routes (route_slash_command.cjs:180-216). Variable-indirection sites (create_project.cjs:252, update_project.cjs:911) resolve to static typed-placeholder routes — correctly not flagged.require-spawnsync-error-check: all 6 corpusspawnSyncsites already guard.error(true negatives) — rule acts as a regression guard.require-new-url-try-catch: flags unwrapped dynamicnew URL(process.env...)(artifact_client.cjs:73); correctly skips try-wrapped validators (mount_mcp_as_cli.cjs:447, copilot_sdk_sidecar.cjs:26).no-throw-plain-object: all JSON-RPC{ code: -326xx, message }throws (mcp_server_core.cjs, safe_outputs_handlers.cjs, incl. adatakey) correctly exempted.Candidate false-positives dropped (do NOT refile — tested-intended)
require-spawnsync-error-check:.errorchecked as the right operand of&&(or via||/??/ logging) is not recognized as a guard. This is a tested invalid case (test expectsif (status !== 0 && result.error) core.info(...)to be flagged) — an intentional soundness stance, not a bug.no-throw-plain-object: the JSON-RPC exemption requirescodeto be a negative integer literal. A symbolic constant (code: INVALID_PARAMS) would be flagged — but tests explicitly flag positive (500), fractional (-1.5), and-0codes, so literal-only is conservative-by-design.Next actions
coreresolver).index.tsfor a 20th rule; lead with the newest never-reviewed rule.readdirSync/statSync/rmSync—mkdirSyncnow covered),String.replacewithout/g.References:
All reactions