Add getSceneInfo API - #3434
Open
noclone wants to merge 1 commit into
Open
Conversation
|
You are modifying libf3d public API! |
Contributor
Author
|
\ci fast |
Contributor
Author
|
@mwestphal @Meakk please review |
Member
|
ill review asap, sorry for the delay. |
mwestphal
reviewed
Aug 6, 2026
|
|
||
| struct SceneInfo | ||
| { | ||
| int NumberOfFiles = 0; |
Member
There was a problem hiding this comment.
NumberOfImporters would be better at this level
mwestphal
reviewed
Aug 6, 2026
|
|
||
| /** | ||
| * Recover counters describing all imported data. | ||
| * Only actors are taken into account, so volumes contribute no points nor cells. |
Member
There was a problem hiding this comment.
Suggested change
| * Only actors are taken into account, so volumes contribute no points nor cells. | |
| * Only surface actors are taken into account for point and cell count |
mwestphal
reviewed
Aug 6, 2026
| */ | ||
| struct scene_info_t | ||
| { | ||
| /// Number of importers in the scene, which counts every file added with scene::add as well as |
Member
There was a problem hiding this comment.
Suggested change
| /// Number of importers in the scene, which counts every file added with scene::add as well as | |
| /// Number of files in the scene, which counts every file added with scene::add as well as |
There is no concept of importers in the libf3d API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link if any
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
Opus 5 to generate the getSceneInfo java bind, which I reviewed and modified.
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.